Re: [PATCH 2/2] drm/panel: simple: Add Jiangsu Smartwin SMMT043480272A-A19 panel

[neil.armstrong@linaro.org]

On 26/06/2024 18:17, Marco Felsch wrote:
> From: Rouven Czerwinski <r.czerwinski@pengutronix.de>
> 
> Add support for the Jiangsu Smartwin SMMT043480272A-A19 4.3" 480x272
> TFT-LCD panel. The timings are based on the ILI6485 controller IC
> datasheet.
> 
> Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
>   drivers/gpu/drm/panel/panel-simple.c | 32 ++++++++++++++++++++++++++++
>   1 file changed, 32 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index dcb6d0b6ced0..a06ad2cd76f0 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -2719,6 +2719,35 @@ static const struct panel_desc innolux_zj070na_01p = {
>   	},
>   };
>   
> +static const struct display_timing jiangsu_smartwin_smmt043480272a_a19_timing = {
> +	.pixelclock = { 8000000, 9000000, 12000000 },
> +	.hactive = { 480, 480, 480 },
> +	.hback_porch = { 1, 43, 43 },
> +	.hfront_porch = { 4, 8, 75 },
> +	.hsync_len = { 2, 4, 75 },
> +	.vactive = { 272, 272, 272 },
> +	.vback_porch = { 2, 12, 12 },
> +	.vfront_porch = { 2, 8, 37 },
> +	.vsync_len = { 2, 4, 37 },
> +	.flags = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW |
> +		 DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_POSEDGE |
> +		 DISPLAY_FLAGS_SYNC_POSEDGE,
> +};
> +
> +static const struct panel_desc jiangsu_smartwin_smmt043480272a_a19 = {
> +	.timings = &jiangsu_smartwin_smmt043480272a_a19_timing,
> +	.num_timings = 1,
> +	.bpc = 8,
> +	.size = {
> +		.width = 95,
> +		.height = 54,
> +	},
> +	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> +	.bus_flags = DRM_BUS_FLAG_DE_HIGH |
> +		     DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE |
> +		     DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE,
> +};
> +
>   static const struct display_timing koe_tx14d24vm1bpa_timing = {
>   	.pixelclock = { 5580000, 5850000, 6200000 },
>   	.hactive = { 320, 320, 320 },
> @@ -4626,6 +4655,9 @@ static const struct of_device_id platform_of_match[] = {
>   	}, {
>   		.compatible = "innolux,zj070na-01p",
>   		.data = &innolux_zj070na_01p,
> +	}, {
> +		.compatible = "jianda,smmt043480272a-a19",
> +		.data = &jiangsu_smartwin_smmt043480272a_a19,
>   	}, {
>   		.compatible = "koe,tx14d24vm1bpa",
>   		.data = &koe_tx14d24vm1bpa,

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>