From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751513AbdJYLIK (ORCPT <rfc822;w@1wt.eu>);
        Wed, 25 Oct 2017 07:08:10 -0400
Received: from szxga04-in.huawei.com ([45.249.212.190]:8990 "EHLO
        szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750788AbdJYLII (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 25 Oct 2017 07:08:08 -0400
Subject: Re: [PATCH] perf vendor events arm64: Add hip08 implementation
 defined PMU core events
To: Ganapatrao Kulkarni <gklkml16@gmail.com>
References: <1508223699-39274-1-git-send-email-zhangshaokun@hisilicon.com>
 <20171017125926.GE14051@arm.com>
 <c4be39b9-ba1a-0db6-16f3-fafc99ad190d@huawei.com>
 <20171018104910.GB11669@arm.com>
 <49db001c-14c5-74ea-0d60-ccd5d46b0bfe@huawei.com>
 <CAKTKpr71Ec3SLomPu_C1vsqPbjN4BgC973DKwYN7b4QE0ezDzA@mail.gmail.com>
 <f698b4dc-be65-9911-9dee-6f2534c0ab83@huawei.com>
 <CAKTKpr6Z2d4v4VPTGf0xdOTEZvwQ1f5SZ5urOYk3CPJReZp+_A@mail.gmail.com>
CC: Will Deacon <will.deacon@arm.com>,
        Shaokun Zhang <zhangshaokun@hisilicon.com>,
        Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>,
        <linux-kernel@vger.kernel.org>, Linuxarm <linuxarm@huawei.com>,
        <jonathan.cameron@huawei.com>, Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        "Arnaldo Carvalho de Melo" <acme@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>
From: John Garry <john.garry@huawei.com>
Message-ID: <a6a7e027-7bec-8e3a-bd5f-910392fc3080@huawei.com>
Date: Wed, 25 Oct 2017 12:07:41 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <CAKTKpr6Z2d4v4VPTGf0xdOTEZvwQ1f5SZ5urOYk3CPJReZp+_A@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.202.227.238]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
        refid=str=0001.0A020205.59F0708D.0240,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
        ip=0.0.0.0,
        so=2014-11-16 11:51:01,
        dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: c57947254eea56ddc0daa984864de9d4
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 25/10/2017 11:06, Ganapatrao Kulkarni wrote:
> Hi John,
>
> On Thu, Oct 19, 2017 at 3:59 PM, John Garry <john.garry@huawei.com> wrote:
>>>>
>>>> #Family-model,Version,Filename,EventType
>>>> 0x00000000420f5160,v1,cavium,core
>>>> 0x00000000420f5161,v1,cavium,core
>>>
>>>
>>> certainly, there is Part number(PartNum, bits [15:4] ) change from
>>> thunderx2 to thunderx3.
>>> thunderx3 should have its own json file describing all its supported
>>> events.
>>> same applies to other SoCs as well.
>>>
>>> IIUC, the idea of ignoring Revision and Variants is that, the PMU
>>> design/version wont change across Revisions and Variants.
>>>
>>
>> Hi Ganapatrao,
>>
>> Right, I should have modified the part num for my illustration, but I am
>> still concerned. Please see my example in the other mail and check what I am
>> missing.
>

Hi Ganapatrao,

> ok, then my original naming was more appropriate.

It was better.

For now, until we introduce > 1 json per vendor, we're fine with the 
structure as-is.

> i.e have josn files defined in SoC directory, instead of having single
> vendor directory for all SoC json files.
>
> like,
>           pmu-events/arch/arm64/thunderx2
>           pmu-events/arch/arm64/thunderx3
>           pmu-events/arch/arm64/hip08
>           pmu-events/arch/arm64/hip09

We're now looking (slowly) at the task of factoring out the common, 
ARM-recommended events, and this directory structure issue is not a 
blocker, but clarification would be nice.

Cheers,
John