From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B514C3321A2 for ; Fri, 10 Apr 2026 05:21:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775798494; cv=none; b=KodB+km4m0zcFwCBadNoDeCb5i2n2WnS+fFuIR7j33D9VKNKIqNc2OVt24AEyzgL/FF/obq1HsZgGrsNTBNk4AkiNkG8Xw99w5Xsr5x2+Zji80pAY9IsjaLh8Q8CUVgtS6rFe3CWMygAelXpqT5VCzxY6gH+Jz2o5PcjILomFoQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775798494; c=relaxed/simple; bh=yHvOI2JZgbxhhrS18x0i0G5yfw4r80zSgSr0hfssywE=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=L7Bx6SZcEtG4dRVLOfC3+P/gYPN6dHNa9yS1Vr3IX0jmW/OulR4DwpFobjhOOir/WvkAwiVOgpmcbdHW+ncTNcemOOZigMyOd0rgrpmW2Oc5UqQG3RAiJ8OVlWs7NRti6gieH26zR57w3W2KYg7Dpksy7RZ3buuIREGqGr4m6zg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=EFm/x4IP; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XY6QXC7A; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="EFm/x4IP"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XY6QXC7A" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 639NQ7Bh3934665 for ; Fri, 10 Apr 2026 05:21:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= IizYWfGnPeXguJY8VoN9IpzJy4a0fnMYo5oTTGL49d0=; b=EFm/x4IP1CiaFMsX dcZCV1zlJ7zw4ZmY4hK8WZwxwuVCDNGucrVuc0mIcwtyT5kxR4I3qSMHsB/e8/9k ZOIGrf7sxwAUcseroqYEIhRzMmFkHWMn0j4nO6/ZTaPap3lZlSAH6FmJL46xoz22 p7K37GA3u90WJTAA0rYyobPwwh06Y25VCkSXYrC+6Pm+EvUisQRCT84NpwgoQXV8 +yWdUNIR9EhmLk1JLFRsCz67Z/Sb+l6WvFTc/oljFmMsYNjuOk2ioI0rbe019zw0 VHi0/r65bVSxH06T2bzgSUzolxBW9OZJDfyw5kh3ZdB/+yq1hwRiNPTthUuxWQwB 7znu2g== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ded5samy6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 10 Apr 2026 05:21:32 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2b24a00d12cso16640195ad.1 for ; Thu, 09 Apr 2026 22:21:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775798492; x=1776403292; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=IizYWfGnPeXguJY8VoN9IpzJy4a0fnMYo5oTTGL49d0=; b=XY6QXC7AmXanzf00bclrkBA0S7/OQGpsHCBhnXwwuhAW0J9IUhDAf37Wr1mfroQfE+ MA69mRU19gEFbGVXvRXEdzenE0mWbkzDYLDcUnAuEtYetdVYddA0wTde1LE6imG0IQUs GUfIMzGFn4LkQAKm1+f4s+cn3+dbJ3EghRCDyXDqND4+12tbHe2IILe6/FHj35FDV3y/ hsPUXXTNk6oO2gEamMjL1lqV2PpcF8Ccd9nYkQkg1GUN4joaFC/rqQQE8iy89d6y3Rbe LV+i9FmdEm1HKL5J1kruTI9VJWiF8hMwL5w+ZgzfOqYV7q3Y1Q98lCZf0Y2nFbjl8GM4 p2Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775798492; x=1776403292; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IizYWfGnPeXguJY8VoN9IpzJy4a0fnMYo5oTTGL49d0=; b=lZsxU2swa9+lwo05thLmZyTZPLy7Strmkr0YqkCCVhm0FL614h6iZ9DhrmuaHSXjqz uuZ9y+1vNBCbZkIFMHQg56StS8NO+L2H4oDaELAlPr6D95fwBv8Z1tN66Zpcu/ZZW+6l eWRJGz4dqosZen9N4Me0luO28+aWsBl7PXTTV2dZwWXXZRaisFx7mQx5hVwYpPgIydwA FKvOAiWH8JDCdIXmMvkz4PYGBc/fYUVms/V9AIlKO0mNrUfLOy2RivzVC+e0reqrKoX+ bG73cpAmrbCnxvXwW+2A1mySU7VnuaV9ReNEjjlS7wf5t2fgpqKexR9CUCRdLIHbeHbZ 51vQ== X-Forwarded-Encrypted: i=1; AJvYcCWmJhzOSiCNv17G+KjlITB8nPWwOjSRCgHMurxZN/O9aVPWgaOIoZMCSnVThu/OeN7kWyaLKaMFt+Tqvnw=@vger.kernel.org X-Gm-Message-State: AOJu0YwUOhaPC1p8cZX0AoGBLM03vRjzmTyUP6jqTEY1eCMTAbtoqGoY DSEb529lqrJOp2GWn/SmxtTVtUipmn7/z8WCxSDc7Gf/Li68H3f+mY4QDoKBIrxdYrZJhBKr2oC vFe46o1HxAsITW1MSeHCvHG5+HQtKdy6oRSsU7/PoZdRBNkUxho+VocHALNzwIYJnnwY= X-Gm-Gg: AeBDieuLGHQOaWQEgoEchhaZ+bO6Sy+A2Dsi6tVLXCuiCbh3X8liHv14ehIoXnwL6cJ wsjd9jC2z6JQlWQDZYoNy1GhZ+sG/efQRPayn8tUA0lOW5sdmLjq5Ow/dxLNP6f7cJwLL5UAue9 6j4C1qG+KAV943c0Wc+v3T/3VgSXhbViUxAbipCxaZQM8IEeJYMe+SBT/cfqneOr8KN+2+j9YU0 QHCZR1u7Esr+ElFPQjmzpGy5FLxXpUGEVZIbX78RasS+09pYNiUCR4LjQSAwLiK4p9D9TFluvWm IqL6m8x6hA5LOJ2l4gHsaUT//a5ybZ/6Kn6a4EtmGl1Pn5FgsYaBBi68cH2VNoZ6ZIy5z/xBFWq F74HD0eifUWIe64+rZ6LJEDm9KMWPKztsAysch2NLJUccUq0zEwfg X-Received: by 2002:a17:902:a70e:b0:2b2:65db:8c5f with SMTP id d9443c01a7336-2b2d5a1cbfemr13291365ad.27.1775798491284; Thu, 09 Apr 2026 22:21:31 -0700 (PDT) X-Received: by 2002:a17:902:a70e:b0:2b2:65db:8c5f with SMTP id d9443c01a7336-2b2d5a1cbfemr13290865ad.27.1775798490717; Thu, 09 Apr 2026 22:21:30 -0700 (PDT) Received: from [10.218.44.178] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b2d4f469casm13692445ad.81.2026.04.09.22.21.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Apr 2026 22:21:30 -0700 (PDT) Message-ID: Date: Fri, 10 Apr 2026 10:51:19 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 01/11] dt-bindings: crypto: qcom,ice: Fix missing power-domain and iface clk From: Kuldeep Singh To: Harshal Dev , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich , Rob Herring Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Krzysztof Kozlowski References: <20260323-qcom_ice_power_and_clk_vote-v4-0-e36044bbdfe9@oss.qualcomm.com> <20260323-qcom_ice_power_and_clk_vote-v4-1-e36044bbdfe9@oss.qualcomm.com> <873e8ad2-50cd-4c09-9a51-20ad745fe8dc@oss.qualcomm.com> <2b71dd68-ff35-411e-905d-3ffa2ea3efe4@oss.qualcomm.com> <36b4fead-81fe-4b98-9de5-4d524f199569@oss.qualcomm.com> Content-Language: en-US In-Reply-To: <36b4fead-81fe-4b98-9de5-4d524f199569@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: tbOsF0ns-0Gq7eacKfVK2q7xzoX6SIIm X-Proofpoint-GUID: tbOsF0ns-0Gq7eacKfVK2q7xzoX6SIIm X-Authority-Analysis: v=2.4 cv=Ko59H2WN c=1 sm=1 tr=0 ts=69d888dc cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=Z7d3RZfmASx9lX5pdYsA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDEwMDA0NyBTYWx0ZWRfXzeKAJR+khylw KeAyHIarhn3WPNLCPS2zSAMo60jTE9TWx8eJkUF0eYduiAK0WfGu3OVGLEtryLhdFEMRbyF/bH3 e2y4Y4oy68fdaK98iy0DKU/1RQomNO+EFsf8qwRlEi3i55THLzw1rXYdvNhpClZDV4b2v4oLkjE 8x3xaTJwO1o0qFKAbOXlM3YVDUYotn/ZS2SIbYO4/w5oXQ+SbLF/YS3/PJrlEgZ1JCsQiqCr+8v 248iVxlH/ypSmZPNEwQd1CXmsm+RHlOt/K6BEl5g0bwtbTi/OV6eoXHxvub8vNpWoy2pBizePwT y/g5riu5j55PzpVzTFrKP1l2Fkdp5jeubVkPco3xawGpiorvI+5IEvvfyK/bfsaxEx642jROifm Tg5Ou/IZxSuId7Q2lDjaQGC2nJBikmu8IAZoB/w8X32OAw7uzL59yRgllVy3SMf3+8RNkX/7/yU 1weODk9C3ThmzO1V0wg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-10_01,2026-04-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 phishscore=0 bulkscore=0 spamscore=0 suspectscore=0 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604100047 On 4/7/2026 10:28 AM, Kuldeep Singh wrote: >>> Hi Krzysztof, >>> >>> As motive here is to enforce 2 clocks for upcoming targets and keep >>> minItems as 1 for already merged ones for ensuring backward >>> compatibility. Can we do like below? >>> >>> allOf: >>> - if: >>> not: >>> properties: >>> compatible: >>> contains: >>> enum: >>> - qcom,kaanapali-inline-crypto-engine >>> - qcom,qcs8300-inline-crypto-engine >>> - qcom,sa8775p-inline-crypto-engine >>> - qcom,sc7180-inline-crypto-engine >>> - qcom,sc7280-inline-crypto-engine >>> - qcom,sm8450-inline-crypto-engine >>> - qcom,sm8550-inline-crypto-engine >>> - qcom,sm8650-inline-crypto-engine >>> - qcom,sm8750-inline-crypto-engine >>> >>> then: >>> required: >>> - power-domains >>> - clock-names >>> properties: >>> clocks: >>> minItems: 2 >>> clock-names: >>> minItems: 2 >>> >>> This will ensure for every new target addition, default clock count is >>> enforced as 2 default. >>> Please share your thoughts as well. > > Hi Rob/Krzysztof, > > Were you able to review this suggestion? > Please let me know if need to update patch on top of this one to > initiate discussion. > > One advantage i see with suggested approach: > For new target addition, just need to document new compatible string and > no need to update another list everytime. > It's easy to miss adding entry alongside eliza/milos and might make > wrong assumption to authors/dt-checker that 1 clock is still allowed. > Hi Krzysztof/Rob, Kind reminder! Could you please share your thoughts. -- Regards Kuldeep