From: Hans de Goede <hdegoede@redhat.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
"David E. Box" <david.e.box@linux.intel.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Mark Gross <mgross@linux.intel.com>
Subject: Re: [PATCH v1 1/1] platform/x86/intel: pmt: Use y instead of objs in Makefile
Date: Mon, 9 Aug 2021 11:00:39 +0200 [thread overview]
Message-ID: <a6b48303-1a43-5cc2-ec4a-41fed5ae02cb@redhat.com> (raw)
In-Reply-To: <20210806155017.4633-1-andriy.shevchenko@linux.intel.com>
Hi,
On 8/6/21 5:50 PM, Andy Shevchenko wrote:
> The 'objs' is for user space tools, for the kernel modules
> we should use 'y'.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
>
> Hans, feel free to fold in the original commit
>
> drivers/platform/x86/intel/pmt/Makefile | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/platform/x86/intel/pmt/Makefile b/drivers/platform/x86/intel/pmt/Makefile
> index 019103ee6522..279e158c7c23 100644
> --- a/drivers/platform/x86/intel/pmt/Makefile
> +++ b/drivers/platform/x86/intel/pmt/Makefile
> @@ -4,9 +4,9 @@
> # Intel Platform Monitoring Technology Drivers
> #
>
> -pmt_class-objs += class.o
> obj-$(CONFIG_INTEL_PMT_CLASS) += pmt_class.o
> -pmt_telemetry-objs += telemetry.o
> +pmt_class-y := class.o
> obj-$(CONFIG_INTEL_PMT_TELEMETRY) += pmt_telemetry.o
> -pmt_crashlog-objs += crashlog.o
> +pmt_telemetry-y := telemetry.o
> obj-$(CONFIG_INTEL_PMT_CRASHLOG) += pmt_crashlog.o
> +pmt_crashlog-y := crashlog.o
>
prev parent reply other threads:[~2021-08-09 9:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 15:50 Andy Shevchenko
2021-08-09 9:00 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6b48303-1a43-5cc2-ec4a-41fed5ae02cb@redhat.com \
--to=hdegoede@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=david.e.box@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome