From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752405AbdDNMP2 (ORCPT ); Fri, 14 Apr 2017 08:15:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50772 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751159AbdDNMP0 (ORCPT ); Fri, 14 Apr 2017 08:15:26 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 3767C85363 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=hdegoede@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 3767C85363 Subject: Re: [PATCH] staging: rtl8723bs: remove redundant comparisons of unsigned ints with >= 0 To: Colin King , Greg Kroah-Hartman , Larry Finger , devel@driverdev.osuosl.org References: <20170413141346.9791-1-colin.king@canonical.com> Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org From: Hans de Goede Message-ID: Date: Fri, 14 Apr 2017 14:15:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170413141346.9791-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 14 Apr 2017 12:15:25 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 13-04-17 16:13, Colin King wrote: > From: Colin Ian King > > The comparison of mode >= 0 is redundant as mode is a u32 and this > is always true. Remove this redundant code. > > Detected with CoverityScan ("Unsigned compared against 0") > > Signed-off-by: Colin Ian King Patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/staging/rtl8723bs/core/rtw_debug.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_debug.c b/drivers/staging/rtl8723bs/core/rtw_debug.c > index 51cef55d3f76..fc6b94d59c37 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_debug.c > +++ b/drivers/staging/rtl8723bs/core/rtw_debug.c > @@ -1031,7 +1031,7 @@ ssize_t proc_set_ht_enable(struct file *file, const char __user *buffer, size_t > if (buffer && !copy_from_user(tmp, buffer, sizeof(tmp))) { > sscanf(tmp, "%d ", &mode); > > - if (pregpriv && mode >= 0 && mode < 2) { > + if (pregpriv && mode < 2) { > pregpriv->ht_enable = mode; > printk("ht_enable =%d\n", pregpriv->ht_enable); > } > @@ -1150,7 +1150,7 @@ ssize_t proc_set_rx_ampdu(struct file *file, const char __user *buffer, size_t c > > sscanf(tmp, "%d ", &mode); > > - if (pregpriv && mode >= 0 && mode < 2) { > + if (pregpriv && mode < 2) { > pmlmeinfo->bAcceptAddbaReq = mode; > DBG_871X("pmlmeinfo->bAcceptAddbaReq =%d\n", pmlmeinfo->bAcceptAddbaReq); > if (mode == 0) { > @@ -1191,7 +1191,7 @@ ssize_t proc_set_en_fwps(struct file *file, const char __user *buffer, size_t co > if (buffer && !copy_from_user(tmp, buffer, sizeof(tmp))) { > sscanf(tmp, "%d ", &mode); > > - if (pregpriv && mode >= 0 && mode < 2) { > + if (pregpriv && mode < 2) { > pregpriv->check_fw_ps = mode; > DBG_871X("pregpriv->check_fw_ps =%d\n", pregpriv->check_fw_ps); > } >