From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx.nabladev.com (mx.nabladev.com [178.251.229.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 574D627B340 for ; Thu, 15 Jan 2026 17:40:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.251.229.89 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768498820; cv=none; b=Vi1TZYcLd7WmortppGihcrb9elJYxczsgLKX/LHAkaBG7jbr4GNVSSp4GYtqvmeIpC28jxlDUE+QZ7rFPtnhUknoFFd8s2Un7cgNF3+DvEjux+njLykqJSA2rXnBrPTq5GwlQAAnwF5VnFerPNrx4svQ8klNpBwCTEi0t3EAayY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768498820; c=relaxed/simple; bh=G67lDuex4gckVEJkxVOlfLqh9bAqhLM4jz3ghPyfaAk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VkqYeP9H0/uvh5NvC/x/yxL795PMapDs3Yalv3bqJdLG/X+1ETDyZ9cfxdHz1cL60Yub7zRG1cG6+dBpNSvw+sapRUeK5qUyLpQVjzP5BgnkJPg4WhY2PEaJzyWsJgL6SMPBvcfAm8n9YGP5hvvj7xus/inEUXXlrnNym/Ugay8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nabladev.com; spf=pass smtp.mailfrom=nabladev.com; dkim=pass (2048-bit key) header.d=nabladev.com header.i=@nabladev.com header.b=E9IdXzcI; arc=none smtp.client-ip=178.251.229.89 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nabladev.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nabladev.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nabladev.com header.i=@nabladev.com header.b="E9IdXzcI" Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 50C3C10D950; Thu, 15 Jan 2026 18:40:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nabladev.com; s=dkim; t=1768498817; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=HWe7q5/LedQ97yKRXrkDV58Mdvyvd8iQUbyLaitl2ns=; b=E9IdXzcIlvThlVn2gE3eV0cunYAaXrXNQ1CJGBIXjN4RJWySa9epIsupAT+GxzpVS52SRJ hs6yxBVHU5CchS9WA6OloxxvyvIN2/pzhKxdGdiwAzXsHDeemwx1cna+L0j996gkHmJHiM +TywkBVEgVZ2DtGtXNlyPy7yq/DZaJ+v5xt9i7+gJOqz4ihm5rgB3OpobZu+YiWchwmQ8+ +9wVXWOiKKrqSqmLSMNVg6+xL/qAL0eIT1dtGFU9QPa1QtjGsc3KN62C72mfjWrRClcGMO nIvahIrpQ4aqNpWvVt72hxU6QhEkwCV3Mcuk5c1S0j9owzjPtW6KxKZd1VLXZA== Message-ID: Date: Thu, 15 Jan 2026 18:40:15 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mfd: stpmic1: Attempt system shutdown twice in case PMIC is confused To: Lee Jones Cc: linux-kernel@vger.kernel.org, Pascal PAILLET-LME , Paul Cercueil , Sean Nyekjaer , kernel@dh-electronics.com References: <20260109041301.1344783-1-marex@nabladev.com> <20260113123322.GI1902656@google.com> Content-Language: en-US From: Marek Vasut In-Reply-To: <20260113123322.GI1902656@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 On 1/13/26 1:33 PM, Lee Jones wrote: > On Fri, 09 Jan 2026, Marek Vasut wrote: > >> Attempt to shut down again, in case the first attempt failed. >> The STPMIC1 might get confused and the first regmap_update_bits() >> returns with -ETIMEDOUT / -110 . If that or similar transient >> failure occurs, try to shut down again. If the second attempt >> fails, there is some bigger problem, report it to user. >> >> Fixes: 6e9df38f359a ("mfd: stpmic1: Add PMIC poweroff via sys-off handler") >> Signed-off-by: Marek Vasut >> --- >> Cc: Lee Jones >> Cc: Pascal PAILLET-LME >> Cc: Paul Cercueil >> Cc: Sean Nyekjaer >> Cc: kernel@dh-electronics.com >> --- >> drivers/mfd/stpmic1.c | 18 ++++++++++++++++-- >> 1 file changed, 16 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/mfd/stpmic1.c b/drivers/mfd/stpmic1.c >> index 081827bc05961..9ef4049d7db10 100644 >> --- a/drivers/mfd/stpmic1.c >> +++ b/drivers/mfd/stpmic1.c >> @@ -121,9 +121,23 @@ static const struct regmap_irq_chip stpmic1_regmap_irq_chip = { >> static int stpmic1_power_off(struct sys_off_data *data) >> { >> struct stpmic1 *ddata = data->cb_data; >> + int ret; >> + >> + ret = regmap_update_bits(ddata->regmap, MAIN_CR, SOFTWARE_SWITCH_OFF, SOFTWARE_SWITCH_OFF); >> + if (!ret) >> + return NOTIFY_DONE; >> + >> + /* >> + * Attempt to shut down again, in case the first attempt failed. >> + * The STPMIC1 might get confused and the first regmap_update_bits() >> + * returns with -ETIMEDOUT / -110 . If that or similar transient >> + * failure occurs, try to shut down again. If the second attempt >> + * fails, there is some bigger problem, report it to user. >> + */ >> + ret = regmap_update_bits(ddata->regmap, MAIN_CR, SOFTWARE_SWITCH_OFF, SOFTWARE_SWITCH_OFF); > > I think it would be better to put it into a loop with 2 retries. I sent V2 like that now.