From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5669C2046A7 for ; Wed, 8 Jan 2025 21:10:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736370611; cv=none; b=jlmHRsj8xItGDCLjpI7C9M+RVAHwRPOkqHyUWTd/aLhgV4DPAbTYm6tBAJduxk5504rjnE+DX7BsMET7VgTXijxShVU9T0OPafBLGh8tKdABeDRYyUYJfU28L1gxQi8P9+2x54c3HBsmfVXR5+KbNtQ6yZiFZVj1iV/gZqNDxwM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736370611; c=relaxed/simple; bh=yif9L6lLIxtWmtt2ZikfOURJ9G7yTfNEH3Lru/gjY0w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SSa82OSdSmeQaJwZ14SV6khSxZWwopiJm5PKjz6MqVrOisPL1EMQty5aY2uW8Fp21lc9Nit1F7TN1ihzFiV5hn5wT+tJscRX7WR5GY9RmX0D6Q8D788dsW/6vFQ1wIIgv/4YeSqhk3iBrwX2tQAohTol51gmYfKWuXh5ramFtNU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=citrix.com; spf=pass smtp.mailfrom=cloud.com; dkim=pass (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b=uV1TRrmv; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=citrix.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cloud.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="uV1TRrmv" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-385dece873cso131493f8f.0 for ; Wed, 08 Jan 2025 13:10:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1736370608; x=1736975408; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=qYKaNbubZtIGToECD17ZhrvQg4j1tiGsgcrD5+FP+hw=; b=uV1TRrmvHDrjsb9nNcW7iFTh/kcFw6voyTlPgwa03JZNt3joEL8P/eaQjeBdBoEgPR LY4pz+N/KqoAZ1j7QX9xW/4DGqqc4DK7KdW04SQprxq2kKfWU2N/82JxzL2YQo/1otK2 ddjAC3Ws+2H4TMKglQMJXXcOrZXYaF+6y+oIM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736370608; x=1736975408; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qYKaNbubZtIGToECD17ZhrvQg4j1tiGsgcrD5+FP+hw=; b=lPyxdtDPjAQbCUm4tUjiEVIh7JBNqetOT6J099n4rQEllIJMkzJT5anY42ePORXI+9 QwJighM5sCC/x1DKHyQmvlS7DcQPYSsY+5qxXc0sq0jX4jgo9428ma5XnURPWnoQt6mB Huduse1VGTxox4kX6LCoTxDiHqHyHGZAGmVV18Wt3VeXgk/b6JctW6WQdwuET09oHzgh gz/ehloizcIhikwutk3fCYAL5gIjDeFptY9nA+J4oRGUr7XuDJRq2cRUNqL+X/vB8Ugk uJh7g1QCTFIgr2rBNIVhSsFOscB51PzUrvkJ0rJaV4pR/QD6NzuVDboPcAsJmaApCZBQ cYDA== X-Forwarded-Encrypted: i=1; AJvYcCUboiPehZ4VaWniiflGkI6lQdY8++9LvB63WHeGhifjytJPVyOy8KVN8jQz3Wukqy5zk1LSWJxPzt8U5G0=@vger.kernel.org X-Gm-Message-State: AOJu0YwSlj6gzsEZtfpdZYIyE/6oLhVAiqs4XXAVRcF3vuCAzubdV5M3 G47BPtg6vRhh8TbsNGCCS2WUluQex0Z0J4ZgeK8GTX4utaDXxUIJx8ew7Oxlb8C0Kb6MjfZ4YlX xdmtnxw== X-Gm-Gg: ASbGnctKpNRmJib/kpUB3C4qsAe3VWAjJaBjRTcPlXPQboseHcGYMVDy12Szwvon+IG QFwjcGMkaCBuU0p9iTodTNhvLTqk51QMyrnhBNHSzESGjUe0WHDx2JJKpTuliE50+vdRrs5JRQt CeuCR2utJqBGLaM5sDcvqOuvQbZ+jL4DpJHxYf+EmM3BSmOs03UAlinqKkUKhOkNXg3+WbKF+Z0 6ODHCY9KjMB4exlzVOBHhlc5Qu9K+CKMJ/w0cT/3rDO5j7YhhZt/JczPS8URj1mtiI= X-Google-Smtp-Source: AGHT+IHLo9nZ8e9O5TN/melTW0W4EHOa3tZ4iWAtIPYpOlTi0xSHStcQo5nPjHdbbktHvIO7v4bMCQ== X-Received: by 2002:a05:6000:401e:b0:38a:4184:151c with SMTP id ffacd0b85a97d-38a8730ad01mr3662758f8f.27.1736370607674; Wed, 08 Jan 2025 13:10:07 -0800 (PST) Received: from [192.168.86.29] ([83.105.36.37]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e2da63eesm32688325e9.3.2025.01.08.13.10.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jan 2025 13:10:07 -0800 (PST) Message-ID: Date: Wed, 8 Jan 2025 21:10:06 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/1] x86/fred: Fix the FRED RSP0 MSR out of sync with its per CPU cache To: Dave Hansen , "Xin Li (Intel)" , linux-kernel@vger.kernel.org Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com References: <20250108023641.17396-1-xin@zytor.com> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 08/01/2025 8:14 pm, Dave Hansen wrote: > On 1/7/25 18:36, Xin Li (Intel) wrote: >> + * Another option is to leave the FRED RSP0 MSR as-is, because the RESET >> + * state of FRED MSRs is zero and INIT does not change the value of the >> + * FRED MSRs in a CPU offline/online cycle. But it doesn't seem safe to >> + * depend on the properties of INIT as that's way too many things that >> + * could cause bugs. > Wouldn't that also open us up to kexec problems? If the last kernel > (maybe not even Linux) left RSP0 set, then the current kernel might > eventually try to run userspace with the old kernel's RSP0 value. That's why the init code needs to write every control MSR, even if it's filling in 0 because it doesn't want to use the feature. The job of the init code is to go from an unknown state into a good state, not from the INIT/#RESET state. Or someone could finally write down an ABI for Kexec which details who's responsibility it is :) ~Andrew