From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74143C433DF for ; Mon, 24 Aug 2020 18:31:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 43EBA2075B for ; Mon, 24 Aug 2020 18:31:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="tyAhmC5N" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726529AbgHXSbP (ORCPT ); Mon, 24 Aug 2020 14:31:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725780AbgHXSbN (ORCPT ); Mon, 24 Aug 2020 14:31:13 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A63A7C061573 for ; Mon, 24 Aug 2020 11:31:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=eeb/lofeYf1TCWyrHZnrHrCwUORKtAAL/E3G5LqeoV8=; b=tyAhmC5NK1NmIxVurpWk0ICF7W 0GOZihikQ5cGdlRZt9BfRQqngR5HtVAH3DQcGdXkOU+6cUocfIBerC91iW1CFEphd349WGoxVOq1p xKcoMVE9AA10kmv+1W+pxwTt7CDcZL/NGU17dUdS/b/KDvrAgH1xJKYmq8yWB3ak2y0QxiBr2GzB8 G7eGKwOz3CPbCHCbKdZ+U+kFu9yxctqMNghSrfsOuKS2mjUGdDb8vhCsUEGr78vb08PmKHbwqmVeS RuQZzr3Lb7NmvjANm3CJOk4KvNuf2aRFkz2kmtT5ZFIQ3X2+C3MZqfWYTq9GSzHnF9el1bnHZoasu YjYeyNtg==; Received: from [2601:1c0:6280:3f0::19c2] by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAHFF-0000zM-N6; Mon, 24 Aug 2020 18:31:02 +0000 Subject: Re: [PATCH v2 3/9] iommu/ioasid: Introduce ioasid_set APIs To: Jean-Philippe Brucker , Jacob Pan Cc: iommu@lists.linux-foundation.org, LKML , Jean-Philippe Brucker , Lu Baolu , Joerg Roedel , David Woodhouse , Yi Liu , "Tian, Kevin" , Raj Ashok , Eric Auger , Wu Hao References: <1598070918-21321-1-git-send-email-jacob.jun.pan@linux.intel.com> <1598070918-21321-4-git-send-email-jacob.jun.pan@linux.intel.com> <20200824182848.GB3210689@myrica> From: Randy Dunlap Message-ID: Date: Mon, 24 Aug 2020 11:30:47 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200824182848.GB3210689@myrica> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/24/20 11:28 AM, Jean-Philippe Brucker wrote: >> +/** >> + * struct ioasid_data - Meta data about ioasid >> + * >> + * @id: Unique ID >> + * @users Number of active users >> + * @state Track state of the IOASID >> + * @set Meta data of the set this IOASID belongs to >> + * @private Private data associated with the IOASID >> + * @rcu For free after RCU grace period > nit: it would be nicer to follow the struct order and use a ':' after each struct member name, as is done for @id: -- ~Randy