From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EE1933A9C0 for ; Tue, 16 Dec 2025 14:29:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765895376; cv=none; b=UJNXiBMHrjYzOIct8HFN/zlpfXLm6IeaOZPZkuZ6Eonch+eosXSY2Isgl/ALetroBCWXspt+vYr7ztuTkJ8FqiPRkr+2auifskk8msVWYQV0pg2RAkf4SGiuRMXAYhfCVpv6mOT31XYrlSnD7gmLtF8sdiEGhnw7fYxRvii/rvo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765895376; c=relaxed/simple; bh=c3FEfOYe/jyAQH1PXJwhUM2FL/6IdIKpvjQ70OBnrDE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EPJR9puLfX+HH5Mv6FvBrqRm65OHQeDrobvChkwHFhd1lFlGNqtnq3fKmxD81Mta+uc9pxn+JYUZGnlFPTyWKqtT1R/OMe5dIuMpsIFpuhWrf2E1w0q47+Kh9fdYg6L9/2KZvdncUZDKbfTMJQ8ddQmE7OJKcmZoz+G3PwDre8Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HDAS2T41; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bLV4nS/j; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HDAS2T41"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bLV4nS/j" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BGD8lVG2869677 for ; Tue, 16 Dec 2025 14:29:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Bag5kecA822pF0WQ+X7N4mbPAn0hI861/+few71vJvA=; b=HDAS2T41W7zgbG91 dQ4ATQkoDUOO2IEohYE//NGAlpGSldqu9Q/zy7/nzFuYa2A8a2le17sr5uK8oQWb vvg3ia5z48m6+ARCafmbfOBq7eEtBdtEmULanmGRR56fXBlY5rPYEIRibuP9hxsb WrJ6wLkELPi+zuEjuH6y8g7Un+DZyH3KWnVS2p+lWHqznSAK1LtDQhMjJ6ZA69bA eVw+AnbdES+CT0aBzyXViAgqAovQWP1KzrgNMpHoLiH6ph/4GmMU6wc7GBArWv2H 6yjL+v8WT2ENJ3qHKoUS3MAdraBCHDub6+sHQqRDvjBSyWyESE6xU0dI0injBTJG Qp+8ZQ== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b33kw9h7h-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 16 Dec 2025 14:29:33 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8b5ff26d6a9so61881785a.0 for ; Tue, 16 Dec 2025 06:29:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765895373; x=1766500173; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Bag5kecA822pF0WQ+X7N4mbPAn0hI861/+few71vJvA=; b=bLV4nS/j1JtQXecfkEX0uz4lNJaEfjWhsiTUEmJjpzSUBkrgta3HhHaap2YpreOvVM ZN1uTk6U+oxMgP3Bfsbstr2TdSqQKVfto6/88tYmefG39ojPYzop+12c/23Sx0g7r2OU g/cJqThXh+CBgQLr+P/TPr6LIyg6B/EJi205j44k6OuHMq2oTqlNvej2gIY7aMcvy9x6 JUpA89wJJiygEIshuc0gbYrDzI8KriEv0dNyGBvSWL7YrVq9vTWynXcDXppwcIC3mFLC MGy7xfqaGZZ7GaLxeweSoNUKCMMwlskp98zs5v4/9eozebx6pucAMI3y+ThJVoZAmyJu qWhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765895373; x=1766500173; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Bag5kecA822pF0WQ+X7N4mbPAn0hI861/+few71vJvA=; b=n8M0RDN5y9AF1Uuh1Jqt9Q5NDDgsmvKa4f8cDrBXxlgcFP3rcJTlwQRyiQHRYXOJy0 cWcQUMp9slEPkgmAqjQtw7K1UaddOks4+aoyCDvNj0bX1Y/i7T1WzI+W1qxZcagr7EZB 9R044S55mfo8TybgihgcKSWiOn9K5+bLz0qixay+A5Q1IIeaMPI6aMviIAI5cRaXJcwO srYpZprLJNXapqxKr/SrraR9D/LTIDJ34SUTwV4jQ+lqP00/lz1cG3XLCvhKna55FrHQ M2Epo5/lg3q9MXDfHYpytrm11DE3Yl11rKoyD8wKibDgolOMwbPckX5TMuMH13fgjWan sksg== X-Forwarded-Encrypted: i=1; AJvYcCXEB9YjAlZEzd/USCRT2Tomys40VehHV7PfhX+V8iE+n0qgxqI33tkImIkEV/eDNniHwE1OOld8P6FfVbM=@vger.kernel.org X-Gm-Message-State: AOJu0Yzi8lrdwgFvAJS7JBPCMltP4WnzOG6QbEzBcUE64C00h0QUdg0s UvsQYGeq2QNVguHDRvyOgFexoILRYToMVCezGkKcPpPz0YKWeArJpQkqAz03iK2IVfUG0U0oS5l m0PZiPmEiDz2Y/hm1dS+ainHJJbkhZnEydVqlwl0sc67B4NRsRDtj9p1u14iLszhPDMk= X-Gm-Gg: AY/fxX7gDIcCECor/Kon7YiqK1/oDptw/JP/SjGtikrLAmMCmOv3KHvWoClJB6kpSqb OaHFSb5wp4QoWv2LyBN9cTbm4eEWubOsakc2hdsN5Lvz5ngrKMJkR3ZWExHGkzcGTTDcXAdT3x9 ff+yLnYTPShU5Iv+IEMXcoFtZ5cxkZ9RdBQaNLhMcSrKPPssWzygAroQOos9PnAP8zcZLCbCvTD YOyOCdW3+a/GySXlDQisCG7DY4y4uFR8y655nJNktetCCRZbM02ZvsFG5a94GXeJEmSjYG4sT8H BcAR08Zis9uX/sTGVId6Sfr0EXtCX8/m8UA+DJE45OYyq4OC7OGwZmJ6Edeqa9Q090nZXfPSokP RIrAfzI7oqLPN++qr3TSeBlRTwbdDHgPo3P51DtZ6ekqx/jtqEkcQbHHHQlMeJnWYiQ== X-Received: by 2002:ac8:584a:0:b0:4d0:3985:e425 with SMTP id d75a77b69052e-4f1d05c4201mr153857091cf.7.1765895372688; Tue, 16 Dec 2025 06:29:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IGg56N2UhBn4mvoaYcl46OObNBBIdYEYFZMhI5Bwj0doC0rLQakzOzQraWA3NwtVCK5EegdxQ== X-Received: by 2002:ac8:584a:0:b0:4d0:3985:e425 with SMTP id d75a77b69052e-4f1d05c4201mr153856631cf.7.1765895372166; Tue, 16 Dec 2025 06:29:32 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b7cfa29e079sm1771071266b.3.2025.12.16.06.29.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Dec 2025 06:29:31 -0800 (PST) Message-ID: Date: Tue, 16 Dec 2025 15:29:28 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 4/5] mmc: sdhci-msm: Add Device tree parsing logic for DLL settings To: Ram Prakash Gupta , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Adrian Hunter Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, dmitry.baryshkov@oss.qualcomm.com, quic_pragalla@quicinc.com, quic_sayalil@quicinc.com, quic_nitirawa@quicinc.com, quic_bhaskarv@quicinc.com, kernel@oss.qualcomm.com, Sachin Gupta References: <20251215120009.3877889-1-quic_rampraka@quicinc.com> <20251215120009.3877889-5-quic_rampraka@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251215120009.3877889-5-quic_rampraka@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=TLpIilla c=1 sm=1 tr=0 ts=69416ccd cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=COk6AnOGAAAA:8 a=kELM9RU7RCUoAihQJIwA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: DcAAsHr2sS_bBpaEZInZFaGsq5coFSjZ X-Proofpoint-ORIG-GUID: DcAAsHr2sS_bBpaEZInZFaGsq5coFSjZ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE2MDEyNCBTYWx0ZWRfXxxf8t1A4sufb LbtkQjaSm5fEthdF6AV1kOZSvFqJOHofXu1SEdh1wgzjl5m5eCBXK7BepACtFHNEFmRFDA//+Lk IR8LqofVAETWxAZn8F3yYFk4ZYe2aadX+gMqf9fRxd81ffHsvZZ/j89eTev7yydFlbpCXMzvWHX fst1bRr/kpWL5J852AJtIXtfoCyhKSNnCjf3sQDgV5By0sRX6nrMVwc7xi8f5ezWJWjZyC898om vcSEjFMp7IFMTo7rNWpKxd775pG/kCSUpbItJ//xOoxu0+XewubmHat/wZG1eyzETBNWbwUGnQb db67h139Q0e8xqlWHNfTKHsYWUxLNeNU5PuwF4VA10DG03swHp+SZv/k3mH5AyNh/1Pz07dAbKu Df3yV+8R4xXnONSJHHg2NaekppiWzA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-16_02,2025-12-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 clxscore=1015 adultscore=0 priorityscore=1501 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512160124 On 12/15/25 1:00 PM, Ram Prakash Gupta wrote: > From: Sachin Gupta > > This update introduces the capability to configure HS200 > and HS400 DLL settings via the device tree and parsing it. > > Signed-off-by: Sachin Gupta > Signed-off-by: Ram Prakash Gupta > --- [...] > +#define DLL_SIZE 10 > +static int sdhci_msm_dt_parse_dll_info(struct device *dev, struct sdhci_msm_host *msm_host) > +{ > + u32 *dll_table = &msm_host->dll[0].dll_config; > + int ret; > + > + msm_host->artanis_dll = false; > + > + ret = of_property_read_variable_u32_array(dev->of_node, > + "qcom,dll-presets", > + dll_table, DLL_SIZE, DLL_SIZE); > + if (ret == DLL_SIZE) > + msm_host->artanis_dll = true; This feels backwards.. can we first somehow determine whether this platform has the artanis_dll (whatever that is since you didn't explain) and then make decisions on what to retrieve from the DT & how to interpret it? > + return ret; > +} > + > static int sdhci_msm_probe(struct platform_device *pdev) > { > struct sdhci_host *host; > @@ -2580,6 +2612,15 @@ static int sdhci_msm_probe(struct platform_device *pdev) > > msm_host->saved_tuning_phase = INVALID_TUNING_PHASE; > > + /* > + * Parse HSR dll only when property is present in DT. > + */ /* Parse ... */, it's short enough Probably also "DLL" Konrad