From: Andrew Lunn <andrew@lunn.ch>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Alexander Stein <alexander.stein@ew.tq-group.com>,
netdev@vger.kernel.org, Sascha Hauer <s.hauer@pengutronix.de>,
Heiner Kallweit <hkallweit1@gmail.com>,
linux-kernel@vger.kernel.org, kernel@pengutronix.de,
Michael Riesch <michael.riesch@wolfvision.net>
Subject: Re: [PATCH] net: phy: dp83867: Add support for hardware blinking LEDs
Date: Sat, 9 Sep 2023 15:20:05 +0200 [thread overview]
Message-ID: <a6c3fb7b-329a-459c-8c76-96da792b137d@lunn.ch> (raw)
In-Reply-To: <ZPwbmebLiUECCL+x@shell.armlinux.org.uk>
On Sat, Sep 09, 2023 at 08:15:37AM +0100, Russell King (Oracle) wrote:
> On Sat, Sep 09, 2023 at 04:27:31AM +0200, Andrew Lunn wrote:
> > > This works as intended so far. Unfortunately this driver and the PHY LED
> > > framework do not support active-low LEDs (yet).
> >
> > Polarity is something which i've seen a few PHY devices have. It also
> > seems like a core LED concept, not something specific to PHY LEDs. So
> > i think this needs to be partially addressed in the LED core.
>
> However, doesn't the LED layer deals with LED brightness, not by logic
> state? It certainly looks that way, and it's left up to the drivers
> themselves to deal with any polarity inversion - which makes sense if
> the core is just concerned about brightness.
>
> Introducing inversion in the core means drivers will be passed a
> brightness of "100" for off and "0" for on which, do you not think,
> starts to get rather silly?
Documentation/devicetree/bindings/leds/leds-pwm.yaml has:
active-low:
description:
For PWMs where the LED is wired to supply rather than ground.
type: boolean
leds-pwm-multicolor.yaml and leds-bcm6358.txt uses the same
property. There is also one case of: irled/ir-spi-led.yaml
led-active-low:
type: boolean
description:
Output is negated with a NOT gate.
The implementation of the properties is repeated in each driver. So we
probably need to add the parsing of this property in phy_device.c, and
add a led_config() op to struct phy_device to pass polarity
information to the driver.
Andrew
next prev parent reply other threads:[~2023-09-09 13:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 8:47 Sascha Hauer
2023-09-08 9:23 ` Alexander Stein
2023-09-09 2:27 ` Andrew Lunn
2023-09-09 7:15 ` Russell King (Oracle)
2023-09-09 13:20 ` Andrew Lunn [this message]
2023-09-09 2:30 ` Andrew Lunn
2023-10-03 13:46 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6c3fb7b-329a-459c-8c76-96da792b137d@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexander.stein@ew.tq-group.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michael.riesch@wolfvision.net \
--cc=netdev@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®