From: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
To: Easwar Hariharan <eahariha@linux.microsoft.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Jeroen de Borst <jeroendb@google.com>,
Praveen Kaligineedi <pkaligineedi@google.com>,
Shailend Chand <shailend@google.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Kalle Valo <kvalo@kernel.org>, Jeff Johnson <jjohnson@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-wireless@vger.kernel.org, ath11k@lists.infradead.org
Subject: Re: [PATCH net-next v4 2/2] wifi: ath11k: Convert timeouts to secs_to_jiffies()
Date: Thu, 12 Dec 2024 11:48:09 -0800 [thread overview]
Message-ID: <a6d2bfba-c3a8-4cf4-9276-7f7e39671a15@oss.qualcomm.com> (raw)
In-Reply-To: <cc1d5e08-92e0-46d8-badb-2a61482200cf@linux.microsoft.com>
On 12/12/2024 11:17 AM, Easwar Hariharan wrote:
> On 12/12/2024 9:51 AM, Jeff Johnson wrote:
>> On 12/12/2024 9:33 AM, Easwar Hariharan wrote:
>>> Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced
>>>
>>> secs_to_jiffies(). As the value here is a multiple of 1000, use
>>>
>>> secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication.
>>>
>>>
>>>
>>
>> something is wrong with your patch since it introduces a blank line after each
>> line.
>>
>
> This is some sort of weird interaction between b4 and git send-email. I
> used git send-email to send the patches after writing them out with b4
> send so as to edit "net-next" into the subject line. It's good to know
> to not mix the tools in the future.
>
> I can resend from the branch with git send-email directly to avoid this
> if preferred.
>
>> Also if you want the ath11k patch to be taken separately, it goes through the
>> ath tree, not the net tree.
>>
>> /jeff
>>
>
> I don't have a preference on being taken separately, whatever approach
> works best is good with me.
Andrew has this in his mm tree, so let's just have it come from there:
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/commit/?h=mm-everything&id=b3b550379dd1f0b65fac207c9c4d0eb5ed84775e
next prev parent reply other threads:[~2024-12-12 19:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-12 17:33 [PATCH net-next v4 0/2] Converge on using secs_to_jiffies() in netdev Easwar Hariharan
2024-12-12 17:33 ` [PATCH net-next v4 1/2] gve: Convert timeouts to secs_to_jiffies() Easwar Hariharan
2024-12-12 17:38 ` Praveen Kaligineedi
2024-12-12 17:33 ` [PATCH net-next v4 2/2] wifi: ath11k: " Easwar Hariharan
2024-12-12 17:51 ` Jeff Johnson
2024-12-12 19:17 ` Easwar Hariharan
2024-12-12 19:48 ` Jeff Johnson [this message]
2024-12-12 20:12 ` Jeff Johnson
2024-12-15 22:20 ` [PATCH net-next v4 0/2] Converge on using secs_to_jiffies() in netdev patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6d2bfba-c3a8-4cf4-9276-7f7e39671a15@oss.qualcomm.com \
--to=jeff.johnson@oss.qualcomm.com \
--cc=akpm@linux-foundation.org \
--cc=andrew+netdev@lunn.ch \
--cc=ath11k@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=eahariha@linux.microsoft.com \
--cc=edumazet@google.com \
--cc=jeroendb@google.com \
--cc=jjohnson@kernel.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pkaligineedi@google.com \
--cc=shailend@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®