Re: [PATCH 3/3] arm64: dts: rk3399: Add init voltage for vdd_log

From: Kever Yang <kever.yang@rock-chips.com>
To: Doug Anderson <dianders@chromium.org>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
	"Alexis Ballier" <aballier@gentoo.org>,
	"Soeren Moch" <smoch@web.de>,
	"Hugh Cole-Baker" <sigmaris@gmail.com>,
	"Andy Yan" <andyshrk@gmail.com>,
	"Katsuhiro Suzuki" <katsuhiro@katsuster.net>,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	"Pragnesh Patel" <Pragnesh_Patel@mentor.com>,
	"Peter Robinson" <pbrobinson@gmail.com>,
	"Nick Xie" <nick@khadas.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	"Elaine Zhang" <zhangqing@rock-chips.com>,
	"Vicente Bergas" <vicencb@gmail.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Akash Gajjar" <akash@openedev.com>,
	"Ezequiel Garcia" <ezequiel@collabora.com>,
	"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
	"Andrius Štikonas" <andrius@stikonas.eu>,
	"Heiko Stübner" <heiko@sntech.de>,
	LKML <linux-kernel@vger.kernel.org>,
	"Oskari Lemmela" <oskari@lemmela.net>,
	"Robin Murphy" <robin.murphy@arm.com>,
	"Vivek Unune" <npcomplete13@gmail.com>
Subject: Re: [PATCH 3/3] arm64: dts: rk3399: Add init voltage for vdd_log
Date: Thu, 14 Nov 2019 09:53:46 +0800	[thread overview]
Message-ID: <a6d41fc5-4ed5-6ec2-5697-ca2b0abe288c@rock-chips.com> (raw)
In-Reply-To: <CAD=FV=UjbPALRU2r0s27F4RxjsbDyQ+horUBezVQejk1pT=vqA@mail.gmail.com>

Hi Doug,

On 2019/11/14 上午1:01, Doug Anderson wrote:
> Hi,
>
> On Sun, Nov 10, 2019 at 4:52 PM Kever Yang <kever.yang@rock-chips.com> wrote:
>> Since there is no devfreq used for vdd_log, so the vdd_log(pwm regulator)
>> will be 'enable' with the dts node at a default PWM state with high or low
>> output. Both too high or too low for vdd_log is not good for the board,
>> add init voltage for driver to make the regulator get into a know output.
>>
>> Note that this will be used by U-Boot for init voltage output, and this
>> is very important for it may get system hang somewhere during system
>> boot up with regulator enable and without this init value.
> I'm a tad bit confused here.  When U-Boot boots the kernel, how is the
> PWM configured?
>
> I remember folks going through a lot of work to make sure that we
> could actually _read_ the PWM state that the bootloader gave us and
> report it as the initial voltage.  If the kernel ends up needing to
> configure the PWM regulator's period for some reason, I remember it
> would actually pick something close.  Is that not working for you?
>
> For instance, on rk3288-veyron when I boot up mainline (no devfreq on
> rk3288-veyron on mainline) the vdd_logic reports 1.2 volts because it
> read what the bootloader left it as.
>
> ...are you saying that U-Boot doesn't configure the PWM and you're
> trying to fix it up in the kernel?

U-Boot will configure the PWM with dts setting(and now U-Boot would like 
to sync the dts

from kernel directly):

- no dts node for pwm regulator, it will be default as input IO without 
any configure;

- with pwm regulator dts enable, no 'init-microvolt', enable PWM with 
default 0% output;

- with pwm regulator dts with 'init-microvolt', enable PWM with 
corresponding duty output;

We should leave it not configure(around 0.9V for most of board) or 
configure to correct

output(some boards need 0.95V while default is 0.9V for stability issue).

For the rk3399 boards on upstream, some of them do not have a vdd_log in 
dts,

and others have dts node but without 'init-microvolt' for init setting, 
that's what I want

to fix to make sure all the boards can work correctly.

Thanks,

- Kever

>
> -Doug
>
>
> -Doug
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
>