From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DBF521577D for ; Thu, 12 Dec 2024 14:58:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734015519; cv=none; b=SZsz0XyXW9ZKm9XZ/MD3HA8ITbE9yrWh3hF2IAqbBYTUelMsY//o5ggC9/f4F7kZxMYush4VuOCePucGYRWwn+OtgUqScf4p6QQrPbbhB62Uxj59qSbmENzjAGxN3kKxr58GGTLN5e5HnjXyOgg6k2E75r5pXefpfFMh/SHgcWs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734015519; c=relaxed/simple; bh=G6Z2o7H+YRsuJn5EHuxMgQuZNMoz/Zu4aqlYRNiWXyI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=p2gQeSo2zdgkDma49GCuCoqaPlDN7C5sLeFb6OaBvecrq4stPSJ4qIsTYHmUtaEoncbs0cZ7pnyn1F20FoDVQdyEH76FC2rMXBmXc36ltCy6gdtSOohyHrvlH+oelThi0ITJcqm4XkYtkkdiLDm1Fs3wNENzgw7jgQ2ORuBHXs4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ieWMtjHx; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ieWMtjHx" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734015517; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mp7PByfrT26c6XlUU6lXZIxvrN1DU5qMvcLQpbxnk5A=; b=ieWMtjHx/VA8JrMSRqY63odCgsUs32B8CbSf0fmzSTCiV7aAXJ3Uxxmmio9VfBnYnzw4Db 5n/VHlD1v+BrNfgsJRb5dF5JoUy/vATckEKVm1XrLdTjwgrc0appiED284JnH/YTXkYbHp xugjBJDACvd8J4C0Z9aE59oVsIjH73c= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-412-01mZsNMoOWqkI94WSdcm9A-1; Thu, 12 Dec 2024 09:58:35 -0500 X-MC-Unique: 01mZsNMoOWqkI94WSdcm9A-1 X-Mimecast-MFC-AGG-ID: 01mZsNMoOWqkI94WSdcm9A Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4359eb032c9so5690215e9.2 for ; Thu, 12 Dec 2024 06:58:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734015514; x=1734620314; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mp7PByfrT26c6XlUU6lXZIxvrN1DU5qMvcLQpbxnk5A=; b=HBkYLFw8S+DxOHNp2cawZiRUpU1IhdHi7QklbIxG3lBFA3abkHLFC+pZ4dx27c6UxG qZfhzZg1ubdrcPFQ/PDEiIC/YzEqSk86+pegVxWNWdx5nj47VIWeK4O6TyMFPU3YfNwt sXQAfUAr/wTOUFPrkBJXxQWc/6bc1VzaO6f2ayJtMNZfk1jEI2fpp7olA3Cd1hx9jf1U 14MFInCyQZF5YFMQIlarM75KVdc7vw+P1DHmfUuNFFsIh3lJGMoO0akRzrqPhE7opd62 4sD1iyPoGKrKn+ITOs2BUdo4oV2VVE+NsAqY73ELXTYU7CTK2gmXopC353gADSlE5jUh dStw== X-Forwarded-Encrypted: i=1; AJvYcCU3z5DKzFGhCU2u22WsjpXf47e+FsFW4vxmQGbuMGGS+k4Be9uQwbH62ucccbFrtsoxSIwfQbSfo0k+AiQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzSZhiDABJ4gH5jxoHCq3vFCQieSxDJTaNf+u37GGFUKYI+jJq5 brvtGdkxsr7pr1EgsDfgiLmhE71SS38mtyO8hrQG21c21hdpGZ2Mpf2koVH6087bzrntxxW1z0H b3UY/DUWdC9tHXu42iWPR2wgqlJZjJKb7e+wJBrzsjfjdwlKIMjXIo0UB32DiLQ== X-Gm-Gg: ASbGncsOEgQsV5I3X/jTBqg/C0k4ROOFfg6Fd7Cr8JkjvdF1/Iqv+CQRwz/bcUswdsC MMkABOQDv0TNBjYW+ZcKGIzuotQhlr5jZ8o5kt8X7R+hKSIlBVBrJkBCa78mFtKx0hZ4V05YLxp /+n1SY5dUQ+wZwYWlpdq+qXFZdUjOQ9NQW0a04r/mi6R5FQw1r2nigPsQ7e6UG+OIPiBPmdCUCV C3VhHIxPvS1J7k+PkNXS7yM1wdlcXKYHGPJ7O9er7CZZnxtxY8ZaEHAgVKG0rnJNiegkf7nh6nL uCOsDFk= X-Received: by 2002:a05:600c:1e89:b0:435:21a1:b109 with SMTP id 5b1f17b1804b1-436228239d4mr34776265e9.2.1734015514537; Thu, 12 Dec 2024 06:58:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IHoQPXURHNGvrny3f7vl2oVT9jWXY7D4FX6dkSlxmx2R9PGBk/+viTtA90lBPMFXjybTLaFQQ== X-Received: by 2002:a05:600c:1e89:b0:435:21a1:b109 with SMTP id 5b1f17b1804b1-436228239d4mr34775655e9.2.1734015514130; Thu, 12 Dec 2024 06:58:34 -0800 (PST) Received: from [192.168.88.24] (146-241-48-67.dyn.eolo.it. [146.241.48.67]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4362559edc3sm19213025e9.22.2024.12.12.06.58.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Dec 2024 06:58:33 -0800 (PST) Message-ID: Date: Thu, 12 Dec 2024 15:58:30 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 11/11] Remove devres from pci_intx() To: Philipp Stanner , amien Le Moal , Niklas Cassel , Basavaraj Natikar , Jiri Kosina , Benjamin Tissoires , Arnd Bergmann , Greg Kroah-Hartman , Alex Dubov , Sudarsana Kalluru , Manish Chopra , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Rasesh Mody , GR-Linux-NIC-Dev@marvell.com, Igor Mitsyanko , Sergey Matyukevich , Kalle Valo , Sanjay R Mehta , Shyam Sundar S K , Jon Mason , Dave Jiang , Allen Hubbe , Bjorn Helgaas , Alex Williamson , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Mario Limonciello , Chen Ni , Ricky Wu , Al Viro , Breno Leitao , Thomas Gleixner , Kevin Tian , Andy Shevchenko , Mostafa Saleh , Jason Gunthorpe , Yi Liu , Kunwu Chan , Dan Carpenter , "Dr. David Alan Gilbert" , Ankit Agrawal , Reinette Chatre , Eric Auger , Ye Bin Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ntb@lists.linux.dev, linux-pci@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org References: <20241209130632.132074-2-pstanner@redhat.com> <20241209130632.132074-13-pstanner@redhat.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20241209130632.132074-13-pstanner@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/9/24 14:06, Philipp Stanner wrote: > pci_intx() is a hybrid function which can sometimes be managed through > devres. This hybrid nature is undesirable. > > Since all users of pci_intx() have by now been ported either to > always-managed pcim_intx() or never-managed pci_intx_unmanaged(), the > devres functionality can be removed from pci_intx(). > > Consequently, pci_intx_unmanaged() is now redundant, because pci_intx() > itself is now unmanaged. > > Remove the devres functionality from pci_intx(). Have all users of > pci_intx_unmanaged() call pci_intx(). Remove pci_intx_unmanaged(). > > Signed-off-by: Philipp Stanner > --- > drivers/misc/cardreader/rtsx_pcr.c | 2 +- > drivers/misc/tifm_7xx1.c | 6 +-- > .../net/ethernet/broadcom/bnx2x/bnx2x_main.c | 2 +- > drivers/net/ethernet/brocade/bna/bnad.c | 2 +- > drivers/ntb/hw/amd/ntb_hw_amd.c | 4 +- > drivers/ntb/hw/intel/ntb_hw_gen1.c | 2 +- > drivers/pci/devres.c | 4 +- > drivers/pci/msi/api.c | 2 +- > drivers/pci/msi/msi.c | 2 +- > drivers/pci/pci.c | 43 +------------------ > drivers/vfio/pci/vfio_pci_core.c | 2 +- > drivers/vfio/pci/vfio_pci_intrs.c | 10 ++--- > drivers/xen/xen-pciback/conf_space_header.c | 2 +- > include/linux/pci.h | 1 - > 14 files changed, 22 insertions(+), 62 deletions(-) For the net bits: Acked-by: Paolo Abeni