From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753477AbdDLITn (ORCPT <rfc822;w@1wt.eu>);
        Wed, 12 Apr 2017 04:19:43 -0400
Received: from foss.arm.com ([217.140.101.70]:41146 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752803AbdDLITl (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 12 Apr 2017 04:19:41 -0400
Subject: Re: [PATCH] irqchip/irq-imx-gpcv2: Clear OF_POPULATED flag
To: Andrey Smirnov <andrew.smirnov@gmail.com>,
        linux-kernel@vger.kernel.org
References: <20170411164809.13803-1-andrew.smirnov@gmail.com>
Cc: yurovsky@gmail.com, Thomas Gleixner <tglx@linutronix.de>,
        Jason Cooper <jason@lakedaemon.net>
From: Marc Zyngier <marc.zyngier@arm.com>
Organization: ARM Ltd
Message-ID: <a6da3596-c6a1-628f-d4f1-47fd20b53ea4@arm.com>
Date: Wed, 12 Apr 2017 09:19:38 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <20170411164809.13803-1-andrew.smirnov@gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/04/17 17:48, Andrey Smirnov wrote:
> Clear OF_POPULATED flag, so that GPC power domain driver[1] can be
> bound to "gpc" node as well.
> 
> [1] https://lkml.org/lkml/2017/3/28/835
> 
> Cc: yurovsky@gmail.com
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Jason Cooper <jason@lakedaemon.net>
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
> 
> Marc:
> 
> You've expressed you disagreement (in [thread]) for adding generic
> infrastructure to perform this kind of trickery because of its
> DT-specific nature. Any chance this, more contained version of it, is
> acceptable?
> 
> Thanks,
> Andrey Smirnov
> 
> [thread] https://lkml.org/lkml/2017/1/30/241
> 
>  drivers/irqchip/irq-imx-gpcv2.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/irqchip/irq-imx-gpcv2.c b/drivers/irqchip/irq-imx-gpcv2.c
> index 15af9a9..e13236f 100644
> --- a/drivers/irqchip/irq-imx-gpcv2.c
> +++ b/drivers/irqchip/irq-imx-gpcv2.c
> @@ -266,6 +266,11 @@ static int __init imx_gpcv2_irqchip_init(struct device_node *node,
>  	imx_gpcv2_instance = cd;
>  	register_syscore_ops(&imx_gpcv2_syscore_ops);
>  
> +	/*
> +	 * Clear the OF_POPULATED flag set in of_irq_init so that
> +	 * later the GPC power domain driver will not be skipped.
> +	 */
> +	of_node_clear_flag(node, OF_POPULATED);
>  	return 0;
>  }

Fair enough, I'll pick that one. It is still pretty horrible, but given
that this is an issue with the kernel at large, that's probably the best
we can do.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...