From: Alan Stern <stern@rowland.harvard.edu>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net,
linux-kernel@vger.kernel.org
Subject: Re: [usb-storage] [PATCH 1/3] usb: storage: realtek_cr: Improve function parameter data types
Date: Wed, 13 Aug 2025 09:59:05 -0400 [thread overview]
Message-ID: <a6deb8d0-dc8e-4d4a-94d2-ed2617091eef@rowland.harvard.edu> (raw)
In-Reply-To: <20250813101249.158270-2-thorsten.blum@linux.dev>
On Wed, Aug 13, 2025 at 12:12:47PM +0200, Thorsten Blum wrote:
> In rts51x_bulk_transport() and rts51x_read_status(), change the function
> parameters 'buf_len' and 'len' from 'int' to 'unsigned int' because
> their values cannot be negative.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> drivers/usb/storage/realtek_cr.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/storage/realtek_cr.c b/drivers/usb/storage/realtek_cr.c
> index 7dea28c2b8ee..d2c3e3a39693 100644
> --- a/drivers/usb/storage/realtek_cr.c
> +++ b/drivers/usb/storage/realtek_cr.c
> @@ -199,7 +199,8 @@ static const struct us_unusual_dev realtek_cr_unusual_dev_list[] = {
> #undef UNUSUAL_DEV
>
> static int rts51x_bulk_transport(struct us_data *us, u8 lun,
> - u8 *cmd, int cmd_len, u8 *buf, int buf_len,
> + u8 *cmd, int cmd_len, u8 *buf,
> + unsigned int buf_len,
> enum dma_data_direction dir, int *act_len)
> {
> struct bulk_cb_wrap *bcb = (struct bulk_cb_wrap *)us->iobuf;
> @@ -417,7 +418,7 @@ static int rts51x_write_mem(struct us_data *us, u16 addr, u8 *data, u16 len)
> }
>
> static int rts51x_read_status(struct us_data *us,
> - u8 lun, u8 *status, int len, int *actlen)
> + u8 lun, u8 *status, unsigned int len, int *actlen)
> {
> int retval;
> u8 cmnd[12] = { 0 };
I just looked through the original source file. What about
rts51x_bulk_transport_special()? Shouldn't its buf_len parameter also
be unsigned?
For that matter, what about cmd_len in both routines?
And have you checked the corresponding values in all the other
usb-storage subdrivers?
As you can see, worrying about the difference between signed and
unsigned values, when it doesn't really matter, quickly leads to a
morass.
Alan Stern
next prev parent reply other threads:[~2025-08-13 13:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 10:12 Thorsten Blum
2025-08-13 10:12 ` [PATCH 2/3] usb: storage: realtek_cr: Simplify residue calculation in rts51x_bulk_transport() Thorsten Blum
2025-08-13 14:00 ` Alan Stern
2025-08-13 10:12 ` [PATCH 3/3] usb: storage: realtek_cr: Use correct byte order for bcs->Residue Thorsten Blum
2025-08-13 14:00 ` Alan Stern
2025-08-13 14:39 ` Greg Kroah-Hartman
2025-08-13 14:57 ` Thorsten Blum
2025-08-13 13:59 ` Alan Stern [this message]
2025-08-13 15:10 ` [usb-storage] [PATCH 1/3] usb: storage: realtek_cr: Improve function parameter data types Thorsten Blum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6deb8d0-dc8e-4d4a-94d2-ed2617091eef@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=thorsten.blum@linux.dev \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®