From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A18335FF64 for ; Wed, 14 Jan 2026 07:27:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768375682; cv=none; b=J2sI8pxAIE4n2rZfZQrlqrbfk3FsfLbe399eufonM8JE++nDFwnO9jxWVrl/3viLzwUIaV0N3MIK9cZfiYSLots78wtP49qK6d3VcJsGry+y3g9AFmUVeu7SZdAnivZpS45fO9rrddvlvDbTKsLBa1LTA++/u8ySRHgTAzNSJ00= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768375682; c=relaxed/simple; bh=uR3IxCQuplSv7IFD1Fkh1tgHCbiSi/hk2qiPItRTYBg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iTuuHMM1J8wwh5H4l2RH5cjr7W9wnWkGBUNi29nLj9Vf+pdGeYU+87gwAB6UQ6huGCKScYCrN50MsHfQWpJahPLhuIWZSeuYkJkbNc4jI7hqQHwmHVPYWEH8ASuZJbvPO7l2BQE2wulA0cwXOGNM3gH9oYv/SR19tflJpD0kDVI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DlXtE8ES; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OKF375gf; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DlXtE8ES"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OKF375gf" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60E664UV2376478 for ; Wed, 14 Jan 2026 07:27:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Y7k2tgjAg8hmeGu+ou2mei9nPjqC+aosoSBIaKA5fY8=; b=DlXtE8EStOut9Tqq c6QVOvtjFtFDyKD4kg3CVxU6TGHu49ALAFtucCUicRJBunj3hpxh40abnfwalanS 7ChVNHvpU+oZ9l+Ap2MfqeGrKttPrH9UN0UZs254Oi0YwZ4Ux5rOGltUKkFbG1Zl P5yAQJXUz2roItr5ZHuI97jv0fiX+4UL/ekYYZUGhyp8tT/LH5DEdqyv2ZrOXgfC ywAIkbnIYRqdt5QUHdLOOhh8EvQfpVy/v0/A55cgXVD6trFsmSqCUXFwPtCQl2iB z51RlXlXoiiydUhAsBSGyerhJ6kQlWQHB2Yc9y8tCU2YiJBRAIe1rL8y9qXykVmT BpJDWg== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bnymssdfr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 14 Jan 2026 07:27:55 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-81ea3358dd3so3743927b3a.3 for ; Tue, 13 Jan 2026 23:27:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768375674; x=1768980474; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Y7k2tgjAg8hmeGu+ou2mei9nPjqC+aosoSBIaKA5fY8=; b=OKF375gf74016HOIILvUdaEmi2wcFOi5ZZHJFWG0b1vy9Z+uTGx2hyS30nWCgGDH1U SoVlECzOc/w8HFxMuxMwhfhOmzQe2gbeZurWs3WlsOHNcOdamRrlaYPUr3g9QLZfCl71 zepVh6SbTVB3QFEjsLa/A6QAAwqBQE4c7UKa4B09hpUm3XP17xWmBbFOfAxjmni4AxcF ElOuKhay5aH7Dg2pLxLQT3oK8FKW/dgppxeuVSCi1g6FTy93SvdnLrmNhKlUlgS0o28F 9dEzDike8k7tLDV3HzoMKHLWSnnIdcNtWSnuvtZukSB/NrF7IVe1TewrWgmZ1nty0L/H Lo8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768375674; x=1768980474; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Y7k2tgjAg8hmeGu+ou2mei9nPjqC+aosoSBIaKA5fY8=; b=Xm5FQTw8aQvE+M0Hl+EMj6jDqHYdJUxEWN9aqblSkrQ2dZKpnsX5/wG2QtPq7JLjJv MnzP7d98C8kUcsrMM6L3GyXSKyAqbUFdQ27Jhp5TpMQtLkdTYLIXA89qZMpKYaVigRAl o+YUAIrlrSfswX06O/tK/MePZ3NzTTmUKpRKFTIHtoxjS2JW91trocqQ87FBSBbr7YzR 5hvEIYUgIjWUkQ6QQFmrOg3k3zPp1W2EyEHIMXV1QRwenLjW/DeUYnkzF8CLQTvGGqGb rMVCrXq/EFImICmkgWY9PZ7m9mBEnONYU84GeOg3a2YeIum/L0B/ga9R2FV6b7KpokyQ wQlA== X-Forwarded-Encrypted: i=1; AJvYcCV4sbvKa1LyrLkfL7XxiWSca/O8EOYhMY50DoNiX8m9CVuYywCKNzlvvYH+ZuMi8pfZnTHIGOA3iJhxUYo=@vger.kernel.org X-Gm-Message-State: AOJu0Ywnjaxnu+Q/Xjdd5MGjefIktYhtFOjCwky+PvDqoe1wSB6XE2MG fV25w7gkT0SPQUy2W2/ZcEPOzvBzk/fH/LrVIQ5WhlgqFMU5pWGkN6xdslU5i+Ya5RV6psHeou9 1hjPwT2dgpax0Mc/hhGlBeBMrz9Dk3BXOIP66O1d9eyvUGA7VuICSeWQM1kCMTyn7KOo= X-Gm-Gg: AY/fxX5ngJITqp7K5tIHAkJX3jmo5I6GAhXGrHpP+4JcWgWurbPLCzq4KVVu0TXuZpF PYmAdmgg4Co6YN9XxiI10C72pFuQ6pRyDSw/sO5OO1EtRp5+t0/Oz1uY1DQNSD9d9dvOph7Ex1P YLQPjhx60MWN6Wp7v+TgESe7Be+2GANQljcfP5dwVB4UmEh0dwBA4TYkc52m8qiztE7hdV+HrCZ VjvgVQ4SOy8XaZKrIDETgDmqsh+RsWfXQZQoscS2srn9qQ5pQND3jYCdY6YF8PMyHV36kOMjGIx FoVlFRdj2ynE1rk5toPNKCt6bL10VDZMkrnjD2jOpp5QXFbVVY4NgUbndHS797uR7bC5E0lwkYV 32k2TfnY2ueghOegCYgXnG3PtG/6G3qoJHXhhNhp/a+91 X-Received: by 2002:a05:6a00:1f12:b0:81f:52d9:5fe with SMTP id d2e1a72fcca58-81f81fa1bd9mr1478045b3a.33.1768375674451; Tue, 13 Jan 2026 23:27:54 -0800 (PST) X-Received: by 2002:a05:6a00:1f12:b0:81f:52d9:5fe with SMTP id d2e1a72fcca58-81f81fa1bd9mr1478023b3a.33.1768375673926; Tue, 13 Jan 2026 23:27:53 -0800 (PST) Received: from [10.206.109.90] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c4cbfe1ca24sm2855229a12.12.2026.01.13.23.27.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jan 2026 23:27:53 -0800 (PST) Message-ID: Date: Wed, 14 Jan 2026 12:57:42 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 06/11] media: iris: don't specify ubwc_swizzle in the source code Content-Language: en-US To: Dmitry Baryshkov , Bjorn Andersson , Konrad Dybcio , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Akhil P Oommen , Vikash Garodia , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-media@vger.kernel.org, Bryan O'Donoghue References: <20260113-iris-ubwc-v2-0-4346a6ef07a9@oss.qualcomm.com> <20260113-iris-ubwc-v2-6-4346a6ef07a9@oss.qualcomm.com> From: Dikshita Agarwal In-Reply-To: <20260113-iris-ubwc-v2-6-4346a6ef07a9@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE0MDA1NyBTYWx0ZWRfX7TT8DA4L/xor 7XD6y8X0B3AtZKz/2+MzN6P843zGe5ECpBajcBGWgBo5PdWcEw6PgJdl4hivemiAA68ZUzH5+U1 GhKUh9WCAGaCHk1CbZlK1+n3XEp1WAGGD/vkV+kvSr5dputU9J+Keb2qTInFQir/Gv0PmH+xnhJ 2kS+CdyUNhA8L/D3/Ibo7dsFmDKNDw8hyz8oX+EVnnQWb92DiMiSvH3tkRYgvj2JKifkL/tm5M0 AErDhYjl/w76jFz2huyByHSQmhjNjRNGrxfiwJWHJMYN7LBeOkWf7aguleZrv0kimGusJ2eHuCE g0qQgGkown/Smx6ppz7uSpFcp8kAJf7GKWT8zWm/8Blk2mQ1VnyfU20jSJa9IWNlhKRnSik9TAe 649/lp81iPoNaq60x24YK+iilf5RUx4G/7ax6x3UTPiH0mWz94KwH/+kMvUx63h/gYH5/IUvXWR BSlbRHHJ3ymf0nJYBYA== X-Proofpoint-GUID: MY2JAvBErNIuEik7vJG9fenqwdmEIjxN X-Proofpoint-ORIG-GUID: MY2JAvBErNIuEik7vJG9fenqwdmEIjxN X-Authority-Analysis: v=2.4 cv=RuDI7SmK c=1 sm=1 tr=0 ts=6967457b cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=rBqFcrSGyHFvDjdq3-MA:9 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-14_02,2026-01-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 phishscore=0 adultscore=0 priorityscore=1501 spamscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601140057 On 1/13/2026 10:27 PM, Dmitry Baryshkov wrote: > The UBWC swizzle is specified both in the Iris driver and in the > platform UBWC config. Use the platform UBWC configuration instead of > specifying it directly in the source. > > Reviewed-by: Konrad Dybcio > Reviewed-by: Bryan O'Donoghue > Signed-off-by: Dmitry Baryshkov > --- > drivers/media/platform/qcom/iris/iris_hfi_gen2_packet.c | 6 +++--- > drivers/media/platform/qcom/iris/iris_platform_common.h | 3 --- > drivers/media/platform/qcom/iris/iris_platform_gen2.c | 3 --- > 3 files changed, 3 insertions(+), 9 deletions(-) > > diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_packet.c b/drivers/media/platform/qcom/iris/iris_hfi_gen2_packet.c > index a4e60e9d32a4..a880751107c7 100644 > --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_packet.c > +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_packet.c > @@ -169,7 +169,7 @@ void iris_hfi_gen2_packet_sys_init(struct iris_core *core, struct iris_hfi_heade > &payload, > sizeof(u32)); > > - payload = core->iris_platform_data->ubwc_config->bank_swzl_level; > + payload = !!(ubwc->ubwc_swizzle & UBWC_SWIZZLE_ENABLE_LVL1); > iris_hfi_gen2_create_packet(hdr, > HFI_PROP_UBWC_BANK_SWZL_LEVEL1, > HFI_HOST_FLAGS_NONE, > @@ -179,7 +179,7 @@ void iris_hfi_gen2_packet_sys_init(struct iris_core *core, struct iris_hfi_heade > &payload, > sizeof(u32)); > > - payload = core->iris_platform_data->ubwc_config->bank_swz2_level; > + payload = !!(ubwc->ubwc_swizzle & UBWC_SWIZZLE_ENABLE_LVL2); > iris_hfi_gen2_create_packet(hdr, > HFI_PROP_UBWC_BANK_SWZL_LEVEL2, > HFI_HOST_FLAGS_NONE, > @@ -189,7 +189,7 @@ void iris_hfi_gen2_packet_sys_init(struct iris_core *core, struct iris_hfi_heade > &payload, > sizeof(u32)); > > - payload = core->iris_platform_data->ubwc_config->bank_swz3_level; > + payload = !!(ubwc->ubwc_swizzle & UBWC_SWIZZLE_ENABLE_LVL3); > iris_hfi_gen2_create_packet(hdr, > HFI_PROP_UBWC_BANK_SWZL_LEVEL3, > HFI_HOST_FLAGS_NONE, > diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h b/drivers/media/platform/qcom/iris/iris_platform_common.h > index 8421711dbe60..9f9ee67e4732 100644 > --- a/drivers/media/platform/qcom/iris/iris_platform_common.h > +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h > @@ -73,9 +73,6 @@ struct tz_cp_config { > > struct ubwc_config_data { > u32 max_channels; > - u32 bank_swzl_level; > - u32 bank_swz2_level; > - u32 bank_swz3_level; > u32 bank_spreading; > }; > > diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen2.c b/drivers/media/platform/qcom/iris/iris_platform_gen2.c > index 5ae996d19ffd..0f06066d814a 100644 > --- a/drivers/media/platform/qcom/iris/iris_platform_gen2.c > +++ b/drivers/media/platform/qcom/iris/iris_platform_gen2.c > @@ -633,9 +633,6 @@ static const struct platform_clk_data sm8550_clk_table[] = { > > static struct ubwc_config_data ubwc_config_sm8550 = { > .max_channels = 8, > - .bank_swzl_level = 0, > - .bank_swz2_level = 1, > - .bank_swz3_level = 1, > .bank_spreading = 1, > }; > > Reviewed-by: Dikshita Agarwal Thanks, Dikshita