From: Kieran Bingham <kieran.bingham@ideasonboard.com>
To: "Kaaira Gupta" <kgupta@es.iitr.ac.in>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>
Cc: Helen Koike <helen.koike@collabora.com>,
Shuah Khan <skhan@linuxfoundation.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
Subject: Re: [PATCH v2 0/3] media: vimc: Allow multiple capture devices to use the same sensor
Date: Mon, 27 Jul 2020 15:31:33 +0100 [thread overview]
Message-ID: <a6f4eabf-6cd5-950b-f2e3-853370c77629@ideasonboard.com> (raw)
In-Reply-To: <20200724122104.GA18482@kaaira-HP-Pavilion-Notebook>
Hi all,
+Dafna for the thread discussion, as she's missed from the to/cc list.
On 24/07/2020 13:21, Kaaira Gupta wrote:
> On Fri, Jul 24, 2020 at 02:15:21PM +0200, Niklas Söderlund wrote:
> Hi,
>
>> Hi Kaaira,
>>
>> Thanks for your work.
>
> Thanks for yours :D
>
>>
>> On 2020-07-24 17:32:10 +0530, Kaaira Gupta wrote:
>>> This is version 2 of the patch series posted by Niklas for allowing
>>> multiple streams in VIMC.
>>> The original series can be found here:
>>> https://patchwork.kernel.org/cover/10948831/
>>>
>>> This series adds support for two (or more) capture devices to be
>>> connected to the same sensors and run simultaneously. Each capture device
>>> can be started and stopped independent of each other.
>>>
>>> Patch 1/3 and 2/3 deals with solving the issues that arises once two
>>> capture devices can be part of the same pipeline. While 3/3 allows for
>>> two capture devices to be part of the same pipeline and thus allows for
>>> simultaneously use.
>>
>> I'm just curious if you are aware of this series? It would replace the
>> need for 1/3 and 2/3 of this series right?
>
> v3 of this series replaces the need for 1/3, but not the current version
> (ie v4). v4 of patch 2/5 removes the stream_counter that is needed to
> keep count of the calls to s_stream. Hence 1/3 becomes relevant again.
So the question really is, how do we best make use of the two current
series, to achieve our goal of supporting multiple streams.
Having not parsed Dafna's series yet, do we need to combine elements of
both ? Or should we work towards starting with this series and get
dafna's patches built on top ?
Or should patch 1/3 and 3/3 of this series be on top of Dafna's v4 ?
(It might be noteworthy to say that Kaaira has reported successful
multiple stream operation from /this/ series and her development branch
on libcamera).
>> 1. https://lore.kernel.org/linux-media/20200522075522.6190-1-dafna.hirschfeld@collabora.com/
>>
>>>
>>> Changes since v1:
>>> - All three patches rebased on latest media-tree.
>>> Patch 3:
>>> - Search for an entity with a non-NULL pipe instead of searching
>>> for sensor. This terminates the search at output itself.
>>>
>>> Kaaira Gupta (3):
>>> media: vimc: Add usage count to subdevices
>>> media: vimc: Serialize vimc_streamer_s_stream()
>>> media: vimc: Join pipeline if one already exists
>>>
>>> .../media/test-drivers/vimc/vimc-capture.c | 35 ++++++++++++++++++-
>>> .../media/test-drivers/vimc/vimc-debayer.c | 8 +++++
>>> drivers/media/test-drivers/vimc/vimc-scaler.c | 8 +++++
>>> drivers/media/test-drivers/vimc/vimc-sensor.c | 9 ++++-
>>> .../media/test-drivers/vimc/vimc-streamer.c | 23 +++++++-----
>>> 5 files changed, 73 insertions(+), 10 deletions(-)
>>>
>>> --
>>> 2.17.1
>>>
>>
>> --
>> Regards,
>> Niklas Söderlund
--
Regards
--
Kieran
next prev parent reply other threads:[~2020-07-27 14:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 12:02 Kaaira Gupta
2020-07-24 12:02 ` [PATCH v2 1/3] media: vimc: Add usage count to subdevices Kaaira Gupta
2020-07-24 12:02 ` [PATCH v2 2/3] media: vimc: Serialize vimc_streamer_s_stream() Kaaira Gupta
2020-07-24 12:02 ` [PATCH v2 3/3] media: vimc: Join pipeline if one already exists Kaaira Gupta
2020-07-28 12:24 ` Dafna Hirschfeld
2020-07-28 12:48 ` Kaaira Gupta
2020-07-24 12:15 ` [PATCH v2 0/3] media: vimc: Allow multiple capture devices to use the same sensor Niklas Söderlund
2020-07-24 12:21 ` Kaaira Gupta
2020-07-27 14:31 ` Kieran Bingham [this message]
2020-07-27 17:54 ` Helen Koike
2020-07-28 11:39 ` Kaaira Gupta
2020-07-28 12:07 ` Dafna Hirschfeld
2020-07-28 14:00 ` Dafna Hirschfeld
2020-07-28 14:26 ` Kaaira Gupta
2020-07-29 13:05 ` Kieran Bingham
2020-07-29 13:16 ` Dafna Hirschfeld
2020-07-29 13:27 ` Kieran Bingham
2020-07-29 15:24 ` Dafna Hirschfeld
2020-07-31 17:22 ` Kaaira Gupta
2020-08-04 10:24 ` Kieran Bingham
2020-08-04 18:49 ` Kaaira Gupta
2020-08-04 18:52 ` Kaaira Gupta
2020-08-05 15:18 ` Helen Koike
2020-07-30 10:51 ` Laurent Pinchart
2020-07-30 18:09 ` Kaaira Gupta
2020-07-30 22:21 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6f4eabf-6cd5-950b-f2e3-853370c77629@ideasonboard.com \
--to=kieran.bingham@ideasonboard.com \
--cc=dafna.hirschfeld@collabora.com \
--cc=helen.koike@collabora.com \
--cc=kgupta@es.iitr.ac.in \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®