From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>,
Srinivas Kandagatla <srini@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: Abel Vesa <abelvesa@kernel.org>,
linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 4/8] arm64: dts: qcom: hawi: add LPASS audio subsystem nodes
Date: Thu, 22 Oct 2026 10:55:25 +0200 [thread overview]
Message-ID: <a6f54a9b-ffee-4a06-9b32-2f2f47ebb19c@oss.qualcomm.com> (raw)
In-Reply-To: <20260923084627.748920-5-prasad.kumpatla@oss.qualcomm.com>
On 9/23/26 10:46 AM, Prasad Kumpatla wrote:
> Add the Low Power Audio SubSystem (LPASS) device tree infrastructure
> for Hawi to describe the ADSP-based audio pipeline.
>
> Add the GPR (Generic Packet Router) node with q6apm and q6prm audio
> services, LPASS RX, TX and VA macro codecs, SoundWire controllers,
> VA CSR clock provider, and LPI TLMM pinctrl node required by the audio
> subsystem.
>
> Signed-off-by: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
> ---
[...]
> + lpass_rxmacro: codec@72c0000 {
> + compatible = "qcom,hawi-lpass-rx-macro";
> + reg = <0x0 0x072c0000 0x0 0x1000>;
> + clocks = <&q6prmcc LPASS_CLK_ID_RX_CORE_TX_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> + <&q6prmcc LPASS_HW_LPR_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> + <&q6prmcc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> + <&lpass_vamacro>;
> + clock-names = "mclk", "lpr", "dcodec", "fsgen";
1 entry a line would be perfect, in all cases
Otherwise I think this lgtm
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
next prev parent reply other threads:[~2026-10-22 8:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 8:46 [PATCH v1 0/8] ASoC: qcom: Add audio support for Hawi and Maili platforms Prasad Kumpatla
2026-09-23 8:46 ` [PATCH v1 1/8] ASoC: codecs: wsa885x: Reset registers on teardown for B2B playback Prasad Kumpatla
2026-09-23 8:46 ` [PATCH v1 2/8] ASoC: qcom: sc8280xp: add Maili sound card configuration Prasad Kumpatla
2026-09-23 8:46 ` [PATCH v1 3/8] ASoC: dt-bindings: qcom: Add Maili LPASS macro codecs Prasad Kumpatla
2026-09-23 8:51 ` Krzysztof Kozlowski
2026-09-23 8:46 ` [PATCH v1 4/8] arm64: dts: qcom: hawi: add LPASS audio subsystem nodes Prasad Kumpatla
2026-10-22 8:55 ` Konrad Dybcio [this message]
2026-09-23 8:46 ` [PATCH v1 5/8] arm64: dts: qcom: hawi-mtp: enable audio playback and capture Prasad Kumpatla
2026-09-24 4:57 ` Ajay Kumar Nandam
2026-10-22 8:56 ` Konrad Dybcio
2026-09-23 8:46 ` [PATCH v1 6/8] arm64: dts: qcom: maili: add LPASS audio subsystem nodes Prasad Kumpatla
2026-09-23 8:46 ` [PATCH v1 7/8] arm64: dts: qcom: maili-mtp: enable audio playback and capture Prasad Kumpatla
2026-09-24 5:21 ` Ajay Kumar Nandam
2026-09-23 8:46 ` [PATCH v1 8/8] arm64: defconfig: Enable Hawi LPASS LPI pinctrl driver Prasad Kumpatla
2026-09-23 15:32 ` [PATCH v1 0/8] ASoC: qcom: Add audio support for Hawi and Maili platforms Mark Brown
2026-10-12 7:07 ` Aiqun(Maria) Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6f54a9b-ffee-4a06-9b32-2f2f47ebb19c@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=abelvesa@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=prasad.kumpatla@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=srini@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®