From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751311AbdBWVL5 (ORCPT ); Thu, 23 Feb 2017 16:11:57 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:46314 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751201AbdBWVLz (ORCPT ); Thu, 23 Feb 2017 16:11:55 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org ADFC160BDD Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=timur@codeaurora.org Subject: Re: [PATCH v2] arm64: Fix the kernel panic() on QDF2400 platform To: shankerd@codeaurora.org, Catalin Marinas Cc: Mark Rutland , Vikram Sethi , Will Deacon , linux-kernel , James Morse , linux-arm-kernel References: <1487880125-1371-1-git-send-email-shankerd@codeaurora.org> <4d97310a-4b91-07ac-1ce0-faacb8da03b0@codeaurora.org> <3fb32277-9d9e-c84d-4e98-c19ace690433@codeaurora.org> From: Timur Tabi Message-ID: Date: Thu, 23 Feb 2017 15:11:52 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:49.0) Gecko/20100101 Firefox/49.0 SeaMonkey/2.46 MIME-Version: 1.0 In-Reply-To: <3fb32277-9d9e-c84d-4e98-c19ace690433@codeaurora.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/23/2017 03:05 PM, Shanker Donthineni wrote: > Why do you want keep 'pre_ttbr0_update_workaround' in subject, nothing > wrong with macro definition itself. Problem with the caller, not passing > the right arguments. Ok, how about this: arm64: qcom: do not use x1 when calling pre_ttbr0_update_workaround "Fix the kernel panic() on QDF2400 platform" could mean almost anything. There could plenty of future kernel panics on the QDF2400. Also, I think our legal review would insist on saying "Qualcomm Technologies QDF2400", which would make the line too long. -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.