Re: [PATCH v4 1/2] dt-bindings: embedded-controller: Add synology,microp device

[Markus Probst <markus.probst@posteo.de>]

[-- Attachment #1: Type: text/plain, Size: 1257 bytes --]

On Sat, 2026-03-21 at 11:21 +0100, Krzysztof Kozlowski wrote:
> On Fri, Mar 20, 2026 at 11:09:53PM +0100, Markus Probst wrote:
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/leds/common.h>
> > +
> > +    embedded-controller {
> > +      compatible = "synology,microp";
> > +
> > +      power-led {
> > +        color = <LED_COLOR_ID_BLUE>;
> > +        function = LED_FUNCTION_POWER;
> > +      };
> > +
> > +      status-led {
> > +        color = <LED_COLOR_ID_MULTI>;
> > +        function = LED_FUNCTION_STATUS;
> > +      };
> 
> Where are other leds? Binding mentions 4.
> 
Status and Power leds exist on every Synology NAS model I am aware of.
But there are models which have additionally a usb or alert led. The
device nodes for those leds should only be present, if they exist
physically on the device.

> Does that mean that they
> differ on each device?  The EC is tied to specific model, so that would
> be surprising. And if they do not differ, what is exactly the point of
> describing the LEDs in DT?
The color of the leds is different on some models.

I suppose I should add this information to the description.

Thanks
- Markus Probst

> 
> > +    };
> > 
> > -- 
> > 2.52.0
> > 

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 870 bytes --]