Re: [PATCH v13 4/5] wifi: brcmfmac: Add optional lpo clock enable support

[Jacobe Zang <jacobe.zang@wesion.com>]

On 2024/8/28 23:20, Simon Horman wrote:
> On Wed, Aug 28, 2024 at 04:49:25PM +0800, Jacobe Zang wrote:
>> WiFi modules often require 32kHz clock to function. Add support to
>> enable the clock to PCIe driver and move "brcm,bcm4329-fmac" check
>> to the top of brcmf_of_probe. Change function prototypes from void
>> to int and add appropriate errno's for return values that will be
>> send to bus when error occurred.
>>
>> Co-developed-by: Ondrej Jirman <megi@xff.cz>
>> Signed-off-by: Ondrej Jirman <megi@xff.cz>
>> Co-developed-by: Arend van Spriel <arend.vanspriel@broadcom.com>
>> Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
>> Reviewed-by: Sai Krishna <saikrishnag@marvell.com>
>> Signed-off-by: Jacobe Zang <jacobe.zang@wesion.com>
> 
> ...
> 
>> @@ -4452,7 +4454,9 @@ struct brcmf_sdio *brcmf_sdio_probe(struct brcmf_sdio_dev *sdiodev)
>>   	/* Allocate private bus interface state */
>>   	bus = kzalloc(sizeof(*bus), GFP_ATOMIC);
>>   	if (!bus)
>> +		ret = -ENOMEM;
>>   		goto fail;
>> +	}
>>   
> 
> Perhaps a local change didn't make it into git, or something like that.
> But this does not compile. As was also the case in v12.
> Please take time to test your patches, not just the local tree.
> 

Thanks for your correction. I will fix it.

>>   	bus->sdiodev = sdiodev;
>>   	sdiodev->bus = bus;
> 

-- 
Best Regards
Jacobe