From: Steven Price <steven.price@arm.com>
To: Marc Zyngier <maz@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Oliver Upton <oliver.upton@linux.dev>,
Will Deacon <will@kernel.org>, Joey Gouly <joey.gouly@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Zenghui Yu <yuzenghui@huawei.com>,
kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: arm64: Bump KVM_VCPU_MAX_FEATURES
Date: Wed, 27 Nov 2024 15:24:32 +0000 [thread overview]
Message-ID: <a7011738-a084-46fa-947f-395d90b37f8b@arm.com> (raw)
In-Reply-To: <86a5dkvh9o.wl-maz@kernel.org>
On 27/11/2024 15:16, Marc Zyngier wrote:
> On Wed, 27 Nov 2024 14:56:31 +0000,
> Steven Price <steven.price@arm.com> wrote:
>>
>> When the KVM_ARM_VCPU_HAS_EL2 define was added, the value of
>> KVM_VCPU_MAX_FEATURES wasn't incremented, so that feature has never been
>> in the KVM_VCPU_VALID_FEATURES bit mask. This means the HAS_EL2 feature
>> will never be exposed to user space even if the system supports it.
>>
>> Fixes: 89b0e7de3451 ("KVM: arm64: nv: Introduce nested virtualization VCPU feature")
>> Signed-off-by: Steven Price <steven.price@arm.com>
>> ---
>> I might be missing something, and it's possible that
>> KVM_ARM_VCPU_HAS_EL2 is deliberately not exposed yet.
>
> This is on purpose. I'm not planning to enable EL2 support until it is
> ready.
I did suspect that's the case - but it might have been better to knobble
it in system_supported_vcpu_features()/kvm_vcpu_init_check_features()
rather than 'hiding' it in the MAX_FEATURES. But hindsight is a
wonderful thing ;)
>> However I'm
>> working on v6 of the host CCA series and as part of that want to add a
>> new feature but and bump KVM_VCPU_MAX_FEATURES up to 9.
>
> Well, I guess that defines some ordering then! :D
Indeed - I'll try to remember to include note about this "dependency" in
my cover letter. We're likely to need a few more rounds for CCA to be
ready, so hopefully NV will naturally be there in time :D
Thanks,
Steve
next prev parent reply other threads:[~2024-11-27 15:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 14:56 Steven Price
2024-11-27 15:16 ` Marc Zyngier
2024-11-27 15:24 ` Steven Price [this message]
2024-11-27 15:41 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7011738-a084-46fa-947f-395d90b37f8b@arm.com \
--to=steven.price@arm.com \
--cc=catalin.marinas@arm.com \
--cc=joey.gouly@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®