From: "Govindarajulu Varadarajan (gvaradar)" <gvaradar@cisco.com>
To: "Christian Benvenuti (benve)" <benve@cisco.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"lyl2019@mail.ustc.edu.cn" <lyl2019@mail.ustc.edu.cn>,
"Govindarajulu Varadarajan (gvaradar)" <gvaradar@cisco.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] ethernet:enic: Fix a use after free bug in enic_hard_start_xmit
Date: Mon, 3 May 2021 07:21:42 +0000 [thread overview]
Message-ID: <a7063675191930af6b5be0566244534de558869a.camel@cisco.com> (raw)
In-Reply-To: <20210502115818.3523-1-lyl2019@mail.ustc.edu.cn>
On Sun, 2021-05-02 at 04:58 -0700, Lv Yunlong wrote:
> In enic_hard_start_xmit, it calls enic_queue_wq_skb(). Inside
> enic_queue_wq_skb, if some error happens, the skb will be freed
> by dev_kfree_skb(skb). But the freed skb is still used in
> skb_tx_timestamp(skb).
>
> My patch makes enic_queue_wq_skb() return error and goto spin_unlock()
> incase of error. The solution is provided by Govind.
> See https://lkml.org/lkml/2021/4/30/961.
>
> Fixes: fb7516d42478e ("enic: add sw timestamp support")
> Signed-off-by: Lv Yunlong <lyl2019@mail.ustc.edu.cn>
Thanks,
Acked-by: Govindarajulu Varadarajan <gvaradar@cisco.com>
next prev parent reply other threads:[~2021-05-03 7:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-02 11:58 Lv Yunlong
2021-05-03 7:21 ` Govindarajulu Varadarajan (gvaradar) [this message]
2021-05-03 20:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7063675191930af6b5be0566244534de558869a.camel@cisco.com \
--to=gvaradar@cisco.com \
--cc=benve@cisco.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyl2019@mail.ustc.edu.cn \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®