From: "Andrew Jeffery" <andrew@aj.id.au>
To: "Colin King" <colin.king@canonical.com>,
"Jeremy Kerr" <jk@ozlabs.org>, "Joel Stanley" <joel@jms.id.au>,
"Alistair Popple" <alistair@popple.id.au>,
"Eddie James" <eajames@linux.ibm.com>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
linux-fsi@lists.ozlabs.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fsi: fix bogos error returns from cfam_read and cfam_write
Date: Fri, 29 Nov 2019 09:02:39 +1030 [thread overview]
Message-ID: <a709068c-9375-4921-a87f-c5f3a1f63cf2@www.fastmail.com> (raw)
In-Reply-To: <20191122233120.110344-1-colin.king@canonical.com>
On Sat, 23 Nov 2019, at 10:01, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> In the case where errors occur in functions cfam_read and cfam_write
> the error return code in rc is not returned and a bogus non-error
> count size is returned instead. Fix this by returning the correct
> error code when an error occurs or the count size if the functions
> worked correctly.
>
> Addresses-Coverity: ("Unused value")
> Fixes: d1dcd6782576 ("fsi: Add cfam char devices")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
next prev parent reply other threads:[~2019-11-28 22:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 23:31 Colin King
2019-11-28 22:32 ` Andrew Jeffery [this message]
2019-11-28 23:20 ` Joel Stanley
2019-11-29 3:24 ` [PATCH] [PATCH v2] fsi: fix bogus " Jeremy Kerr
2019-11-29 9:03 ` Colin Ian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a709068c-9375-4921-a87f-c5f3a1f63cf2@www.fastmail.com \
--to=andrew@aj.id.au \
--cc=alistair@popple.id.au \
--cc=benh@kernel.crashing.org \
--cc=colin.king@canonical.com \
--cc=eajames@linux.ibm.com \
--cc=jk@ozlabs.org \
--cc=joel@jms.id.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fsi@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®