From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31281C67871 for ; Mon, 24 Oct 2022 23:07:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229868AbiJXXHw (ORCPT ); Mon, 24 Oct 2022 19:07:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230514AbiJXXHE (ORCPT ); Mon, 24 Oct 2022 19:07:04 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB9233C15A for ; Mon, 24 Oct 2022 14:28:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666646821; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1ebv5PfsZX2R6eh39y9WmbJdsnetujUEQgGrB9f3X2I=; b=VW4YSglzhxkHZGW6TGDCmGHyFRqGfG7ZQ99g2/huSMJRVn/oHquWoZwXkqYh80+koXwHv/ kOtjsQpIohjsbGze0ucc93va4/88ikxDtB8UWns8JotXu6vF6N4OhNvcHNfNEdC9/jiHZP lU5DsplpAE6Wh3D0wxcNFGSUL7gNqu4= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-665-iiNQAcrBMC-GFdbZfn7KXw-1; Mon, 24 Oct 2022 09:47:40 -0400 X-MC-Unique: iiNQAcrBMC-GFdbZfn7KXw-1 Received: by mail-ed1-f72.google.com with SMTP id c9-20020a05640227c900b0045d4a88c750so9665823ede.12 for ; Mon, 24 Oct 2022 06:47:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1ebv5PfsZX2R6eh39y9WmbJdsnetujUEQgGrB9f3X2I=; b=tUz/4LbG3yh99qxZWRgEBunVMR15NHHJGTRPSN2nwEoLdd23UAtSZ1ZJ3HWa730U2x EECQ9XZkhAiy011KknV9XndulN5E0U+mx5kEzjHHFwecDGj3xDlLowA8EavuQvwg3EVn 08JSOUqJZkD3kgKjKEXlGmGZbWw/CQwuB30JEDwFFeoShj444fr/1kXKEcztNfi09IOI Czo6fJ2kdw9oHoueRa937QOYXsaceYBnjqcuJ6wV3hC6wRzF5qoI/EZm2o+o0bNKQGLC Gk7o6veBGoLSbznynwFbOuSa8XENuQrX6rDktOUJ0aAePtLUYgZYNIkURu88zDAnkH7Q /Fpg== X-Gm-Message-State: ACrzQf1L+MHP2Bax19fPyVfoP0+U5sv9yJmqpPCL72ckdgQ8SHaAEvcR b9i6aCx1KA64Q6E4Ey2eTWXzUxR7HMq63a9XK0voL2zc1nvNtuZzgBRCoGFR+JVBEFPrFRRgjpU 2zCAX5mVFmzFPaLHOc5UxERud X-Received: by 2002:a17:907:a067:b0:7a7:dc5e:eb2d with SMTP id ia7-20020a170907a06700b007a7dc5eeb2dmr4709569ejc.121.1666619259238; Mon, 24 Oct 2022 06:47:39 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7oLEXiE5I2sif+CugVS4fAFykp7aZ+J8hwrp6+8o79Py19z5YlVBnOblcNVHSJKIVCIbJM4Q== X-Received: by 2002:a17:907:a067:b0:7a7:dc5e:eb2d with SMTP id ia7-20020a170907a06700b007a7dc5eeb2dmr4709548ejc.121.1666619259029; Mon, 24 Oct 2022 06:47:39 -0700 (PDT) Received: from [10.40.98.142] ([78.108.130.194]) by smtp.gmail.com with ESMTPSA id ck5-20020a0564021c0500b00461b169c02csm2670629edb.91.2022.10.24.06.47.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Oct 2022 06:47:38 -0700 (PDT) Message-ID: Date: Mon, 24 Oct 2022 15:47:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2] platform/x86: dell-ddv: Minor style fixes Content-Language: en-US To: Armin Wolf , markgross@kernel.org Cc: andriy.shevchenko@intel.com, rafael@kernel.org, lenb@kernel.org, hmh@hmh.eng.br, matan@svgalib.org, corentin.chary@gmail.com, jeremy@system76.com, productdev@system76.com, mario.limonciello@amd.com, pobrn@protonmail.com, coproscefalo@gmail.com, platform-driver-x86@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220928221501.3823-1-W_Armin@gmx.de> From: Hans de Goede In-Reply-To: <20220928221501.3823-1-W_Armin@gmx.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 9/29/22 00:15, Armin Wolf wrote: > Fix some style issues found during review to improve > code maintainability, no functional changes. > > Tested on a Dell Inspiron 3505. > > Signed-off-by: Armin Wolf Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > Changes in v2: > - change commit message > --- > drivers/platform/x86/dell/dell-wmi-ddv.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/drivers/platform/x86/dell/dell-wmi-ddv.c b/drivers/platform/x86/dell/dell-wmi-ddv.c > index 6ccce90f475d..699feae3c435 100644 > --- a/drivers/platform/x86/dell/dell-wmi-ddv.c > +++ b/drivers/platform/x86/dell/dell-wmi-ddv.c > @@ -1,13 +1,12 @@ > // SPDX-License-Identifier: GPL-2.0-or-later > /* > - * dell-wmi-ddv.c -- Linux driver for WMI sensor information on Dell notebooks. > + * Linux driver for WMI sensor information on Dell notebooks. > * > * Copyright (C) 2022 Armin Wolf > */ > > #define pr_format(fmt) KBUILD_MODNAME ": " fmt > > -#include > #include > #include > #include > @@ -21,6 +20,8 @@ > #include > #include > > +#include > + > #define DRIVER_NAME "dell-wmi-ddv" > > #define DELL_DDV_SUPPORTED_INTERFACE 2 > @@ -52,7 +53,8 @@ enum dell_ddv_method { > > struct dell_wmi_ddv_data { > struct acpi_battery_hook hook; > - struct device_attribute temp_attr, eppid_attr; > + struct device_attribute temp_attr; > + struct device_attribute eppid_attr; > struct wmi_device *wdev; > }; > > @@ -153,8 +155,9 @@ static int dell_wmi_ddv_query_string(struct wmi_device *wdev, enum dell_ddv_meth > > static int dell_wmi_ddv_battery_index(struct acpi_device *acpi_dev, u32 *index) > { > - const char *uid_str = acpi_device_uid(acpi_dev); > + const char *uid_str; > > + uid_str = acpi_device_uid(acpi_dev); > if (!uid_str) > return -ENODEV; > > -- > 2.30.2 >