From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: "chr[]" <chris@rudorff.com>, "Linus Walleij" <linusw@kernel.org>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: qcom: msm8916-samsung-j5: Add proximity sensor
Date: Thu, 22 Oct 2026 15:46:19 +0200 [thread overview]
Message-ID: <a7114c6a-2ce4-4e16-8911-d5459d4bb362@oss.qualcomm.com> (raw)
In-Reply-To: <2b091dc3-9588-4042-8908-2fc3adba6cf5@rudorff.com>
On 10/22/26 3:35 PM, chr[] wrote:
> Am 16.10.26 um 17:11 schrieb Konrad Dybcio:
>> On 10/16/26 4:43 PM, Christoph Rudorff wrote:
>>> J5 got a gp2ap002 sensor, add it and it's supplies to the device tree
>>>
>>> Signed-off-by: Christoph Rudorff <chris@rudorff.com>
>>> ---
>>> .../boot/dts/qcom/msm8916-samsung-j5-common.dtsi | 19 ++++++++++
>>> arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dts | 40 ++++++++++++++++++++++
>>
>> It's odd for the regulator and pin setting to be common, but the
>> sensor to only be there for one of these devices
>>
>> Konrad
>
> Hi Konrad,
>
> in patchv3 I removed the settings from common
> and renamed some labels.
>
> Is that ok?
I guess we'll see when you send it?
Konrad
next prev parent reply other threads:[~2026-10-22 13:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 14:43 [PATCH 0/3] from my MSM8916-mainline: Christoph Rudorff
2026-10-16 14:43 ` [PATCH 1/3] iio: light: gp2ap002: add led power supply Christoph Rudorff
2026-10-17 0:05 ` Jonathan Cameron
2026-10-16 14:43 ` [PATCH 2/3] iio: light: Update DT bindings for GP2AP002 Christoph Rudorff
2026-10-16 14:45 ` Krzysztof Kozlowski
2026-10-16 14:58 ` chr[]
2026-10-16 21:01 ` Linus Walleij
2026-10-17 9:18 ` chr[]
2026-10-18 21:05 ` Linus Walleij
2026-10-16 14:43 ` [PATCH 3/3] arm64: dts: qcom: msm8916-samsung-j5: Add proximity sensor Christoph Rudorff
2026-10-16 15:11 ` Konrad Dybcio
2026-10-22 13:35 ` chr[]
2026-10-22 13:46 ` Konrad Dybcio [this message]
2026-10-22 14:27 ` chr[]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7114c6a-2ce4-4e16-8911-d5459d4bb362@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=andy@kernel.org \
--cc=chris@rudorff.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®