From: Mark Brown <broonie@kernel.org>
To: Praveen Talari <praveen.talari@oss.qualcomm.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org,
mukesh.savaliya@oss.qualcomm.com,
aniket.randive@oss.qualcomm.com,
chandana.chiluveru@oss.qualcomm.com,
jyothi.seerapu@oss.qualcomm.com
Subject: Re: [PATCH v2 1/2] spi: qcom-geni: trace: Add trace events for Qualcomm GENI SPI
Date: Mon, 18 May 2026 15:07:23 +0100 [thread overview]
Message-ID: <a713082f-e84e-403a-af1d-c6fa0c5d8613@sirena.org.uk> (raw)
In-Reply-To: <20260512-add-tracepoints-for-qcom-geni-spi-v2-1-3b184068ecf9@oss.qualcomm.com>
[-- Attachment #1: Type: text/plain, Size: 604 bytes --]
On Tue, May 12, 2026 at 11:42:52AM +0530, Praveen Talari wrote:
> +TRACE_EVENT(geni_spi_fifo_params,
> + TP_PROTO(struct device *dev, u8 cs, u32 mode,
> + u32 mode_changed, bool cs_changed),
> + TP_ARGS(dev, cs, mode, mode_changed, cs_changed),
> +
> + TP_STRUCT__entry(__string(name, dev_name(dev))
> + __field(u8, cs)
> + __field(u32, mode)
> + __field(u32, mode_changed)
> + __field(bool, cs_changed)
These don't really seem like FIFO parameters? I see that's the name of
the function where we log this but they're more just generic bus status
things.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-05-18 14:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 6:12 [PATCH v2 0/2] Add trace events for Qualcomm GENI SPI drivers Praveen Talari
2026-05-12 6:12 ` [PATCH v2 1/2] spi: qcom-geni: trace: Add trace events for Qualcomm GENI SPI Praveen Talari
2026-05-18 13:44 ` Konrad Dybcio
2026-05-18 14:07 ` Mark Brown [this message]
2026-05-18 15:52 ` Praveen Talari
2026-05-18 15:56 ` Mark Brown
2026-05-12 6:12 ` [PATCH v2 2/2] spi: qcom-geni: Add trace events for Qualcomm GENI SPI driver Praveen Talari
2026-05-18 13:44 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a713082f-e84e-403a-af1d-c6fa0c5d8613@sirena.org.uk \
--to=broonie@kernel.org \
--cc=aniket.randive@oss.qualcomm.com \
--cc=chandana.chiluveru@oss.qualcomm.com \
--cc=jyothi.seerapu@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mukesh.savaliya@oss.qualcomm.com \
--cc=praveen.talari@oss.qualcomm.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®