From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C69D7C4332F for ; Fri, 25 Nov 2022 13:00:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229863AbiKYNAm (ORCPT ); Fri, 25 Nov 2022 08:00:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230023AbiKYNAX (ORCPT ); Fri, 25 Nov 2022 08:00:23 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E27E42A73C for ; Fri, 25 Nov 2022 05:00:19 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id n7so6634776wrr.13 for ; Fri, 25 Nov 2022 05:00:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=HS8kOP96cOEwK5CtLjrL+jNJR3b230Y/mNQgeiCCJnI=; b=rT+mRtnSJ9aBu/l3FEvjyaAPwGJHnk5zm0LihU/tYwXrPQBAB/MidoESkZ8IEtmXDZ Ko70IfTjNFdij2H0r/q7lc3dO8hdAFGpCpCVeRp+0xiSybGo9tJnRjn+5Jb++bWCutbI F0A7/gyVH23KgEkXgWbA49ONQZonIi/S/PH3mUkrhNycUI7pC56jv8UErECcYtRse638 /ofVOLBQl9WTPANBXwSwX9rNT+xJcqcyCbmoz4Df4OAINGhnO8y2Mvc9nYBKHrgkZz0Z i0P0XO1lit6teTkDv7Dc2L254jPmDtXHgrqu6MDFaPZlXdgOdj3TkFetKpCcfZrSLggU 3IOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HS8kOP96cOEwK5CtLjrL+jNJR3b230Y/mNQgeiCCJnI=; b=SB6R2OwHdFMCh7fVjNCjWDE2SvWsTR/aUg3bBahggU8LYTf3dzzl+L+9SDbNQ04GsH aMdLHbSXabEOVHP83jQd092cYWL8XGlYKFFfJorXN+Hlgfh3fBZ+ZoWqm5lUttsn7KZg /f8euNH1heLW6yeOSxRGgg1OFLg8d7ocBavSLAxwDTaCFPxNgOTH5rHxaSO1G9Kw/C9b j2gSGNx9ApBilINMSJn1cEgAtig0sYbQ0myenWTr9cMZJdFf6yk+6UAVlaqbKlm/Jmsq i1yeCaLpjZW6ncluBIWUglkf8Ne2zyRCew6vBU3RcvY1Ck7qdaIFPdZeaj0JLwVLHVk+ DBOw== X-Gm-Message-State: ANoB5pm5E6HN5Mods43GIyaGa6QpJRv2Ktt7zRFnBX5ymcj2K53JrDFa KnMTmfsrak09NRkL4j1G31OCMA== X-Google-Smtp-Source: AA0mqf7+O1dsaHdK++CkS9wMWnC7AqPy/Gta582CwlXV98mjsAwcepF9VReEzIB55w2u+cCe/GUGlQ== X-Received: by 2002:a5d:65ce:0:b0:241:e1c3:caaa with SMTP id e14-20020a5d65ce000000b00241e1c3caaamr11203982wrw.458.1669381218324; Fri, 25 Nov 2022 05:00:18 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:84a5:7e09:b15:f1fe? ([2a01:e0a:982:cbb0:84a5:7e09:b15:f1fe]) by smtp.gmail.com with ESMTPSA id x8-20020adff0c8000000b00241f632c90fsm4198949wro.117.2022.11.25.05.00.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Nov 2022 05:00:17 -0800 (PST) Message-ID: Date: Fri, 25 Nov 2022 14:00:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 4/6] arm64: dts: meson-g12-common: Add reference to NNA reset to pwrc Content-Language: en-US To: Tomeu Vizoso Cc: Rob Herring , Krzysztof Kozlowski , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/Amlogic Meson SoC support" , "open list:ARM/Amlogic Meson SoC support" , open list References: <20221125111921.37261-1-tomeu.vizoso@collabora.com> <20221125111921.37261-5-tomeu.vizoso@collabora.com> Organization: Linaro Developer Services In-Reply-To: <20221125111921.37261-5-tomeu.vizoso@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/11/2022 12:19, Tomeu Vizoso wrote: > Based on the power sequence in the downstream driver. > > Signed-off-by: Tomeu Vizoso > --- > arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi > index 45947c1031c4..fa96fddf4633 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi > @@ -1625,10 +1625,11 @@ pwrc: power-controller { > <&reset RESET_VDAC>, > <&reset RESET_VDI6>, > <&reset RESET_VENCL>, > - <&reset RESET_VID_LOCK>; > + <&reset RESET_VID_LOCK>, > + <&reset RESET_NNA>; I think this should go in the npu node instead, those are for the VPU power domain. > reset-names = "viu", "venc", "vcbus", "bt656", > "rdma", "venci", "vencp", "vdac", > - "vdi6", "vencl", "vid_lock"; > + "vdi6", "vencl", "vid_lock", "nna"; > clocks = <&clkc CLKID_VPU>, > <&clkc CLKID_VAPB>; > clock-names = "vpu", "vapb";