From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751233AbeAVSMr (ORCPT <rfc822;w@1wt.eu>);
        Mon, 22 Jan 2018 13:12:47 -0500
Received: from mout.web.de ([212.227.15.3]:54211 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751117AbeAVSMp (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 22 Jan 2018 13:12:45 -0500
Subject: Re: ARM-SMMU: Delete error messages for a failed memory allocation in
 three functions
To: Robin Murphy <robin.murphy@arm.com>, iommu@lists.linux-foundation.org,
        linux-arm-kernel@lists.infradead.org
Cc: =?UTF-8?B?SsO2cmcgUsO2ZGVs?= <joro@8bytes.org>,
        Will Deacon <will.deacon@arm.com>, LKML <linux-kernel@vger.kernel.org>,
        kernel-janitors@vger.kernel.org
References: <c3e91414-dd5b-2889-d86c-b19aff56571b@users.sourceforge.net>
 <ac171b23-624d-2df3-d1d1-8e9479ae03bc@arm.com>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <a714a4ab-8118-e4ef-5982-4395ac2e6c4b@users.sourceforge.net>
Date: Mon, 22 Jan 2018 19:12:07 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <ac171b23-624d-2df3-d1d1-8e9479ae03bc@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:SpRG7pXnBbQK1C8TfPMdPqeHOw8Cm+uGByzv5cv5egefk32JXey
 0v1gfOLhe6Yv7o8RVntT58U2wlSGoOaUd+O4JeGx2hbfOzaGVZ05bi9cKmYnqznl74OluZS
 OLPZJlAcsM9T2TtyciGQs46BcS+geSD1uy2wX6hzzDQmPUQlLJra3fZVen1RV67fA4WL09X
 7jDMdliWEgS6obFn/Gdlw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:SE0hhC9XmRk=:PxyjPb1jhOKqvZ8nLjuJMj
 rDlBkemfMHBCM7Ds4Q6BuG5B/fh6z99eiugUWgAqLv/2USrZwsd3UfJmRjBDLbg0HEanHF4aT
 oLbC8GD7mIZsyMFCosearj9Rvd6K9C0c+qnWvE9XxAyFTutw4xty2QghAiJChuS9w5f1yhRnt
 F1ecschxy2a49cw9W5IEqAghuUPUFDgLDtninK3OkfsAhndHsVtwWFu+Ya6EJ2GsFdanJqwW6
 WjANvTHpmKiGaXvrgFaDWwkIoeRvJ2HgK3Svh2gUGvvdu0e34VPTjNcVbHszuZg4UErv/jLfD
 7gf9qSWBUllbkMuEivmZ+Anvgx2kILKEqmhrUDCEt4Y3nd7HujoY7tFi3+AFs9h03m6HomzZ4
 wsp0emUcJEXRET/E1hvhofQUCwuxS+PstGgb9afAURyCPtWv4D4WDVVhS4Za/CpPeOv7M4CSl
 pzGk8Im4/V+axLdXIiIGtirK0c2Y+cNdNX4fCxuAgCocv+0NXnGtfCH4qjsOAIXgQxo7PlLuQ
 Lj05CnJw1o6Iiho6P4f7XDhzLRdV2aXuVL70WkMKDWDlSI6K9wPaaM6fdFWNn2SNz0xME6rex
 Rw5iBC/vT6wd2byMamFNyoOcLo2uYIEm/qyg9PgBD+hprACIyAsqw0wvQx8zESIB//IBncxSr
 JBfU9l0/1OZSdZruo3j7/t2SNdG5N03X3+0dBqkI8PN+YO6ukln1oxnthHvMbJ68O9z/WRka6
 xGGV4TAlQiEk87+ByIz3EQ2h8KLCMnCPJOsG/rFY/2+bX3fxGEGh8Y2TEUHqDT6HiqVRpdWcX
 1bTjzlqPE0CjQmVEpzDalOnP+Gi4JkqTTQlOlWkx8ZJmTjVDe4=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> Date: Sat, 20 Jan 2018 15:30:17 +0100
>>
>> Omit extra messages for a memory allocation failure in these functions.
> 
> Why?

Do you find the wording “WARNING: Possible unnecessary 'out of memory' message”
(from the script “checkpatch.pl”) more reasonable?


> This may as well be "delete some stuff because I feel like it".

Do you find the Linux allocation failure report insufficient
in this use case?

Regards,
Markus