From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22622C169C4 for ; Tue, 29 Jan 2019 16:39:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DC04B20869 for ; Tue, 29 Jan 2019 16:39:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727848AbfA2QjZ (ORCPT ); Tue, 29 Jan 2019 11:39:25 -0500 Received: from mga18.intel.com ([134.134.136.126]:59314 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726374AbfA2QjZ (ORCPT ); Tue, 29 Jan 2019 11:39:25 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jan 2019 08:39:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,537,1539673200"; d="scan'208";a="112037266" Received: from linux.intel.com ([10.54.29.200]) by orsmga006.jf.intel.com with ESMTP; 29 Jan 2019 08:39:24 -0800 Received: from [10.125.252.22] (abudanko-mobl.ccr.corp.intel.com [10.125.252.22]) by linux.intel.com (Postfix) with ESMTP id ACDC6580550; Tue, 29 Jan 2019 08:39:21 -0800 (PST) Subject: Re: [PATCH v2 0/4] perf: enable compression of record mode trace to save storage space To: Arnaldo Carvalho de Melo Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , Namhyung Kim , Alexander Shishkin , Andi Kleen , linux-kernel References: <20190129104543.GJ4344@kernel.org> <20190129105337.GA17762@kernel.org> <20190129121332.GL4344@kernel.org> From: Alexey Budankov Organization: Intel Corp. Message-ID: Date: Tue, 29 Jan 2019 19:39:17 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190129121332.GL4344@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29.01.2019 15:13, Arnaldo Carvalho de Melo wrote: > Em Tue, Jan 29, 2019 at 02:39:00PM +0300, Alexey Budankov escreveu: >> Hi, >> On 29.01.2019 13:53, Arnaldo Carvalho de Melo wrote: >>> Em Tue, Jan 29, 2019 at 11:45:43AM +0100, Arnaldo Carvalho de Melo escreveu: >>>> Em Mon, Jan 28, 2019 at 09:40:28AM +0300, Alexey Budankov escreveu: >>>>> The patch set implements runtime trace compression for record mode and >>>>> trace file decompression for report mode. Zstandard API [1] is used for >>>>> compression/decompression of data that come from perf_events kernel >>>> >>>> Interesting, wasn't aware of this zstd library, I wonder if we can add >>>> it and switch the other compression libraries we link against, so that >>>> we're not adding one more library to the dep list of perf but removing >>>> some instead, do you think this would be possible? >> >> Replacing of incorporated compression APIs was not evaluated or tested in >> the scope of this patch set work. However according to their numbers in the >> docs and the numbers that we have got during testing Zstd API outperforms >> the exiting compression libraries as in terms of speed as in terms of >> compression ratio (at least libz). Backward compatibility needs to be taken >> into account so that old perf files would open by newer perf tool versions. > > Right, I'm not talking in the scope of this patch, its just that while > looking at it, I notice that we're adding yet another compression > library and its description seemed to imply it would support the other > compression formats, which I've learned its not the case, so nevermind. > > I'm not talking about using just zstd, as what we mostly do with the > compression libraries is to decompress, not compress, for instance, we > need to uncompress kernel modules to get to its symbols, do annotation > with it, etc. Well, yes, having single compression/decompression API implementation that would handle different compression formats and scenarios sounds reasonable from support cost perspective. It looks like Zstandard library could provide such capabilities. The library is well supported at the moment so fixes and extensions are released timely enough. -Alexey > > - Arnaldo > >> -Alexey >> >>>> >>>> $ ldd ~/bin/perf | wc -l >>>> 30 >>>> $ ldd ~/bin/perf | grep z >>>> liblzma.so.5 => /lib64/liblzma.so.5 (0x00007f3dcc356000) >>>> libz.so.1 => /lib64/libz.so.1 (0x00007f3dcb2aa000) >>>> libbz2.so.1 => /lib64/libbz2.so.1 (0x00007f3dcb218000) >>>> $ >>>> >>>> Humm, from the github page it says: >>>> >>>> ----- >>>> The project is provided as an open-source dual BSD and GPLv2 licensed C >>>> library, and a command line utility producing and decoding .zst, .gz, >>>> .xz and .lz4 files. Should your project require another programming >>>> language, a list of known ports and bindings is provided on Zstandard >>>> homepage. >>>> ----- >>>> >>>> So it would cover just liblzma and libz, right? >>> >>> Nevermind; >>> >>> [acme@quaco perf]$ zstdcat ~/git/perf/perf-5.0.0-rc2.tar.xz >>> zstd: /home/acme/git/perf/perf-5.0.0-rc2.tar.xz: xz/lzma file cannot be uncompressed (zstd compiled without HAVE_LZMA) -- ignored >>> >>> So it handles those formats, _if_ linked with those libraries, duh. >>> >>> - Arnaldo >>> >