From: Alex Deucher <alexdeucher@gmail.com>
To: Dave Airlie <airlied@gmail.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
lkml <linux-kernel@vger.kernel.org>,
David Airlie <airlied@linux.ie>
Subject: Re: [PATCH] drm: fix char constant (sparse warning)
Date: Mon, 1 Mar 2010 12:06:31 -0500 [thread overview]
Message-ID: <a728f9f91003010906x6103bee9pe72a28f63f04b984@mail.gmail.com> (raw)
In-Reply-To: <21d7e9971002282201p3f932729nc00a60bc5eadd492@mail.gmail.com>
On Mon, Mar 1, 2010 at 1:01 AM, Dave Airlie <airlied@gmail.com> wrote:
> On Thu, Feb 25, 2010 at 8:27 AM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>
>> Fix radeon/atombios.h sparse warning (24 times):
>>
>> drivers/gpu/drm/radeon/atombios.h:4091:63: error: Bad character constant
>
> We get this file from AMD pretty much as-is and I hate deviating it as it
> causes merge issues. Alex any change you can get this fixed upstream?
>
I can try.
Alex
> Dave.
>
>>
>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>> Cc: David Airlie <airlied@linux.ie>
>> ---
>> drivers/gpu/drm/radeon/atombios.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- linux-2.6.33-rc8.orig/drivers/gpu/drm/radeon/atombios.h
>> +++ linux-2.6.33-rc8/drivers/gpu/drm/radeon/atombios.h
>> @@ -4088,7 +4088,7 @@ typedef struct _SW_I2C_IO_DATA_PARAMETER
>> #define SW_I2C_CNTL_WRITE1BIT 6
>>
>> /* ==============================VESA definition Portion=============================== */
>> -#define VESA_OEM_PRODUCT_REV '01.00'
>> +#define VESA_OEM_PRODUCT_REV "01.00"
>> #define VESA_MODE_ATTRIBUTE_MODE_SUPPORT 0xBB /* refer to VBE spec p.32, no TTY support */
>> #define VESA_MODE_WIN_ATTRIBUTE 7
>> #define VESA_WIN_SIZE 64
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
>>
>
next prev parent reply other threads:[~2010-03-01 17:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-24 22:27 Randy Dunlap
2010-03-01 6:01 ` Dave Airlie
2010-03-01 17:06 ` Alex Deucher [this message]
2010-03-01 17:15 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a728f9f91003010906x6103bee9pe72a28f63f04b984@mail.gmail.com \
--to=alexdeucher@gmail.com \
--cc=airlied@gmail.com \
--cc=airlied@linux.ie \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®