From: Larry Finger <Larry.Finger@lwfinger.net>
To: Colin King <colin.king@canonical.com>,
Ping-Ke Shih <pkshih@realtek.com>,
Kalle Valo <kvalo@codeaurora.org>,
Yan-Hsuan Chuang <yhchuang@realtek.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] rtlwifi: btcoexist: remove redundant variable fw_ps_state
Date: Tue, 9 Jan 2018 10:48:19 -0600 [thread overview]
Message-ID: <a72bbd04-4bf5-7819-bf6e-31092bfa2d51@lwfinger.net> (raw)
In-Reply-To: <20180109164329.15919-1-colin.king@canonical.com>
On 01/09/2018 10:43 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable fw_ps_state is assigned a value but it is never read, hence
> it is redundant and can be removed.
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks,
Larry
>
> Cleans up clang warning:
> drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c:736:2:
> warning: Value stored to 'fw_ps_state' is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
> index 5f3eda31187a..873bf9303d5d 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
> @@ -677,7 +677,7 @@ static void halbtc_display_wifi_status(struct btc_coexist *btcoexist,
> u32 wifi_link_status = 0x0;
> bool bt_hs_on = false, under_ips = false, under_lps = false;
> bool low_power = false, dc_mode = false;
> - u8 wifi_chnl = 0, wifi_hs_chnl = 0, fw_ps_state;
> + u8 wifi_chnl = 0, wifi_hs_chnl = 0;
> u8 ap_num = 0;
>
> wifi_link_status = halbtc_get_wifi_link_status(btcoexist);
> @@ -733,7 +733,6 @@ static void halbtc_display_wifi_status(struct btc_coexist *btcoexist,
> dc_mode = true; /*TODO*/
> under_ips = rtlpriv->psc.inactive_pwrstate == ERFOFF ? 1 : 0;
> under_lps = rtlpriv->psc.dot11_psmode == EACTIVE ? 0 : 1;
> - fw_ps_state = 0;
> low_power = 0; /*TODO*/
> seq_printf(m, "\n %-35s = %s%s%s%s",
> "Power Status",
>
next prev parent reply other threads:[~2018-01-09 16:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 16:43 Colin King
2018-01-09 16:48 ` Larry Finger [this message]
2018-01-16 15:59 ` [next] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a72bbd04-4bf5-7819-bf6e-31092bfa2d51@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®