From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Nicholas Krause <xerofoify@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
keescook@chromium.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging:fwserial:Fix parentheses alignment in fwserial.c
Date: Thu, 30 Aug 2018 05:49:51 -0700 [thread overview]
Message-ID: <a735448b2e7b5b24079a4b6cfc6a3612996484f2.camel@perches.com> (raw)
In-Reply-To: <20180830082808.ylputgri7oit7jvo@mwanda>
On Thu, 2018-08-30 at 11:28 +0300, Dan Carpenter wrote:
> On Wed, Aug 29, 2018 at 06:03:26PM -0400, Nicholas Krause wrote:
> > Fix a checkpatch warning for the file, fwserial.c that warns about
> > alignment between parentheses and the line belows code not being
> > properly aligned with each other.
> >
> > Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
Nick Krause?
I wonder if after 4 years he has improved.
> > diff --git a/drivers/staging/fwserial/fwserial.c b/drivers/staging/fwserial/fwserial.c
[]
> > @@ -1328,7 +1328,7 @@ static int fwtty_break_ctl(struct tty_struct *tty, int state)
> > if (state == -1) {
> > set_bit(STOP_TX, &port->flags);
> > ret = wait_event_interruptible_timeout(port->wait_tx,
> > - !test_bit(IN_TX, &port->flags),
> > + !test_bit(IN_TX, &port->flags),
> > 10);
>
> Now it goes over 80 characters and the "10);" isn't aligned properly.
> The original is fine.
Perhaps not.
prev parent reply other threads:[~2018-08-30 12:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180829220326.7447-1-xerofoify@gmail.com>
2018-08-30 8:28 ` Dan Carpenter
2018-08-30 12:49 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a735448b2e7b5b24079a4b6cfc6a3612996484f2.camel@perches.com \
--to=joe@perches.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®