From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754530AbdJLKvJ (ORCPT ); Thu, 12 Oct 2017 06:51:09 -0400 Received: from mout.web.de ([212.227.15.14]:50691 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751350AbdJLKvF (ORCPT ); Thu, 12 Oct 2017 06:51:05 -0400 Subject: [PATCH 09/10] staging/irda/net: Combine some seq_printf() calls in two functions From: SF Markus Elfring To: devel@driverdev.osuosl.org, netdev@vger.kernel.org, Al Viro , Corentin Labbe , David Howells , "David S. Miller" , Georgiana Chelu , Greg Kroah-Hartman , Johannes Berg , Julia Lawall , Samuel Ortiz , Srishti Sharma , Stephen Hemminger , Yuan Linyu Cc: LKML , kernel-janitors@vger.kernel.org References: <8152401b-d68d-c4fe-2619-82a09e0c52ec@users.sourceforge.net> Message-ID: Date: Thu, 12 Oct 2017 12:49:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <8152401b-d68d-c4fe-2619-82a09e0c52ec@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:ZcbWE8j2GCADOuOBBUO5EWBj7/4rs1AwgB18KJ53OOFXGn9gAtn P0b2txLy1Pgh2VGoYa2ju9VYg2SoSKBbAHRXqUDb9dzUad3sJDiY/LcSg6sve5JZLV3ysIg qNCchn9+8C1fXyEZ7MXjaqp3QECwcybAZMaQa69tHpQozaw1P7eonlWWvDMU5qMXAfZ99BH i26i08q/3Nk6v1TJ99TWA== X-UI-Out-Filterresults: notjunk:1;V01:K0:8gw8zTFjkTQ=:8t+As+z9q2h+mY5uWBfe7Q BKdrD2pZp91gHrvWZfo5LtxomdkqHu+yu4Ipj9l3+lTpfeLkS5NuSA+cliBadVhidr1MZ4+9L HpNE1L/ZxPAnqBKwFG7rWHoestid3r7L/38FClDjiGywlOwv/9UPOODw5S3glgi9Y82Kptuuo Sq5ycll0tQ6u4FG5mDA7UdEj0nemHFif7pQYkBpf/L1ZAPftPSz6dla+oCF/GKnqkun8BNSMF h4BbqCilq5CehkjJCYITdJxt5Y5e5vtwZqAGZb5pGpEJEc+lul44IocGFybYifm52ZVpdXwzT V7DTk7Bl1RSGrGpTz17QNny859kjidgRDiGaQgkrLlMxN+iMkhDQN0UxMagNN63gvi/ke0Z6W b25J6fwaZc4sGG5bnUUWQOaBH9Ue5shRiWKwn+tPKKvhfBJiDYzM5MILmnp7/f+fSgZN9NS6Z fKBjpeyTCLvz4kvKVXujQsT3zYir8+S1v281Z2/nEecmAiIXwzTu3deKUd1V98o8j1TrXSXCl vp/9kQFS93jJPsJiO5GC9DZCAbcVP2WjYvSkWmlkblrj793h2Q3IJbOIHEH9II5QR23IqWGRK xX59B2XFA+KgllBPYfPd4iO/T7+9DCwbpopFR0utoLEbTdZGqCyx5x+sriRVDdrcfa/ja0yF7 MTsaeYhnGWhKKOmtPUSyvZd1SBLIKAnZ30U//4qxBva1Cl0m960yVbrUo86mwGGESlh/nba9y NZsrJxD1pVNhzVZKG7GXkUJPWopAnfFywpJyu2ZW55DifpRfo98XFqQtGTyMe8BeG7Xutabmf AeqELCqJ74zimyDbeU7TK89/JFsMotXdRWGh+ls7ydVg3rIGJc= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 12 Oct 2017 08:58:38 +0200 Some data were printed into a sequence by separate function calls. Print the same data by a single function call at each place instead. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/staging/irda/net/irlap.c | 9 ++++----- drivers/staging/irda/net/irlmp.c | 6 ++---- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/staging/irda/net/irlap.c b/drivers/staging/irda/net/irlap.c index 715cedab2f41..345c4eb55a59 100644 --- a/drivers/staging/irda/net/irlap.c +++ b/drivers/staging/irda/net/irlap.c @@ -1141,9 +1141,9 @@ static int irlap_seq_show(struct seq_file *seq, void *v) seq_printf(seq, "vr: %d ", self->vr); seq_printf(seq, "va: %d\n", self->va); - seq_printf(seq, " qos\tbps\tmaxtt\tdsize\twinsize\taddbofs\tmintt\tldisc\tcomp\n"); - - seq_printf(seq, " tx\t%d\t", + seq_printf(seq, + " qos\tbps\tmaxtt\tdsize\twinsize\taddbofs\tmintt\tldisc\tcomp\n" + " tx\t%d\t", self->qos_tx.baud_rate.value); seq_printf(seq, "%d\t", self->qos_tx.max_turn_time.value); @@ -1157,9 +1157,8 @@ static int irlap_seq_show(struct seq_file *seq, void *v) self->qos_tx.min_turn_time.value); seq_printf(seq, "%d\t", self->qos_tx.link_disc_time.value); - seq_printf(seq, "\n"); - seq_printf(seq, " rx\t%d\t", + seq_printf(seq, "\n rx\t%d\t", self->qos_rx.baud_rate.value); seq_printf(seq, "%d\t", self->qos_rx.max_turn_time.value); diff --git a/drivers/staging/irda/net/irlmp.c b/drivers/staging/irda/net/irlmp.c index 318660fbc094..6a09cf621bd4 100644 --- a/drivers/staging/irda/net/irlmp.c +++ b/drivers/staging/irda/net/irlmp.c @@ -1920,8 +1920,7 @@ static int irlmp_seq_show(struct seq_file *seq, void *v) seq_printf(seq, "slsap_sel: %#02x, dlsap_sel: %#02x, ", self->slsap_sel, self->dlsap_sel); - seq_printf(seq, "(%s)", self->notify.name); - seq_printf(seq, "\n"); + seq_printf(seq, "(%s)\n", self->notify.name); } else if (iter->hashbin == irlmp->links) { struct lap_cb *lap = v; @@ -1930,9 +1929,8 @@ static int irlmp_seq_show(struct seq_file *seq, void *v) seq_printf(seq, "saddr: %#08x, daddr: %#08x, ", lap->saddr, lap->daddr); - seq_printf(seq, "num lsaps: %d", + seq_printf(seq, "num lsaps: %d\n", HASHBIN_GET_SIZE(lap->lsaps)); - seq_printf(seq, "\n"); /* Careful for priority inversions here ! * All other uses of attrib spinlock are independent of -- 2.14.2