From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756015AbdGLJ02 (ORCPT ); Wed, 12 Jul 2017 05:26:28 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:10467 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755634AbdGLJ0W (ORCPT ); Wed, 12 Jul 2017 05:26:22 -0400 X-AuditID: b6c32a2d-f79866d0000012d5-91-5965eb3b23ca Subject: Re: [PATCH v2] ASoC: samsung: i2s: Support more resolution rates To: Jaechul Lee , Krzysztof Kozlowski , Sangbeom Kim , Sylwester Nawrocki , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel Cc: Jaechul Lee , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org From: Hoegeun Kwon Message-id: Date: Wed, 12 Jul 2017 18:26:21 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-version: 1.0 In-reply-to: <20170707013110.7060-1-jcsing.lee@samsung.com> Content-type: text/plain; charset="utf-8"; format="flowed" Content-transfer-encoding: 7bit Content-language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrEJsWRmVeSWpSXmKPExsWy7bCmpq7169RIg9uvDS2uXDzEZDH14RM2 i+MrZzFbvN3fzWxx/vwGdotvVzqYLC7vmsNmMeP8PiaLzl39rBaH37SzWlxc8YXJYsP3tYwO PB4bPjexeeycdZfdY9OqTjaPfW+XsXn0bVnF6LF+y1UWj8+b5ALYo1JtMlITU1KLFFLzkvNT MvPSbZW8g+Od403NDAx1DS0tzJUU8hJzU22VXHwCdN0yc4AuVVIoS8wpBQoFJBYXK+nb2RTl l5akKmTkF5fYKkUbGhrpGRqY6xkZGemZGMdaGZkClSSkZhy8t5yp4LBqxZQDS5kaGNvluhg5 OSQETCQWdXeyQ9hiEhfurWfrYuTiEBJYyiix+MA2VgjnM6PErUl/GLsYOcA6epZKQMR3MEqc 37QHquguo8TRR3PYQEYJC3hKPHn/jR0kISJwk0niybaPjCAJZoF0iWNtH1lAbDYBXYmvPdeZ QGxeATuJSReXMYPYLAKqEkfv3gGrFxWIkNj2fQYbRI2gxI/J91hAruAUsJaY+CQIYqSVxLN/ rawQtrzE5jVvmSFscYnm1pssIDdICNxilziwcgILxAeyEpsOMEO87CLx5OozKFtY4tXxLdCg kJLo7pgFZddLXN5xkhFiTgOjRP/E2VAJY4lTXY1MEMv4JHp/P2GCmM8r0dEmBFHiIXF85xKo tY4Sj5ojIWHVxyhx9eB99gmMCrOQfDYLyTuzkLwzC8k7CxhZVjGKpRYU56anFpsWGOkVJ+YW l+al6yXn525iBKdfLd0djF8WeB9iFOBgVOLhbbiQEinEmlhWXJl7iFGCg1lJhFflZWqkEG9K YmVValF+fFFpTmrxIUZTYMhPZJYSTc4H5oa8knhDE0sDE1MzYwNjQwtLJXFe9ZXXIoQE0hNL UrNTUwtSi2D6mDg4pRoYd2V/ZbD8bDBv/rJOBh2PS6UuRysSHnEIRX0xSZV8y7FJQvPJPr5i 86bQjK/xfVt2BpuvmrI1WvuDVrJHSc2qtZu3icp7yvud9fy9w8NjnTTD/WfRSl2HsvYz7I6U ffNI4mcyJ0felke2J/9/m7T6z0UNll/TZlqZ1LckV5re+Ok9iSX62GY9JZbijERDLeai4kQA mSbsS9UDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrIIsWRmVeSWpSXmKPExsVy+t9jAV3r16mRBvsfKllcuXiIyWLqwyds FsdXzmK2eLu/m9ni/PkN7BbfrnQwWVzeNYfNYsb5fUwWnbv6WS0Ov2lntbi44guTxYbvaxkd eDw2fG5i89g56y67x6ZVnWwe+94uY/Po27KK0WP9lqssHp83yQWwR7nZZKQmpqQWKaTmJeen ZOal2yqFhrjpWigp5CXmptoqRej6hgQpKZQl5pQCeUYGaMDBOcA9WEnfLsEt4+C95UwFh1Ur phxYytTA2C7XxcjBISFgItGzVKKLkRPIFJO4cG89WxcjF4eQwDZGifMTLkI59xkl7v/czQpS JSzgKfHk/Td2kISIwG0miUUPb7OATGIWSJeYM1cZomECo0RT3xN2kAY2AV2Jrz3XmUBsXgE7 iUkXlzGD2CwCqhJH795hBLFFBSIk+t5eZoeoEZT4Mfke2ExOAWuJiU+CQMLMAmYSX14eZoWw 5SU2r3nLDGGLSzS33mSZwCg4C0n3LCQts5C0zELSsoCRZRUjV2pBcW56brFRgdEmRmD0bjus FbCDselc9CFGAQ5GJR5ehp7USCHWxLLiytxDjBIczEoivCovgUK8KYmVValF+fFFpTmpxYcY TYE+msgsJZqcD0wseSXxhiaWRiYGZmaGRgbGZkrivBMCv0QICaQnlqRmp6YWpBbB9DFxcEo1 MPZM21EU/fvi0jWWt8Vj+i4c9XWuWjtZIC5Vw+j/hDVZC3kW72acenuja7/Hl82/ixnOyh6J 28/CYe4SZPJ4kvX7a7YHZ/1I4P/qyJC7WThitTpztdeuhlk3+gI4mH1ed7umcx+NnKmv8urQ Q/fgII9VUezqJvEHRWwl7PU4bTxuZehcMkwXV2Ipzkg01GIuKk4EAIzsExb0AgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170712092619epcas5p101d7198102a712a6da43f8a357b875e5 X-Msg-Generator: CA X-Sender-IP: 182.195.42.80 X-Local-Sender: =?UTF-8?B?6raM7ZqM6re8G1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbRW5naW5lZXI=?= X-Global-Sender: =?UTF-8?B?SG9lZ2V1biBLd29uG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1RFTEUbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20170707013112epcas5p43273c95afd43b18ded971bea081edd40 X-RootMTR: 20170707013112epcas5p43273c95afd43b18ded971bea081edd40 References: <20170707013110.7060-1-jcsing.lee@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jaechul, On 07/07/2017 10:31 AM, Jaechul Lee wrote: > This driver can support more frequencies over 96KHz. There are no reasons > to limit the frequency range below 96KHz. If codecs/amps or something else > can't support higher resolution rates, the constraints would be set rates > properly because each drivers have its own limits. > > I added the 'pcm_rates' field to the dai_data to be set rates by the > compatibilities. As a result, rates will be set each devices respectively. > For example of exynos5433, rates will be set from 8KHz to 192KHz. > > Signed-off-by: Jaechul Lee Reviewed-by: Hoegeun Kwon Best regards, Hoegeun > --- > v2: > - changed the name of variable to pcm_rates. > - removed duplicated code. > - modified commit message. > --- > sound/soc/samsung/i2s.c | 20 +++++++++++++------- > 1 file changed, 13 insertions(+), 7 deletions(-) > > diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c > index af3ba4d4ccc5..c9f87f7bae99 100644 > --- a/sound/soc/samsung/i2s.c > +++ b/sound/soc/samsung/i2s.c > @@ -50,6 +50,7 @@ struct samsung_i2s_variant_regs { > > struct samsung_i2s_dai_data { > u32 quirks; > + unsigned int pcm_rates; > const struct samsung_i2s_variant_regs *i2s_variant_regs; > }; > > @@ -1076,13 +1077,13 @@ static const struct snd_soc_component_driver samsung_i2s_component = { > .name = "samsung-i2s", > }; > > -#define SAMSUNG_I2S_RATES SNDRV_PCM_RATE_8000_96000 > - > #define SAMSUNG_I2S_FMTS (SNDRV_PCM_FMTBIT_S8 | \ > SNDRV_PCM_FMTBIT_S16_LE | \ > SNDRV_PCM_FMTBIT_S24_LE) > > -static struct i2s_dai *i2s_alloc_dai(struct platform_device *pdev, bool sec) > +static struct i2s_dai *i2s_alloc_dai(struct platform_device *pdev, > + const struct samsung_i2s_dai_data *i2s_dai_data, > + bool sec) > { > struct i2s_dai *i2s; > > @@ -1101,13 +1102,13 @@ static struct i2s_dai *i2s_alloc_dai(struct platform_device *pdev, bool sec) > i2s->i2s_dai_drv.resume = i2s_resume; > i2s->i2s_dai_drv.playback.channels_min = 1; > i2s->i2s_dai_drv.playback.channels_max = 2; > - i2s->i2s_dai_drv.playback.rates = SAMSUNG_I2S_RATES; > + i2s->i2s_dai_drv.playback.rates = i2s_dai_data->pcm_rates; > i2s->i2s_dai_drv.playback.formats = SAMSUNG_I2S_FMTS; > > if (!sec) { > i2s->i2s_dai_drv.capture.channels_min = 1; > i2s->i2s_dai_drv.capture.channels_max = 2; > - i2s->i2s_dai_drv.capture.rates = SAMSUNG_I2S_RATES; > + i2s->i2s_dai_drv.capture.rates = i2s_dai_data->pcm_rates; > i2s->i2s_dai_drv.capture.formats = SAMSUNG_I2S_FMTS; > } > return i2s; > @@ -1242,7 +1243,7 @@ static int samsung_i2s_probe(struct platform_device *pdev) > i2s_dai_data = (struct samsung_i2s_dai_data *) > platform_get_device_id(pdev)->driver_data; > > - pri_dai = i2s_alloc_dai(pdev, false); > + pri_dai = i2s_alloc_dai(pdev, i2s_dai_data, false); > if (!pri_dai) { > dev_err(&pdev->dev, "Unable to alloc I2S_pri\n"); > return -ENOMEM; > @@ -1316,7 +1317,7 @@ static int samsung_i2s_probe(struct platform_device *pdev) > goto err_disable_clk; > > if (quirks & QUIRK_SEC_DAI) { > - sec_dai = i2s_alloc_dai(pdev, true); > + sec_dai = i2s_alloc_dai(pdev, i2s_dai_data, true); > if (!sec_dai) { > dev_err(&pdev->dev, "Unable to alloc I2S_sec\n"); > ret = -ENOMEM; > @@ -1452,29 +1453,34 @@ static const struct samsung_i2s_variant_regs i2sv5_i2s1_regs = { > > static const struct samsung_i2s_dai_data i2sv3_dai_type = { > .quirks = QUIRK_NO_MUXPSR, > + .pcm_rates = SNDRV_PCM_RATE_8000_96000, > .i2s_variant_regs = &i2sv3_regs, > }; > > static const struct samsung_i2s_dai_data i2sv5_dai_type = { > .quirks = QUIRK_PRI_6CHAN | QUIRK_SEC_DAI | QUIRK_NEED_RSTCLR | > QUIRK_SUPPORTS_IDMA, > + .pcm_rates = SNDRV_PCM_RATE_8000_96000, > .i2s_variant_regs = &i2sv3_regs, > }; > > static const struct samsung_i2s_dai_data i2sv6_dai_type = { > .quirks = QUIRK_PRI_6CHAN | QUIRK_SEC_DAI | QUIRK_NEED_RSTCLR | > QUIRK_SUPPORTS_TDM | QUIRK_SUPPORTS_IDMA, > + .pcm_rates = SNDRV_PCM_RATE_8000_96000, > .i2s_variant_regs = &i2sv6_regs, > }; > > static const struct samsung_i2s_dai_data i2sv7_dai_type = { > .quirks = QUIRK_PRI_6CHAN | QUIRK_SEC_DAI | QUIRK_NEED_RSTCLR | > QUIRK_SUPPORTS_TDM, > + .pcm_rates = SNDRV_PCM_RATE_8000_192000, > .i2s_variant_regs = &i2sv7_regs, > }; > > static const struct samsung_i2s_dai_data i2sv5_dai_type_i2s1 = { > .quirks = QUIRK_PRI_6CHAN | QUIRK_NEED_RSTCLR, > + .pcm_rates = SNDRV_PCM_RATE_8000_96000, > .i2s_variant_regs = &i2sv5_i2s1_regs, > }; >