From: Yang Jihong <yangjihong1@huawei.com>
To: Adrian Hunter <adrian.hunter@intel.com>, <peterz@infradead.org>,
<mingo@redhat.com>, <acme@kernel.org>, <mark.rutland@arm.com>,
<alexander.shishkin@linux.intel.com>, <jolsa@kernel.org>,
<namhyung@kernel.org>, <irogers@google.com>,
<kan.liang@linux.intel.com>, <linux-kernel@vger.kernel.org>,
<linux-perf-users@vger.kernel.org>
Subject: Re: [PATCH 1/5] perf evlist: Export perf_evlist__propagate_maps()
Date: Wed, 12 Jul 2023 22:30:36 +0800 [thread overview]
Message-ID: <a7480404-c6ad-8892-b9d2-d2458c2e686b@huawei.com> (raw)
In-Reply-To: <180925f8-57f3-c97a-15c4-db2c73abe4a2@intel.com>
Hello,
On 2023/7/11 21:12, Adrian Hunter wrote:
> On 4/07/23 10:42, Yang Jihong wrote:
>> For dummy events that keep tracking, we may need to modify its cpu_maps.
>> For example, change the cpu_maps to track side-band events for all CPUS.
>> Export perf_evlist__propagate_maps () to support this scenario.
>
> __perf_evlist__propagate_maps() is quite low-level so it would be better
> to avoid exporting it.
>
>
Or can we export it via internal/evlist.h?
Because as mentioned in patch 2:
void perf_evsel__go_system_wide(struct perf_evlist *evlist, struct
perf_evsel *evsel)
{
if (!evsel->system_wide) {
evsel->system_wide = true;
if (evlist->needs_map_propagation)
__perf_evlist__propagate_maps(evlist, evsel);
}
}
This interface needs to invoke __perf_evlist__propagate_maps.
Thanks,
Yang
next prev parent reply other threads:[~2023-07-12 14:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 7:42 [PATCH 0/5] perf record: Tracking side-band events for all CPUs when tracing selected CPUs Yang Jihong
2023-07-04 7:42 ` [PATCH 1/5] perf evlist: Export perf_evlist__propagate_maps() Yang Jihong
2023-07-11 13:12 ` Adrian Hunter
2023-07-12 14:30 ` Yang Jihong [this message]
2023-07-12 15:01 ` Adrian Hunter
2023-07-04 7:42 ` [PATCH 2/5] perf evlist: Add evlist__findnew_tracking_event() helper Yang Jihong
2023-07-11 13:13 ` Adrian Hunter
2023-07-12 14:32 ` Yang Jihong
2023-07-04 7:42 ` [PATCH 3/5] perf record: Tracking side-band events for all CPUs when tracing selected CPUs Yang Jihong
2023-07-05 21:09 ` Namhyung Kim
2023-07-06 1:39 ` Yang Jihong
2023-07-11 13:13 ` Adrian Hunter
2023-07-12 14:44 ` Yang Jihong
2023-07-12 15:03 ` Adrian Hunter
2023-07-04 7:42 ` [PATCH 4/5] perf test: Add test case for record tracking Yang Jihong
2023-07-12 20:48 ` Ian Rogers
2023-07-13 6:59 ` Yang Jihong
2023-07-04 7:42 ` [PATCH 5/5] perf record: All config tracking are integrated into record__config_tracking_events() Yang Jihong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7480404-c6ad-8892-b9d2-d2458c2e686b@huawei.com \
--to=yangjihong1@huawei.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®