From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BFE346A5EA for ; Thu, 23 Jul 2026 11:05:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784804758; cv=none; b=ot9ovo7kD4eabqLvLRxzbdWFvmqAQbosoxtaWB0BwGT6GWw/hWDXJXfcRUGP01xlaBVx1A3QEB+SqBuicKpXtdPDvNrRKZJR2EriynKF8r+xG0yDaRO9GcjrDcf/xE1fbnP0uaOs5rzKYh+wBHx1sORl+RsyUcL/VNL1sVBmyFE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784804758; c=relaxed/simple; bh=OwAplwYTX5ghT4fVWFOYK6ieCMrlo2iy84oCUwHIfV8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DS8ttBbHRk1wW6WBe/WebgK5NW/eaObS5aqiG5DVNeeFtXllvagjjgYqJfP+Yc34BIgrWqaq09ks7SAwZV8kp4hKPDUiTT2s2GLZ+GyuWRUsrcsNOHwr/xL8PXZVml5q4DK6n1Lgh+HS+B4k/OLWqCEUWFPwHWk3Ma9g+pEWhtk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kDZ7137a; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DANC7Rnk; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kDZ7137a"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DANC7Rnk" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66N8qYUt467250 for ; Thu, 23 Jul 2026 11:05:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ueSh5+HGwHbPbXpRSulOx2jS5R2Ly4UekPjsWs7pRu4=; b=kDZ7137aqIjFufY6 As8biE4hcI3SJYYhauVreTM58yun7NdYTTkf9v5iD7O+nmxuNEq/CrtomkPRnDOL /xCmW9O6nX6lY5AWbgb3rB5VHQyCnaX9m4CE7ipXEniCZcJKePYBtZeqYaXovSpc WT4tsPE1x02LI1CLYwgpVhv6lrhD2wonV4rdzNuQkPecuOG77hS+0Ckr6L+OgO1I ovhljoe4l57OsRTlxtpsEehQWHFPLiDXmigBPNqL445PFhc1Vobj09/xOyksgM4a V15lu2m/7OQhmux/jwOOqPrPE7ZCV+gXvZhJN6u6t0j2Osnj/DiBEy6w71HIUZK9 kD2QGA== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fk28xuptc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Jul 2026 11:05:56 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-92e5e21552dso12761085a.0 for ; Thu, 23 Jul 2026 04:05:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784804756; x=1785409556; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ueSh5+HGwHbPbXpRSulOx2jS5R2Ly4UekPjsWs7pRu4=; b=DANC7RnkhBqxSMTsU49PIiydJpmg/zTZqdry+v30mGtqu299/uvPWMg3bFmZBQmPA+ 6DWtqvrgpKFYSzIw3CEIXgPwVSA2TYOq+D0xwGk8A4hVzaTya7KukbPk+GsugKmQzOPq lkaC0NCZel4dvOlkLkUJ4wP0Pib4oLfAuAbqafjtcgJ+F2GYSazP/zY+KgCVrMUNkhZt 5h8Tfn1/UU15XaPOHQoIzvj7+lsOf1IyC7SfpmNDYP9NkBTfYnMunpC1BNACy6fa3sBk 0h69VNfDRa2EHvu+HScXfT0UqdEuhjnvnc2wgqS3b+aPYn+VPIzlo+H5PGeuqdUyxA4o Juig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784804756; x=1785409556; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ueSh5+HGwHbPbXpRSulOx2jS5R2Ly4UekPjsWs7pRu4=; b=hBU1WYIndeHSimk+1uBt/KrVGRen03HsmmnDp00kbhXTn1R7N2+VM5GwcJ+bqO6umE R/SLm1aBbtUKaXPgNC5qxnWNVWwwITNo6vefb+X0XF+pJ4EG/9EoKuFFsuFbYwdz6pJM sMQSCxldi1AkqThbrrHulrvq9tn3gq+XHflKss2bC5BFmxv/jz6w+q5XD4A80+iEzMj8 L/Tpg771DEWUxruunLUhoPM3VBgkee0DYf53GOQucqHghd+ySe0VaFTQ3y6KUvlm4YiV wH06Dl9HU8n1o203SapbcAu8XLYPA8o6BJbtsOTSx104W4HcC6Kaoqy2nykl+JTySycT fnVQ== X-Forwarded-Encrypted: i=1; AHgh+RooPcnqGk+IV7/+vzuWORj4OW+0WxKrtO9aQC0x9ckJ8Scck68ZIqq/7COfw96gAkOe6H0NiAC1HO3GQSI=@vger.kernel.org X-Gm-Message-State: AOJu0Yxt168Yp4X5nuYHgb5PjMntVPaqUhHo5v9FZSq9YR50zUykpvew EymSxu+AtDGrYPZv8keuIXvrrJ3uLUFHmmIilqADmRvSI1Am2c0Jh8vUvjsJHt/+gunbTWwyS47 IAi2tUZrRKIGl6xT0ArKwYuGNihHYX/kGqOqR3w+w+utthNzFAiX8o5+1G7NDkGJJ22Q= X-Gm-Gg: AR+sD11A0Qqte2b+tO+hQY0ceaMY5Ld3ynKgPj6564Mv+aPeQsytGOrz20Zw/Ah08AL s5EJxCMWHXWTnBIu9Pflo+/RGxbBnSUkH1xj7a1aaJ9JPUkK0DVMz6DuCS6d+XIRlfKqQ+q6G4U HgFhQaXyhlJtinSJC38d9vysu0blNta0zoA9+3cJClAFN7DJ86tjITfrTr0aVe9AVGBpKQTdJ7D oYyf6Vh5vtRB1cBMvyi3Jg8Niz7uVWOuejKADA3K7gx9c26zLd6nF+aXFUCdUFwSzpEqG6eyhEY 1XJP1DvQOUw8jCMIM6pmeJyvSuEdBn7cir+VJkmXbK7zWRocLALPp0inYGmKZeL/Y24tMbzduvX WIuwnoye26rw5AOCHdmC/pOwm X-Received: by 2002:a05:620a:a295:b0:90d:11b2:80f3 with SMTP id af79cd13be357-931251e0e82mr10010885a.7.1784804755896; Thu, 23 Jul 2026 04:05:55 -0700 (PDT) X-Received: by 2002:a05:620a:a295:b0:90d:11b2:80f3 with SMTP id af79cd13be357-931251e0e82mr10007885a.7.1784804755391; Thu, 23 Jul 2026 04:05:55 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-69f34b88069sm1999013a12.7.2026.07.23.04.05.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jul 2026 04:05:54 -0700 (PDT) Message-ID: Date: Thu, 23 Jul 2026 13:05:51 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] arm64: dts: qcom: hamoa-iot-evk: Describe the PCIe M.2 Key E connector To: Wei Deng , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Bartosz Golaszewski , Chen-Yu Tsai , quic_chezhou@quicinc.com, cheng.jiang@oss.qualcomm.com, shuai.zhang@oss.qualcomm.com, jinwang.li@oss.qualcomm.com, xiuzhuo.shang@oss.qualcomm.com, mengshi.wu@oss.qualcomm.com References: <20260723-hamoa-m2-dts-v2-v2-0-82254ac101fb@oss.qualcomm.com> <20260723-hamoa-m2-dts-v2-v2-3-82254ac101fb@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260723-hamoa-m2-dts-v2-v2-3-82254ac101fb@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: o8qdlLUeDiUGAn_GX2_3Xr6nUn3t_lXl X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIzMDEwOCBTYWx0ZWRfXzpWVMs2Y02Ts kefmcolSVaA5MGc/RiHEZrW+fu/S+9Cn/4Ge/9Kx5SLBzFIxZDyk8XNl8H1Pfs/09eH2hAGRpsg P84hwPEW4jRy8jPwRrGLPhbVfWJToUU= X-Proofpoint-GUID: o8qdlLUeDiUGAn_GX2_3Xr6nUn3t_lXl X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIzMDEwOCBTYWx0ZWRfXxHb9stinbqcD 5EXXozReaNKbmm1/wwVZOIZPLsLKPzfuVR7JimjN4za+lSuC1aKI//x2VhSXz2klRXBPBMcybHt nZEm0MxDB+nRlzfx0JHZ7T/MIEKiy/wuM2KkagFmYp9wDH5+g7mVJSv/VwFLgRmXW6mNW4orgJD O0rZVWu+Aeo5yJTZtTx5+eWNaHrLbAlc91kT+eYF7iJ4hEXc7U//RTsza4mBczJbYVaOlTYPwmi GGfbWCHcH/IMPU1n2zrmaZEK5OpmbmeBTCgqX1YxKRG0DQI40SBoboro9ZfftFe+035xjPrqvhR nb4j58nak8pV69STFls/fbb7Gmuiqx7keVoA1FRl6rtwu+5XWKpjwatyOLyr9qLYCC4lvTFoZ6a VivjajxSjnTB06IA4l+5SbOS149vlYIjBZQQ/80VB98AoaJ3YYpR7pajS5ygaZDVvAadue9WkYX sYHi2lyVOHhpWCYs6Sw== X-Authority-Analysis: v=2.4 cv=WNxPmHsR c=1 sm=1 tr=0 ts=6a61f594 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=6WoBsH-PcZNXEBUzj7sA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-23_03,2026-07-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 bulkscore=0 priorityscore=1501 malwarescore=0 phishscore=0 impostorscore=0 suspectscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607230108 On 7/23/26 11:56 AM, Wei Deng wrote: > The Hamoa IoT EVK has a PCIe M.2 Mechanical Key E connector for wireless > connectivity cards exposing Wi-Fi over PCIe and Bluetooth over either > UART or USB, depending on the card variant. [...] > + wifi-bt-connector { > + compatible = "pcie-m2-e-connector"; > + vpcie3v3-supply = <&vreg_wcn_3p3>; > + > + w-disable1-gpios = <&tlmm 117 GPIO_ACTIVE_LOW>; > + w-disable2-gpios = <&tlmm 116 GPIO_ACTIVE_LOW>; > + > + pinctrl-0 = <&wcn_wlan_en>, <&wcn_bt_en>; > + pinctrl-names = "default"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + /* PCIe for Wi-Fi */ Similarly, this is both defined by bindings and made obvious by the label you assign to the endpoint [...] > +&usb_2 { > + ports { > + port@1 { That's why we should use labels and references instead of nested nodes - you defined a port different to the one in patch 1. I feel like we should probably define the uart endpoints in the SoC DTSI as well. Konrad