From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD4414189DD for ; Mon, 20 Jul 2026 12:38:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784551137; cv=none; b=ncP9ycVXuxKOBaVBRjVVfDBg9Zh7mdwTzRd5KfFy/Vnw9XhitjHH9r0lF5qPV3EFdvyj2x0gXoj6OhXqGZnP2Vvwp9E245ROmrPC3WPpx9EVeqlgtHn6dPtObyTZnoM3lqk4/Yr8KtpX2COyrMANRiSaFMsr5bKdm/BB/bcPc1s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784551137; c=relaxed/simple; bh=5U6z050uX86COdaubSy8AogU0C97yoVxGQVLhxaoC3w=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=YFePTsw3b/HiwNA3Xt789ZFe/C8weJ9d03uHdqviopRpuP/PfQ45M6HMKCkImqHpwMn2LfckhrH1gTmMz560wB0MBypGHowyll5IDJ1vCjrUwZHXBGiMSsflEnDBxRTw4SAZZfUhMUn6ALLqdLSQLA76YlGsBK0NrVJhmQS0gOM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=kid5/2Iy; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kid5/2Iy" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4954afac04bso25778895e9.0 for ; Mon, 20 Jul 2026 05:38:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1784551134; x=1785155934; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:organization :autocrypt:content-language:references:cc:to:subject:reply-to:from :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to:content-type; bh=E6KBtb/Bb0z4jnxcgcZfuIhxmNTLNaOmSJg4VYdhfw4=; b=kid5/2IyisTimHZQpAEPwQ6bkmDLDZdGb4HYPukNKd8mjlPToMSYS5FQ36RVfN0T/s YMqYh2ePr+F+6+f92LEYtZkOgqHxBldaz6ncilxtXOls2T2x68tFxOrX73/71VpKfQ2o AgV6M+oE8bc+aGyxKHNmGhIr1zyBby8QllrxLKXRr/03AkwR4ubPHrU7cb3g4cp+81Ar OcqdCAKKlU+5O/kLdAXIFg/WRX3Pid7ljdEZc0tblrGEN2x++U5KjJ6OS+B4rxN6vZw9 ie0dtGvtfxkvwJUkJ17i7Tsw1+oYhhzLXSKZ/de8qWp6OXTCEjYv20z81j5vznwEM8aP 18EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784551134; x=1785155934; h=content-transfer-encoding:content-type:in-reply-to:organization :autocrypt:content-language:references:cc:to:subject:reply-to:from :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to:content-type; bh=E6KBtb/Bb0z4jnxcgcZfuIhxmNTLNaOmSJg4VYdhfw4=; b=J1IUZ9NwrcnRZJNi/Ro1P3WO4g9iivUaImfUJti5o/NY3E2XHJ5C0kDZy9HPZU8LJ8 rv+yIO1WRnnqocRUCyBvJN6rasKgHMi37OeFrdSMbqhQqN7522XmdJE9lAHOrt7/f7W0 juTjltbbYaq6njLr8FTwQhVgk4idEhKAIaIaELJP0GcMHR6KXF/6S4evqcTNajiT1Lpb ubsh4XJ1jCbjeRxi6i+M7hxgMsBKhTzZpKJHlx/DAfU/uQZTSiH6iiFEl6dtNpH14eKE qMPtc6pq8R2sakrAybW4TvI/anMc93zIGUwfVjqOTnFvA06lL4zzIpKqpsRNt569T12d rkUw== X-Forwarded-Encrypted: i=1; AHgh+RoZwaMmm5k2QUYq6mvohyM7uvFFZmUByWFWEYcwIGhK/kwUns5hU90OiovC9P3UplLi7Na57WNeUE3cV1A=@vger.kernel.org X-Gm-Message-State: AOJu0YzZOxjD9phuQVXs1XQ6efZGFHR9EvATcYEPf2rvUYYKkXqPMpns uOMF2aXE4DKKT5N6jQYSnVuP5DsJRCrGAuUmRaEP9p9g9QfTbftRV+zzftoh6eSnLq8= X-Gm-Gg: AfdE7cnDrE6xmONCRmyvdCaSZP33y0h1Hsb15r8WcLAXU1GPDc2WxGa18xaHIYJG7i5 q647sTk4Bw8g6YGVaOhbAWu9vKI2KT4FUshnr0UYjpRV/0wUtLuMaxBAYRCAneWYedbj0SSVw4k GOBQDw7G9Z/BHXQ/3clj7gGPx/DYTtQqXbjeeSCu7WEpfCUobcRUKSlgoCbI7icoSijIREtKvG3 BYhE5nH3hZ+bcxMypyP5+nwigR+N7mMnFEMEIiSYfXT/QaHJKykEt+6FcxRID15a0AN+u6AiWXQ iDNClnbt3/c3Cpeapk/fc4MxVjPP2rGg8z3bqB8U3pw52uXX6IAW49rO/6YVu7wc45knZFU3WCo dYlDTLWLPGmEFj1m7paJrmLi8mQ7UopzWbA8aHaOkNy723vUWHvAnA2EOQAWm0baUDSOAFi1Uui QQJ5BOqt8im0Okw4+RRF2q4f5YBJUOHI6aWQ1j92A5LW/+2wmF90YpxDTgVA== X-Received: by 2002:a05:600c:5297:b0:495:6485:226b with SMTP id 5b1f17b1804b1-49564852284mr880375e9.22.1784551133799; Mon, 20 Jul 2026 05:38:53 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:544a:2852:f257:ebc5? ([2a01:e0a:106d:1080:544a:2852:f257:ebc5]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4955dfa4a97sm109669725e9.4.2026.07.20.05.38.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jul 2026 05:38:53 -0700 (PDT) Message-ID: Date: Mon, 20 Jul 2026 14:38:52 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Reply-To: Neil Armstrong Subject: Re: [PATCH v2 1/3] drm/panel: ilitek-ili9805: Use _multi variants To: Michail Tatas , michael@amarulasolutions.com, jesszhan0024@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dianders@chromium.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260719190358.438699-1-michail.tatas@gmail.com> <20260719190358.438699-2-michail.tatas@gmail.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260719190358.438699-2-michail.tatas@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/19/26 21:03, Michail Tatas wrote: > Convert functions mipi_dsi_* to mipi_dsi_*_multi as per the > gpu/todo file. > The multi variant of these functions include improved error > handling. > > Signed-off-by: Michail Tatas > --- > drivers/gpu/drm/panel/panel-ilitek-ili9805.c | 51 +++++--------------- > 1 file changed, 13 insertions(+), 38 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9805.c b/drivers/gpu/drm/panel/panel-ilitek-ili9805.c > index e6c483851f1f..7e9587afebbe 100644 > --- a/drivers/gpu/drm/panel/panel-ilitek-ili9805.c > +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9805.c > @@ -159,36 +159,23 @@ static int ili9805_power_off(struct ili9805 *ctx) > > static int ili9805_activate(struct ili9805 *ctx) > { > - struct mipi_dsi_device *dsi = ctx->dsi; > - struct device *dev = &dsi->dev; > - int i, ret; > + struct mipi_dsi_multi_context dsi_ctx = { .dsi = ctx->dsi }; > + int i; > > for (i = 0; i < ctx->desc->init_length; i++) { > const struct ili9805_instr *instr = &ctx->desc->init[i]; > > - ret = mipi_dsi_dcs_write_buffer(ctx->dsi, instr->data, instr->len); > - if (ret < 0) > - return ret; > + mipi_dsi_dcs_write_buffer_multi(&dsi_ctx, instr->data, instr->len); > > if (instr->delay > 0) > - msleep(instr->delay); > - } > - > - ret = mipi_dsi_dcs_exit_sleep_mode(ctx->dsi); > - if (ret) { > - dev_err(dev, "Failed to exit sleep mode (%d)\n", ret); > - return ret; > + mipi_dsi_msleep(&dsi_ctx, instr->delay); > } > > - usleep_range(5000, 6000); > + mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx); > + mipi_dsi_usleep_range(&dsi_ctx, 5000, 6000); > + mipi_dsi_dcs_set_display_on_multi(&dsi_ctx); > > - ret = mipi_dsi_dcs_set_display_on(ctx->dsi); > - if (ret) { > - dev_err(dev, "Failed to set display ON (%d)\n", ret); > - return ret; > - } > - > - return 0; > + return dsi_ctx.accum_err; > } > > static int ili9805_prepare(struct drm_panel *panel) > @@ -211,25 +198,13 @@ static int ili9805_prepare(struct drm_panel *panel) > > static int ili9805_deactivate(struct ili9805 *ctx) > { > - struct mipi_dsi_device *dsi = ctx->dsi; > - struct device *dev = &dsi->dev; > - int ret; > - > - ret = mipi_dsi_dcs_set_display_off(ctx->dsi); > - if (ret < 0) { > - dev_err(dev, "Failed to set display OFF (%d)\n", ret); > - return ret; > - } > + struct mipi_dsi_multi_context dsi_ctx = { .dsi = ctx->dsi }; > > - usleep_range(5000, 10000); > - > - ret = mipi_dsi_dcs_enter_sleep_mode(ctx->dsi); > - if (ret < 0) { > - dev_err(dev, "Failed to enter sleep mode (%d)\n", ret); > - return ret; > - } > + mipi_dsi_dcs_set_display_off_multi(&dsi_ctx); > + mipi_dsi_usleep_range(&dsi_ctx, 5000, 10000); > + mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx); > > - return 0; > + return dsi_ctx.accum_err; > } > > static int ili9805_unprepare(struct drm_panel *panel) Reviewed-by: Neil Armstrong Thanks, Neil