mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "chengjian (D)" <cj.chengjian@huawei.com>
To: Namhyung Kim <namhyung@kernel.org>,
	Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: <peterz@infradead.org>, <mingo@redhat.com>,
	<alexander.shishkin@linux.intel.com>,
	<linux-kernel@vger.kernel.org>,
	<linux-perf-users@vger.kernel.org>, <xiexiuqi@huawei.com>,
	<huawei.libin@huawei.com>, <zhangmengting@huawei.com>,
	<kernel-team@lge.com>
Subject: Re: [PATCH] perf/tools : remove default system_wide in sched record
Date: Wed, 25 Oct 2017 19:03:17 +0800	[thread overview]
Message-ID: <a7537e22-9ef3-9dd2-79b3-305e93f84e64@huawei.com> (raw)
In-Reply-To: <20171025022326.GD12785@sejong>



On 2017/10/25 10:23, Namhyung Kim wrote:
> On Tue, Oct 24, 2017 at 10:46:44AM -0300, Arnaldo Carvalho de Melo wrote:
>> Em Tue, Oct 24, 2017 at 03:45:34PM +0800, Cheng Jian escreveu:
>>> When running perf sched record, there is a bug.
>>>
>>> It's system_wide when we specify a command line.
>> Humm, isn't this because if you trace just a workload you will miss the
>> sched-in events?
>>
>> Perhaps with PERF_RECORD_SWITCH we can solve that... I.e. still get the
>> sched-in events while tracing just one workload, not requiring
>> system_wide like it is the case now, right?
> Yes, but it will lose other task's comm, also (at least) sched-wakeup
> (from other task) events are still needed.
>
> Thanks,
> Namhyung
>

I found that if the parameters -p and -a were specified at the same time,
PID/TID(-p/-t) would overwrite SYSTEM_WIDE (-a) in target__validate( ).

If we don't specify a process(-p) or a workload, it will make system 
wide (-a)
as the default target.

     /* Make system wide (-a) the default target. */
     if (!argc && target__none(&rec->opts.target))
         rec->opts.target.system_wide = true;

So don't -a and -p should have the same operation and feedback?

It also lose some events when use -p.

      reply	other threads:[~2017-10-25 11:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-24  7:45 Cheng Jian
2017-10-24 13:46 ` Arnaldo Carvalho de Melo
2017-10-25  2:23   ` Namhyung Kim
2017-10-25 11:03     ` chengjian (D) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a7537e22-9ef3-9dd2-79b3-305e93f84e64@huawei.com \
    --to=cj.chengjian@huawei.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=huawei.libin@huawei.com \
    --cc=kernel-team@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=xiexiuqi@huawei.com \
    --cc=zhangmengting@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®