From: Damien Le Moal <dlemoal@kernel.org>
To: Li Wang <liwang@redhat.com>,
linux-kernel@vger.kernel.org, ltp@lists.linux.it
Cc: Jan Stancek <jstancek@redhat.com>,
John Garry <john.g.garry@oracle.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [PATCH] loop: Increase bsize variable from unsigned short to unsigned int
Date: Tue, 27 Aug 2024 13:10:06 +0900 [thread overview]
Message-ID: <a7585769-5e2d-4ecd-8dd4-2f8f04243c05@kernel.org> (raw)
In-Reply-To: <20240827032218.34744-1-liwang@redhat.com>
On 8/27/24 12:22, Li Wang wrote:
> This change allows the loopback driver to handle larger block sizes
> and increases the consistency of data types used within the driver.
> Especially to mactch the struct queue_limits.logical_block_size type.
>
> Also, this is to get rid of the LTP/ioctl_loop06 test failure:
>
> 12 ioctl_loop06.c:76: TINFO: Using LOOP_SET_BLOCK_SIZE with arg > PAGE_SIZE
> 13 ioctl_loop06.c:59: TFAIL: Set block size succeed unexpectedly
> ...
> 18 ioctl_loop06.c:76: TINFO: Using LOOP_CONFIGURE with block_size > PAGE_SIZE
> 19 ioctl_loop06.c:59: TFAIL: Set block size succeed unexpectedly
>
> Link: https://lists.linux.it/pipermail/ltp/2024-August/039912.html
> Signed-off-by: Li Wang <liwang@redhat.com>
> Cc: Jan Stancek <jstancek@redhat.com>
> Cc: John Garry <john.g.garry@oracle.com>
> Cc: Damien Le Moal <dlemoal@kernel.org>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
Looks OK to me.
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2024-08-27 4:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 3:22 Li Wang
2024-08-27 4:10 ` Damien Le Moal [this message]
2024-08-27 5:18 ` Jan Stancek
2024-08-27 7:19 ` John Garry
2024-08-27 7:35 ` Li Wang
2024-08-27 7:42 ` John Garry
2024-08-27 8:02 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7585769-5e2d-4ecd-8dd4-2f8f04243c05@kernel.org \
--to=dlemoal@kernel.org \
--cc=john.g.garry@oracle.com \
--cc=jstancek@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®