From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65687396D2C for ; Tue, 3 Feb 2026 09:44:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770111895; cv=none; b=ucJFcOeLfu2opQY3luDvMIwhyRhP4f13pr3zMTWt8Aepf2N8EAKux3OF51Eou8TGBUskADL6d+2dt8MAD3CVmAil+6Pbyj5Ve2IFDmBuxO5rnCMD8nfIsnroP5TwQJZPBAxMY0rJoo8mtIRpJuXSpx8AMpIEDIj5l5Y4e3EeWR8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770111895; c=relaxed/simple; bh=Cqs2ZJV6S+7Ur8W/eYJ9QXYkmA7dO/VTZ0ZHhCRoJ9E=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References: Content-Type:MIME-Version; b=hK90VMqhxwWTm7iIoXIh5OBDziQgy+7zAWcFLANJDn3izvqkWd4Ynnoo7AIwq9BuMzShygdMBUQozjId1BxVRM7HeGmQQQ9zYDRnEDREGnYctqQZtpl5YHjShr1U2pB5CT2giAIRPH/IsDSkZqOkKfEb/Wnlyn5U2WS0eEsYLyI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JrjJMUhF; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JrjJMUhF" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4801d7c72a5so42473165e9.0 for ; Tue, 03 Feb 2026 01:44:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770111892; x=1770716692; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=iAfnD0LvqQD+kZ2dzGaSed0SZSeQIrOXUL16+cIH+I8=; b=JrjJMUhFpkEbrHQNLUzNDqNaq/BTmaEyohByciMb9anH7IsUsMNY0WfPoeJlCsVok9 amQvOMguQDABkpr79cBnSuXigvCRfrNGEZ+JcVY0hQ8n1tNN8vX1WuwuRcqZgsJYbm5Y B5yeXhS6JuyR3E180UE3QPTba+8pj0q7AU3qL/bHnNOGI6isPEDvst9eyY/CV6HrP45G lslHm9YXiwM6DNXAExmMd80o3y7rXox3QanC/ySROf04alrxifol5RiWj2OQpf7IOFBd UdQJBNcQsjv8N0bqjzUjXyGNMEPmUZnEb3LgPzLhVwn3Mh8w2AWUEMYeiuNXbien4Z6G aQ/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770111892; x=1770716692; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iAfnD0LvqQD+kZ2dzGaSed0SZSeQIrOXUL16+cIH+I8=; b=ejRc0IDkHVeraIR8bp4rRHs51xQ6I2aWsJb+Ovu6d0DruNtwkSwB1HkkrSw2KoD79G RQq42Xl4pmV7/kCBEb/q5tC7TnUypbQIqAotEBIofrZhDMuU+3Bf/V94QH8QdN8vrbFP Xe1T/Yo/pf6cnamA+hZ01MqW0pt5SpRZfh1f8+VPajuBxGpe/yJATtuN7WCh7qf1tkVl erKv+Z2ZuoxArEqaWRyVbC7xXl8NCHgP/4p+BS9DqC9IIBfbWje+qmrYOPloH0ZCNCqG yIHwcQss9jUTVI+xz7NeuFvuFrGuzsKG3MkcTlY7XGBMpTA7MRUOe6NNoJjaQTaji2IQ deVA== X-Forwarded-Encrypted: i=1; AJvYcCX8WtzB/uZO4IJgcKyNKkYJG+FECh03+Yxe28U/+eSpZE4vtgxFWEgVpx4Aycl43DHXdHqolwP7Gdx4qeo=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5ejVlAyJCj3E94EJx4p1iyEYa1AO9eHkztJEXaWx1dFo7SFJ5 6ItDlCBNRZ7PA3CBlIgFP0Md+OS28cXWuBee1YUdxgBeCTzF75rYVPv6 X-Gm-Gg: AZuq6aI4QH3NLZPABCI4cb+JifbJGPpFOQKSOXva/dV/s97udyZIZHlOHojbkU9F0q/ tvM6Y1aK8TobZTRB+c/WrwpOJTBo09B29rYwTMD/A4EQP6GfVtweTbxPCr6SWGYmyCEJh+Wenz2 AIA4gX6nTqgqLol2VdBtQeCVwfU/9dFVhNx8vjlf7bpFtNWQWd8czDgJT3KaVha7h6LjpF5xryz m8SOeVdjKYCr8Rs5Gsuj7hahuvs/28SqaRyTD+VuiX0O4xKNC/hT1nOXTP2AJdeu8rk3e7LWLHu uEIyvovpESGYtIWhxQRauYF4Lem8iYJgUhIUOieNKp84lmHAZ7C4QA000X0l51E19/BNaKN2Bku IOzw9vlUkG1fUZvpnVMm2z/ENrAqInxHXN3js9hNqJD8fp07LKKdvIUyiW4qZq5/KLOQZcfn6/7 L+sRN7/nKT0rvLIyf9ZOg= X-Received: by 2002:a05:600c:3b23:b0:47a:8cce:2940 with SMTP id 5b1f17b1804b1-482db49ff27mr199382875e9.14.1770111891490; Tue, 03 Feb 2026 01:44:51 -0800 (PST) Received: from [192.168.1.187] ([148.63.225.166]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e10edfccsm48545478f8f.17.2026.02.03.01.44.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Feb 2026 01:44:51 -0800 (PST) Message-ID: Subject: Re: [PATCH v2 2/2] iio: gyro: mpu3050-core: use pm_runtime_resume_and_get() From: Nuno =?ISO-8859-1?Q?S=E1?= To: Antoniu Miclaus , Linus Walleij , Jonathan Cameron , Lars-Peter Clausen , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 03 Feb 2026 09:45:34 +0000 In-Reply-To: <3edc89e901fd9d55c5355c4ec007636b1c8d6801.1770039759.git.antoniu.miclaus@analog.com> References: <3edc89e901fd9d55c5355c4ec007636b1c8d6801.1770039759.git.antoniu.miclaus@analog.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-02-02 at 16:56 +0200, Antoniu Miclaus wrote: > Replace pm_runtime_get_sync() with pm_runtime_resume_and_get() in > mpu3050_read_raw() and mpu3050_buffer_preenable(). Unlike > pm_runtime_get_sync(), the usage count is not incremented on error. >=20 > In preenable, call pm_runtime_put_autosuspend() if set_8khz_samplerate() > fails since postdisable won't be called on preenable failure. >=20 > Signed-off-by: Antoniu Miclaus > --- To me this is more than just reference counting. It's also about proper err= or handling. - Nuno S=C3=A1 > =C2=A0drivers/iio/gyro/mpu3050-core.c | 17 +++++++++++++---- > =C2=A01 file changed, 13 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/iio/gyro/mpu3050-core.c b/drivers/iio/gyro/mpu3050-c= ore.c > index ee2fcd20545d..1cc421eb4782 100644 > --- a/drivers/iio/gyro/mpu3050-core.c > +++ b/drivers/iio/gyro/mpu3050-core.c > @@ -322,7 +322,9 @@ static int mpu3050_read_raw(struct iio_dev *indio_dev= , > =C2=A0 } > =C2=A0 case IIO_CHAN_INFO_RAW: > =C2=A0 /* Resume device */ > - pm_runtime_get_sync(mpu3050->dev); > + ret =3D pm_runtime_resume_and_get(mpu3050->dev); > + if (ret) > + return ret; > =C2=A0 mutex_lock(&mpu3050->lock); > =C2=A0 > =C2=A0 ret =3D mpu3050_set_8khz_samplerate(mpu3050); > @@ -647,12 +649,19 @@ static irqreturn_t mpu3050_trigger_handler(int irq,= void *p) > =C2=A0static int mpu3050_buffer_preenable(struct iio_dev *indio_dev) > =C2=A0{ > =C2=A0 struct mpu3050 *mpu3050 =3D iio_priv(indio_dev); > + int ret; > =C2=A0 > - pm_runtime_get_sync(mpu3050->dev); > + ret =3D pm_runtime_resume_and_get(mpu3050->dev); > + if (ret) > + return ret; > =C2=A0 > =C2=A0 /* Unless we have OUR trigger active, run at full speed */ > - if (!mpu3050->hw_irq_trigger) > - return mpu3050_set_8khz_samplerate(mpu3050); > + if (!mpu3050->hw_irq_trigger) { > + ret =3D mpu3050_set_8khz_samplerate(mpu3050); > + if (ret) > + pm_runtime_put_autosuspend(mpu3050->dev);