mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Yen-Chi Huang <jesse.huang@portwell.com.tw>
Cc: hansg@kernel.org, ilpo.jarvinen@linux.intel.com,
	jdelvare@suse.com, platform-driver-x86@vger.kernel.org,
	linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
	jay.chen@canonical.com
Subject: Re: [PATCH v4] platform/x86: portwell-ec: Add hwmon support for voltage and temperature
Date: Fri, 5 Sep 2025 14:11:32 -0700	[thread overview]
Message-ID: <a763c871-55c7-4d7d-a38b-e7b1b325b9a7@roeck-us.net> (raw)
In-Reply-To: <a5edf505-9b77-461e-ae8d-510e6ed3f950@portwell.com.tw>

On Thu, Sep 04, 2025 at 05:29:23PM +0800, Yen-Chi Huang wrote:
> Integrates voltage and temperature monitoring into the driver via the hwmon
> subsystem, enabling standardized reporting via tools like lm-sensors.
> 
> Signed-off-by: Yen-Chi Huang <jesse.huang@portwell.com.tw>
> ---
> 
> This version removes board-specific details such as labels and voltage
> scaling factors. The driver now follows a generic approach, delegating
> customization to userspace (e.g. via sensors.conf in lm-sensors), which
> is the standard and more flexible practice.

FWIW, this reasoning is wrong. sensors.conf is intended to be used for
situations where board specific scaling factors are _not_ known.

Guenter

      parent reply	other threads:[~2025-09-05 21:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-04  9:29 Yen-Chi Huang
2025-09-05  4:43 ` Guenter Roeck
2025-09-05  5:35   ` Yen-Chi Huang
2025-09-05 14:34     ` Guenter Roeck
2025-09-05 21:11 ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a763c871-55c7-4d7d-a38b-e7b1b325b9a7@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jay.chen@canonical.com \
    --cc=jdelvare@suse.com \
    --cc=jesse.huang@portwell.com.tw \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®