Re: Fw: [PATCH v3 0/4] stratix10: Add Interrupt support for asynchronous communication with SDM

["NG, TZE YEE" <tze.yee.ng@altera.com>]

On 21/9/2026 2:37 pm, NG, TZE YEE wrote:
> 
> *From:* NG, TZE YEE
> *Sent:* Thursday, August 13, 2026 2:35 PM
> *To:* Dinh Nguyen <dinguyen@kernel.org>; Rob Herring <robh@kernel.org>; 
> Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley 
> <conor+dt@kernel.org>; Rao, Mahesh <mahesh.rao@altera.com>; linux- 
> kernel@vger.kernel.org <linux-kernel@vger.kernel.org>; 
> devicetree@vger.kernel.org <devicetree@vger.kernel.org>
> *Subject:* [PATCH v3 0/4] stratix10: Add Interrupt support for 
> asynchronous communication with SDM
> From: Tze Yee Ng <tze.yee.ng@altera.com>
> 
> This patch-set adds support for interrupt from Secure Device Manager (SDM)
> to Stratix10 SoC for asynchronous communication.
> 
> Following things are added in this patch-set:
> - Add support for interrupt from SDM to Stratix10 SoC.
> - Add documentation for SDM interrupt in Stratix10 SoC.
> - Enable SDM interrupt in Stratix10 SoC.
> - Enable SDM interrupt in Agilex SoC.
> 
> I am taking over this series from Mahesh Rao and posting v3 on his behalf.
> Reference:
> https://lore.kernel.org/r/20250812-sip_svc_irq- 
> v2-0-53098e11705a@altera.com <https:// 
> nam10.safelinks.protection.outlook.com/? 
> url=https%3A%2F%2Flore.kernel.org%2Fr%2F20250812-sip_svc_irq- 
> v2-0-53098e11705a%40altera.com&data=05%7C02%7Ctze.yee.ng%40altera.com%7Ceafe6fcdec264d130fd408df17aad714%7Cfbd72e03d4a54110adce614d51f2077a%7C0%7C0%7C639255694657134969%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=hOumheIvzlbZt1UApZy2F9CCpJFiH25iWSaYeCcdjKo%3D&reserved=0>
> 
> Changes in v3:
> - Reflow commit message body to ~75 columns (fix Dinh's comment in v2
>    review)
> - Add a newline before stratix10_async_workqueue_handler
>    description (fix Dinh's comment in v2 review)
> - Treat of_irq_get() failure as irq <= 0, since 0 is also a
>    failing value (fix Dinh's comment in v2 review)
> - Fix IRQ disable race: only call disable_irq_nosync() when
>    queue_work() newly queues work, and disable the fired irq
>    argument rather than actrl->irq
> - Do not invoke client callbacks under trx_list_lock; copy
>    cb/cb_arg under the lock and call the callback after unlock
> - Use disable_irq() + flush_work() + devm_free_irq() on
>    teardown, and treat unset IRQ as 0
> - Demote successful IRQ registration log from dev_alert() to
>    dev_info(), and demote async poll failure log from
>    dev_err() to dev_dbg()
> - Clarify INTEL_SIP_SMC_ASYNC_POLL_ON_IRQ kdoc to match
>    a1-a4 bitmap usage
> - Drop Reviewed-by: Matthew Gerlach from all patches
>    (no longer at Altera)
> - Link to RESEND v2:
> https://lore.kernel.org/r/20250812-sip_svc_irq- 
> v2-0-53098e11705a@altera.com <https:// 
> nam10.safelinks.protection.outlook.com/? 
> url=https%3A%2F%2Flore.kernel.org%2Fr%2F20250812-sip_svc_irq- 
> v2-0-53098e11705a%40altera.com&data=05%7C02%7Ctze.yee.ng%40altera.com%7Ceafe6fcdec264d130fd408df17aad714%7Cfbd72e03d4a54110adce614d51f2077a%7C0%7C0%7C639255694657165509%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=uDzBqNLWQSLSTmXyM72mbyHy5JfchKhk9a6xhrFF5pc%3D&reserved=0>
> 
> Changes in v2:
> - Separated from the larger SIP SVC upstream series into a
>    dedicated interrupt-support series as requested
> - Link to v1:
> https://lore.kernel.org/r/20250722-sip_svc_irq-v1-0- 
> c5b9e02c1ce6@altera.com <https:// 
> nam10.safelinks.protection.outlook.com/? 
> url=https%3A%2F%2Flore.kernel.org%2Fr%2F20250722-sip_svc_irq-v1-0- 
> c5b9e02c1ce6%40altera.com&data=05%7C02%7Ctze.yee.ng%40altera.com%7Ceafe6fcdec264d130fd408df17aad714%7Cfbd72e03d4a54110adce614d51f2077a%7C0%7C0%7C639255694657185496%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=dSLMGTCQPtY6nHXWwKPeen2XIuPzs1vZ6NKBcMYVwEA%3D&reserved=0>
> 
> Mahesh Rao (4):
>    dt-bindings: firmware: Add interrupt specification for Intel Stratix
>      10 Service Layer.
>    dts: stratix10: Add support for SDM mailbox interrupt for Intel
>      Stratix10 SoC FPGA.
>    dts: agilex: Add support for SDM mailbox interrupt for Intel Agilex
>      SoC FPGA.
>    firmware: stratix10-svc: Add for SDM mailbox doorbell interrupt
> 
>   .../firmware/intel,stratix10-svc.yaml         |  10 ++
>   .../boot/dts/altera/socfpga_stratix10.dtsi    |   4 +
>   arch/arm64/boot/dts/intel/socfpga_agilex.dtsi |   2 +
>   drivers/firmware/stratix10-svc.c              | 135 ++++++++++++++++--
>   include/linux/firmware/intel/stratix10-smc.h  |  21 +++
>   5 files changed, 161 insertions(+), 11 deletions(-)
> 
> -- 
> 2.43.7
> 

Hi,

Gentle ping on this patch. It has been over a month with no feedback.

Happy to address any review comments.

Thanks,
Tze Yee