From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 354082D3A60 for ; Thu, 2 Apr 2026 02:29:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775096975; cv=none; b=a5MYxRhx1hlQqqhEpm1D25VkKr1IOEoZ0yWhyCeE7zJ6FZZFeTIJyODRjZ+NYZeQgk37kjx5hfhC28P5fjpYpYS4U1YL1ZDIuL0F2GCFzaST8vELuPsJWuLGk+i0O53IYqNtGgPXyiqRLvz60JMtLmSUsSRJBGq6UzLrl93h2g4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775096975; c=relaxed/simple; bh=nGSbM6iWNi54IURbVCZil/MROs/YoY4WcW5y3ipipU4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=R9tWPtbx9B/j7l4HuGLxm6lJyamh6OhdVxAaXUWnbp6p0W0HL4+YxmxvJ/mDXWloob9osaoYQhFQgQ28DGDIHYeV4SQjzWDdtr1sQdA4kYhw84NKe8SdZdNul4rkJVQulQaS9QNUzQyQ0lKJ/Z0XswmCAkyfstSufrhz+lnML6U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=mMxnb0PN; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="mMxnb0PN" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 046031C14; Wed, 1 Apr 2026 19:29:19 -0700 (PDT) Received: from [10.164.18.48] (J09HK2D2RT.blr.arm.com [10.164.18.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EB36F3F7D8; Wed, 1 Apr 2026 19:29:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1775096964; bh=nGSbM6iWNi54IURbVCZil/MROs/YoY4WcW5y3ipipU4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=mMxnb0PN+5JHowx4quU5bYmHMjpVXMzynlXHrEmgDoIIX/TbQNMvcmrGa76T5AesX ilGG7tqqffCV+tINYeGIA1qANdhTxsWdyXKzzA22uMUyfcWl+2gH2nFMPJB2RCLgTc qnnN/SpUEGFmWY4FB3gtH/J3h+t2gLQENg+Nw8ts= Message-ID: Date: Thu, 2 Apr 2026 07:59:18 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/page_alloc: cleanup flag vars in alloc_pages_bulk_noprof() To: Brendan Jackman , Andrew Morton , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Johannes Weiner , Zi Yan Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20260331-b4-prepare_alloc_pages-flags-v1-1-ea2416def698@google.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20260331-b4-prepare_alloc_pages-flags-v1-1-ea2416def698@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 31/03/26 4:22 PM, Brendan Jackman wrote: > These two variables are redundant, squash them to align > alloc_pages_bulk_noprof() with the style used in > alloc_frozen_pages_nolock_noprof(). > > Signed-off-by: Brendan Jackman > --- > mm/page_alloc.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 111b54df8a3cb..5e280ded6e7ac 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -5051,7 +5051,6 @@ unsigned long alloc_pages_bulk_noprof(gfp_t gfp, int preferred_nid, > struct per_cpu_pages *pcp; > struct list_head *pcp_list; > struct alloc_context ac; > - gfp_t alloc_gfp; > unsigned int alloc_flags = ALLOC_WMARK_LOW; > int nr_populated = 0, nr_account = 0; > > @@ -5092,10 +5091,8 @@ unsigned long alloc_pages_bulk_noprof(gfp_t gfp, int preferred_nid, > > /* May set ALLOC_NOFRAGMENT, fragmentation will return 1 page. */ > gfp &= gfp_allowed_mask; > - alloc_gfp = gfp; > - if (!prepare_alloc_pages(gfp, 0, preferred_nid, nodemask, &ac, &alloc_gfp, &alloc_flags)) > + if (!prepare_alloc_pages(gfp, 0, preferred_nid, nodemask, &ac, &gfp, &alloc_flags)) > goto out; > - gfp = alloc_gfp; > > /* Find an allowed local zone that meets the low watermark. */ > z = ac.preferred_zoneref; > Reviewed-by: Anshuman Khandual