From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B78A5C4321E for ; Tue, 18 Jan 2022 16:19:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236454AbiARQTD (ORCPT ); Tue, 18 Jan 2022 11:19:03 -0500 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]:59408 "EHLO smtp-relay-internal-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244047AbiARQSc (ORCPT ); Tue, 18 Jan 2022 11:18:32 -0500 Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 86F473FFDE for ; Tue, 18 Jan 2022 16:18:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1642522711; bh=/saHFgfod+VllDCyIGCao3k0CHQX0T4IuTyB9aTiQuw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gsPqiM8e+YJ3xaRA3ZezbNLgIXuyDOVo9lBMt1/oU0IWXc8pRYrZ4YCiq3uz9gmYq 3yKqOdRHE6MrmtMzwCccHCibF0+l+4/x5veA6CDR4OdA6cjVF7e4/mD4H4OH5yvduU sOcCwrhBwundJeEqIKOHnoyynBXnD2HYHm23sKuHe0OmxCVtpvvdIKh46IIo3udPVe 9OsgTteFGNYcNrs+SAQghU530OE/j6AReGtXsbYctGnBX5dJda5G8I9mSMjq9al7CJ YkE4V9LYEy7oLM1ZENS2grwdIi35A8KEL+ZeZOWotmHFNIE9buyxJKj3m3ZjVFXsEu tLJeMs30F6WTw== Received: by mail-ed1-f69.google.com with SMTP id c8-20020a05640227c800b003fdc1684cdeso17531257ede.12 for ; Tue, 18 Jan 2022 08:18:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=/saHFgfod+VllDCyIGCao3k0CHQX0T4IuTyB9aTiQuw=; b=HO8J/77Jc9r0pOSEvRYs9R7QDYkNDWwsrhoeZDZ1BbOqL/LuucqmTjDRhXuu/ad1gA oNgO7x/f9GCiMoMKGy9YDyQrKWGCoxad2X8/32m9YZWFMm8Sza2kKWEQlocZi5DVvUsT NkvgYNv7m0UtzQHepJ+zG2RMmKmMLntqCobg/xog7tUKOaY7Cve13w6Xv3dmUglk31U3 Fc8eca0Y1+WnnpKFPu0p2OIETx0yEjGkHKtL0ulaOflT9Hlapdq1V15AK52FSZMte6XK pszkqdRdR6DnzzlOxUQ+0SaeYhKXfeegSeak6sAQYIrmMzZ9q0LGhWfy7CcNL7sKEk3b 9ztg== X-Gm-Message-State: AOAM531yJAfeyDC80kDJUOck44uKbvmG6uFxlZCvuWRFCDeGbt+X/bDf 8erTd1YSXErOuxgPwlHJyKv7ALYs11zm+hxMi76qRwRvG26MSFRep3zYGn7d2i17IERVMOs2UT5 AY2cxBaGcqsCmyw6iX4XVg7DjWHJOlN94cAoKsD6lbA== X-Received: by 2002:a17:907:9622:: with SMTP id gb34mr20839794ejc.355.1642522710373; Tue, 18 Jan 2022 08:18:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJxfIifqQ4AVPmYgf7XBd2Pu5uw++MPB2xe5GXOSCfqiesyMFJpl04gNL7IFKznqIxQO1lmdgg== X-Received: by 2002:a17:907:9622:: with SMTP id gb34mr20839776ejc.355.1642522710089; Tue, 18 Jan 2022 08:18:30 -0800 (PST) Received: from [192.168.0.42] (xdsl-188-155-168-84.adslplus.ch. [188.155.168.84]) by smtp.gmail.com with ESMTPSA id qa35sm5431720ejc.67.2022.01.18.08.18.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Jan 2022 08:18:29 -0800 (PST) Message-ID: Date: Tue, 18 Jan 2022 17:18:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: [PATCH v2 02/16] dt-bindings: clock: Add bindings definitions for FSD CMU blocks Content-Language: en-US To: Alim Akhtar , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: soc@kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, olof@lixom.net, arnd@arndb.de, linus.walleij@linaro.org, catalin.marinas@arm.com, robh+dt@kernel.org, s.nawrocki@samsung.com, linux-samsung-soc@vger.kernel.org, pankaj.dubey@samsung.com, linux-fsd@tesla.com References: <20220118144851.69537-1-alim.akhtar@samsung.com> <20220118144851.69537-3-alim.akhtar@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20220118144851.69537-3-alim.akhtar@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/01/2022 15:48, Alim Akhtar wrote: > Clock controller driver of FSD platform is designed to have separate > instances for each particular CMU. So clock IDs in this bindings header > also start from 1 for each CMU block. > > Cc: linux-fsd@tesla.com > Reported-by: kernel test robot > [robot: reported missing #endif] > Signed-off-by: Pankaj Dubey > Signed-off-by: Alim Akhtar > --- > include/dt-bindings/clock/fsd-clk.h | 149 ++++++++++++++++++++++++++++ > 1 file changed, 149 insertions(+) > create mode 100644 include/dt-bindings/clock/fsd-clk.h > > diff --git a/include/dt-bindings/clock/fsd-clk.h b/include/dt-bindings/clock/fsd-clk.h > new file mode 100644 > index 000000000000..8cf45d2430b0 > --- /dev/null > +++ b/include/dt-bindings/clock/fsd-clk.h > @@ -0,0 +1,149 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Copyright (c) 2017 - 2022: Samsung Electronics Co., Ltd. > + * https://www.samsung.com > + * Copyright (c) 2017-2022 Tesla, Inc. > + * https://www.tesla.com > + * > + * The constants defined in this header are being used in dts > + * and fsd platform driver. > + */ > + > +#ifndef _DT_BINDINGS_CLOCK_FSD_H > +#define _DT_BINDINGS_CLOCK_FSD_H > + > +/* CMU */ > +#define DOUT_CMU_PLL_SHARED0_DIV4 1 > +#define DOUT_CMU_PERIC_SHARED1DIV36 2 > +#define DOUT_CMU_PERIC_SHARED0DIV3_TBUCLK 3 > +#define DOUT_CMU_PERIC_SHARED0DIV20 4 > +#define DOUT_CMU_PERIC_SHARED1DIV4_DMACLK 5 > +#define DOUT_CMU_PLL_SHARED0_DIV6 6 > +#define DOUT_CMU_FSYS0_SHARED1DIV4 7 > +#define DOUT_CMU_FSYS0_SHARED0DIV4 8 > +#define DOUT_CMU_FSYS1_SHARED0DIV8 9 > +#define DOUT_CMU_FSYS1_SHARED0DIV4 10 > +#define CMU_CPUCL_SWITCH_GATE 11 > +#define DOUT_CMU_IMEM_TCUCLK 12 > +#define DOUT_CMU_IMEM_ACLK 13 > +#define DOUT_CMU_IMEM_DMACLK 14 > +#define GAT_CMU_FSYS0_SHARED0DIV4 15 > +#define CMU_NR_CLK 16 > + > +/* PERIC */ > +#define PERIC_SCLK_UART0 1 > +#define PERIC_PCLK_UART0 2 > +#define PERIC_SCLK_UART1 3 > +#define PERIC_PCLK_UART1 4 > +#define PERIC_DMA0_IPCLKPORT_ACLK 5 > +#define PERIC_DMA1_IPCLKPORT_ACLK 6 > +#define PERIC_PWM0_IPCLKPORT_I_PCLK_S0 7 > +#define PERIC_PWM1_IPCLKPORT_I_PCLK_S0 8 > +#define PERIC_PCLK_SPI0 9 > +#define PERIC_SCLK_SPI0 10 > +#define PERIC_PCLK_SPI1 11 > +#define PERIC_SCLK_SPI1 12 > +#define PERIC_PCLK_SPI2 13 > +#define PERIC_SCLK_SPI2 14 > +#define PERIC_PCLK_TDM0 15 > +#define PERIC_PCLK_HSI2C0 16 > +#define PERIC_PCLK_HSI2C1 17 > +#define PERIC_PCLK_HSI2C2 18 > +#define PERIC_PCLK_HSI2C3 19 > +#define PERIC_PCLK_HSI2C4 20 > +#define PERIC_PCLK_HSI2C5 21 > +#define PERIC_PCLK_HSI2C6 22 > +#define PERIC_PCLK_HSI2C7 23 > +#define PERIC_MCAN0_IPCLKPORT_CCLK 24 > +#define PERIC_MCAN0_IPCLKPORT_PCLK 25 > +#define PERIC_MCAN1_IPCLKPORT_CCLK 26 > +#define PERIC_MCAN1_IPCLKPORT_PCLK 27 > +#define PERIC_MCAN2_IPCLKPORT_CCLK 28 > +#define PERIC_MCAN2_IPCLKPORT_PCLK 29 > +#define PERIC_MCAN3_IPCLKPORT_CCLK 30 > +#define PERIC_MCAN3_IPCLKPORT_PCLK 31 > +#define PERIC_PCLK_ADCIF 32 > +#define PERIC_EQOS_TOP_IPCLKPORT_CLK_PTP_REF_I 33 > +#define PERIC_EQOS_TOP_IPCLKPORT_ACLK_I 34 > +#define PERIC_EQOS_TOP_IPCLKPORT_HCLK_I 35 > +#define PERIC_EQOS_TOP_IPCLKPORT_RGMII_CLK_I 36 > +#define PERIC_EQOS_TOP_IPCLKPORT_CLK_RX_I 37 > +#define PERIC_BUS_D_PERIC_IPCLKPORT_EQOSCLK 38 > +#define PERIC_BUS_P_PERIC_IPCLKPORT_EQOSCLK 39 > +#define PERIC_HCLK_TDM0 40 > +#define PERIC_PCLK_TDM1 41 > +#define PERIC_HCLK_TDM1 42 > +#define PERIC_EQOS_PHYRXCLK_MUX 43 > +#define PERIC_EQOS_PHYRXCLK 44 > +#define PERIC_DOUT_RGMII_CLK 45 > +#define PERIC_NR_CLK 46 > + > +/* FSYS0 */ > +#define UFS0_MPHY_REFCLK_IXTAL24 1 > +#define UFS0_MPHY_REFCLK_IXTAL26 2 > +#define UFS1_MPHY_REFCLK_IXTAL24 3 > +#define UFS1_MPHY_REFCLK_IXTAL26 4 > +#define UFS0_TOP0_HCLK_BUS 5 > +#define UFS0_TOP0_ACLK 6 > +#define UFS0_TOP0_CLK_UNIPRO 7 > +#define UFS0_TOP0_FMP_CLK 8 > +#define UFS1_TOP1_HCLK_BUS 9 > +#define UFS1_TOP1_ACLK 10 > +#define UFS1_TOP1_CLK_UNIPRO 11 > +#define UFS1_TOP1_FMP_CLK 12 > +#define PCIE_SUBCTRL_INST0_DBI_ACLK_SOC 13 > +#define PCIE_SUBCTRL_INST0_AUX_CLK_SOC 14 > +#define PCIE_SUBCTRL_INST0_MSTR_ACLK_SOC 15 > +#define PCIE_SUBCTRL_INST0_SLV_ACLK_SOC 16 > +#define FSYS0_EQOS_TOP0_IPCLKPORT_CLK_PTP_REF_I 17 > +#define FSYS0_EQOS_TOP0_IPCLKPORT_ACLK_I 18 > +#define FSYS0_EQOS_TOP0_IPCLKPORT_HCLK_I 19 > +#define FSYS0_EQOS_TOP0_IPCLKPORT_RGMII_CLK_I 20 > +#define FSYS0_EQOS_TOP0_IPCLKPORT_CLK_RX_I 21 > +#define FSYS0_DOUT_FSYS0_PERIBUS_GRP 22 > +#define FSYS0_NR_CLK 23 > + > +/* FSYS1 */ > +#define PCIE_LINK0_IPCLKPORT_DBI_ACLK 1 > +#define PCIE_LINK0_IPCLKPORT_AUX_ACLK 2 > +#define PCIE_LINK0_IPCLKPORT_MSTR_ACLK 3 > +#define PCIE_LINK0_IPCLKPORT_SLV_ACLK 4 > +#define PCIE_LINK1_IPCLKPORT_DBI_ACLK 5 > +#define PCIE_LINK1_IPCLKPORT_AUX_ACLK 6 > +#define PCIE_LINK1_IPCLKPORT_MSTR_ACLK 7 > +#define PCIE_LINK1_IPCLKPORT_SLV_ACLK 8 > +#define FSYS1_NR_CLK 9 > + > +/* IMEM */ > +#define IMEM_DMA0_IPCLKPORT_ACLK 1 > +#define IMEM_DMA1_IPCLKPORT_ACLK 2 > +#define IMEM_WDT0_IPCLKPORT_PCLK 3 > +#define IMEM_WDT1_IPCLKPORT_PCLK 4 > +#define IMEM_WDT2_IPCLKPORT_PCLK 5 > +#define IMEM_MCT_PCLK 6 > +#define IMEM_TMU_CPU0_IPCLKPORT_I_CLK_TS 7 > +#define IMEM_TMU_CPU2_IPCLKPORT_I_CLK_TS 8 > +#define IMEM_TMU_TOP_IPCLKPORT_I_CLK_TS 9 > +#define IMEM_TMU_GPU_IPCLKPORT_I_CLK_TS 10 > +#define IMEM_TMU_GT_IPCLKPORT_I_CLK_TS 11 > +#define IMEM_NR_CLK 12 > + > +/* MFC */ > +#define MFC_MFC_IPCLKPORT_ACLK 1 > +#define MFC_NR_CLK 2 > + > +/* CAM_CSI */ > +#define CAM_CSI0_0_IPCLKPORT_I_ACLK 1 > +#define CAM_CSI0_1_IPCLKPORT_I_ACLK 2 > +#define CAM_CSI0_2_IPCLKPORT_I_ACLK 3 > +#define CAM_CSI0_3_IPCLKPORT_I_ACLK 4 > +#define CAM_CSI1_0_IPCLKPORT_I_ACLK 5 > +#define CAM_CSI1_1_IPCLKPORT_I_ACLK 6 > +#define CAM_CSI1_2_IPCLKPORT_I_ACLK 7 > +#define CAM_CSI1_3_IPCLKPORT_I_ACLK 8 > +#define CAM_CSI2_0_IPCLKPORT_I_ACLK 9 > +#define CAM_CSI2_1_IPCLKPORT_I_ACLK 10 > +#define CAM_CSI2_2_IPCLKPORT_I_ACLK 11 > +#define CAM_CSI2_3_IPCLKPORT_I_ACLK 12 > +#define CAM_CSI_NR_CLK 13 One empty line would be nice here. Reviewed-by: Krzysztof Kozlowski > +#endif /*_DT_BINDINGS_CLOCK_FSD_H */ > Best regards, Krzysztof