From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jorge Ramirez <jorge.ramirez@oss.qualcomm.com>
Cc: quic_vgarodia@quicinc.com, quic_dikshita@quicinc.com,
bryan.odonoghue@linaro.org, mchehab@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
stanimir.varbanov@linaro.org, linux-arm-msm@vger.kernel.org,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] dt-bindings: media: venus: Add qcm2290 dt schema
Date: Mon, 16 Jun 2025 16:41:44 +0200 [thread overview]
Message-ID: <a76789cf-afe1-4d91-afdf-65c3af5ad11f@kernel.org> (raw)
In-Reply-To: <aFATp3zoSgkrj3YX@trex>
On 16/06/2025 14:52, Jorge Ramirez wrote:
>>
>>> + The Venus AR50_LITE IP is a video encode and decode accelerator present
>>> + on Qualcomm platforms
>>> +
>>> +allOf:
>>> + - $ref: qcom,venus-common.yaml#
>>> +
>>> +properties:
>>> + compatible:
>>> + const: qcom,qcm2290-venus
>>> +
>>> + power-domains:
>>> + minItems: 2
>>> + maxItems: 3
>>> +
>>> + power-domain-names:
>>> + minItems: 2
>>
>> Why is this flexible? Either you have two or three. Not mixed.
>
> please check 5b380f242f360256c96e96adabeb7ce9ec784306
This does not explain why this is optional HERE. You cannot use for a
new platform an argument that some existing platform was changed in
ABI-preserving way.
BTW, also subject prefixes needs fixing. For DTS: it is never "arch".
For this patch: wrong order (see DT submitting patches).
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-06-16 14:41 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-13 14:03 [PATCH 0/5] media: venus: Add QCM2290 support with AR50_LITE core Jorge Ramirez-Ortiz
2025-06-13 14:03 ` [PATCH 1/5] dt-bindings: media: venus: Add qcm2290 dt schema Jorge Ramirez-Ortiz
2025-06-13 14:20 ` Bryan O'Donoghue
2025-06-15 11:38 ` Jorge Ramirez
2025-06-16 8:20 ` Krzysztof Kozlowski
2025-06-16 12:52 ` Jorge Ramirez
2025-06-16 14:41 ` Krzysztof Kozlowski [this message]
2025-06-16 16:18 ` Jorge Ramirez
2025-06-16 16:23 ` Krzysztof Kozlowski
2025-06-16 16:59 ` Jorge Ramirez
2025-06-17 6:14 ` Krzysztof Kozlowski
2025-06-17 6:47 ` Jorge Ramirez
2025-06-17 6:56 ` Krzysztof Kozlowski
2025-06-17 7:30 ` Jorge Ramirez
2025-06-17 7:55 ` Krzysztof Kozlowski
2025-06-13 14:03 ` [PATCH 2/5] arch: arm64: dts: qcom: qcm2290: Add venus video node Jorge Ramirez-Ortiz
2025-06-13 14:06 ` Bryan O'Donoghue
2025-06-15 11:18 ` Jorge Ramirez
2025-06-16 8:22 ` Krzysztof Kozlowski
2025-06-16 12:57 ` Jorge Ramirez
2025-06-13 14:04 ` [PATCH 3/5] media: venus: vdec: ar50_lite video core support Jorge Ramirez-Ortiz
2025-06-13 14:18 ` Bryan O'Donoghue
2025-06-15 11:38 ` Jorge Ramirez
2025-06-16 8:13 ` Bryan O'Donoghue
2025-06-16 12:56 ` Jorge Ramirez
2025-06-13 14:04 ` [PATCH 4/5] media: venus: hfi_plat_v6_lite: Populate decode capabilities Jorge Ramirez-Ortiz
2025-06-13 14:04 ` [PATCH 5/5] media: venus: core: Add qcm2290 DT compatible and resource data Jorge Ramirez-Ortiz
2025-06-13 14:20 ` Bryan O'Donoghue
2025-06-23 7:49 ` [PATCH v3 0/5] media: venus: Add QCM2290 support with AR50_LITE core Jorge Ramirez-Ortiz
2025-06-23 7:49 ` [PATCH v3 1/5] dt-bindings: media: venus: Add qcm2290 dt schema Jorge Ramirez-Ortiz
2025-06-23 7:57 ` Krzysztof Kozlowski
2025-06-23 7:49 ` [PATCH v3 2/5] media: venus: vdec: AR50_LITE video core support Jorge Ramirez-Ortiz
2025-06-23 7:49 ` [PATCH v3 3/5] media: venus: hfi_plat_v6_lite: Populate decode capabilities Jorge Ramirez-Ortiz
2025-06-23 7:49 ` [PATCH v3 4/5] media: venus: core: Add qcm2290 DT compatible and resource data Jorge Ramirez-Ortiz
2025-06-23 7:49 ` [PATCH v3 5/5] arm64: dts: qcom: qcm2290: Add venus video node Jorge Ramirez-Ortiz
2025-06-23 7:55 ` [PATCH v3 0/5] media: venus: Add QCM2290 support with AR50_LITE core Krzysztof Kozlowski
2025-06-23 8:07 ` Jorge Ramirez
2025-06-23 8:39 ` Krzysztof Kozlowski
2025-06-23 10:37 ` Jorge Ramirez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a76789cf-afe1-4d91-afdf-65c3af5ad11f@kernel.org \
--to=krzk@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jorge.ramirez@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_dikshita@quicinc.com \
--cc=quic_vgarodia@quicinc.com \
--cc=robh@kernel.org \
--cc=stanimir.varbanov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®