From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BACA2FE58F for ; Tue, 6 Jan 2026 19:43:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767728595; cv=none; b=Z+vnm+pTMs37GGZ7eG8aqBz/4KBNcV0ueSX/RQt46ZKLlVY0SgwvwWvdNKgtrfoZ6wd4IxY8yhaAgAFVr89GjNNkIDK17eOR772nljB8N3B216K7lZ6B7Q7Ap8NV3P25vpmXEEf8de8f4AGO+SBHaWjKomrADT7iRud6wIiV+7Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767728595; c=relaxed/simple; bh=XfX+b6dLCq2w3dZ+DVIExRn/Lhy7ELFfs4bDhfz5P58=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ariC1tzqi0aqouovbt8jFzLGs3OcOSWzvteGkq4BPFnlHGBRUIKGqMX2xoxJt1vSakQPLFkCAH/Cm7ZS1gfpXn4G4Ry89VSKKoaBZOnpeKkkO/sace9ywUTUL8Muvig0O6vIYUjl+F2nJU/XoHNx6/OmO//IXEf+S7sZnpDRfI8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UgHlRvwi; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GmR+fs5X; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UgHlRvwi"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GmR+fs5X" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 606HkE9D266638 for ; Tue, 6 Jan 2026 19:43:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= DZDTYeigK/sfx0x25w6qJIS+ZT6X8Spw4/Jf9zAiFq4=; b=UgHlRvwiBVU1UiER MjTonP4NnLN281cVbJMepEz6xjVuQZi/mvBTl1Snz1NHRbsL6R6pvi5SaQ2iPH4M OtxXVE5S/PtYxPn231jPz8E8HEd8mQaImdqJ+4E7NJwASXwTy1kQ5AfCXXVwyKU4 YPsWlFOQXajzB0PVL1SRMm6WAGdQMLgxGKRFnTy7kHfmndl3QctN9UT6daMK5K4E lw0MTjC6rI/A7t3tJaH1PixgmIJsjtideRJ3ifvLWYTrjWyDF662JT0shsuTrZIm X/wCz0U22GRoU65BZdy764oVTggZSsiDaM9jy3JhCEU4aN3RorvyHl8LLC+Yh87y 26zCew== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bh736rbca-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 06 Jan 2026 19:43:10 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-34c387d3eb6so1218966a91.2 for ; Tue, 06 Jan 2026 11:43:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767728589; x=1768333389; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DZDTYeigK/sfx0x25w6qJIS+ZT6X8Spw4/Jf9zAiFq4=; b=GmR+fs5XrokSfIOVQZud8YGXh6TweJblk9L+MYm3T6MevxBd2/dd9aegxmHVa55rnN fuzZBzn9E3r+Fw0sIaBpHAEWixxKSTR6WEp2w5bEUr47IJiAwejIL/nv4Cy628oiAibh zFaXTABhXrIBnbCYSmlISOOJFKduy+VVQemw/8ebpC/2bAsJ5GHzmwtV84/19fWQ9div 65PFKJ2w70sY6GukDAKLYioy/8SnCF9GInTv0xwcdpXjtq1Q43wOSfCQ53ypoDWECgMP ojKGNAlh4RDFxFm6xsbX4Rrn3UlCS7+yvhUc4vLy9iYchz90pf/be/Kpo4Fmo1ssCvgF F7IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767728589; x=1768333389; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DZDTYeigK/sfx0x25w6qJIS+ZT6X8Spw4/Jf9zAiFq4=; b=ajB9qoAT9Rr7j5Ge0NGUEcEemHksMACz3zOT2r0Z1JJu6mSMuJJh0EZ8B/6FcFcMwb Q2QyHwPsj6hEYaikwjSTEcn3sKoHl0zg9Lm2+h7XQETZDEtS1TNPnJexzYPK/+xdRkEU jZQg2acD+r/AFNItT2vRGcW5SSs/+V49U4viVi0y4tiaaLt9VSPWwv9hwCYo8l88FpM1 ZygHKHfwi2NBDWuIVPepjq+HmNDtQQKaSLBuN81YkFr1Bo4uBqZGbEhIxHXkIuQvLzuM 4vLSI4OaBKq4M0PdkTbLcCRIBGd7DVrGgnfSKYIpH62rzzZsuwU0L0nKe5b0qHLbTYqg orVg== X-Forwarded-Encrypted: i=1; AJvYcCWl+3AhL/0QoAQDebxf0TmY9SAZnOt4EVi37WKjsKHBeiJrxNoIECmNXGgBLgXD3cLefZFoVJajK75ZtQQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yxe2I2tvOJI9cM8jl99ggMqb769xuEHq5WTdRrjtAe8jWBLn6El DVFqINoGbHkaNCClUT3qq/sIhrYTvEKsStSpxEbfm/mVaL/z9RweGuGA5LQd5pkv31vK7dO0/S9 4QM7NmUgV9PpFLvAQTLXwxIM1D987JOemDXuKMM9jtyfMuO/CMIBTdsKlZiiaYf70z9I= X-Gm-Gg: AY/fxX41vzwtKSJw++UPEPMn3qT3vVp1O9Kmc9NTqgl7cx6dgZU+rI785RHo3Zhic77 KkwsgPxx/drgSzdNmNvZCVpfpK7NpBuEUJJYVdkHLz2mllw1QRHZ5lDV+vqah42FmWY57aQddcX W8hS443eWuaw5rOk4l8MIjSapOqVhe1sDkKJk7p5ox/1I0F1EoC2tiyivwDvaiUThCxHmSFqTkr zLzJuSgJq6rcs8on66XmtQRcxmfE7z0mUvFz8bltDI0MD1OvA3P/G8h5+m8ocDXxnfd9moq8vAS fLSvRpgX2La0zW1WThqZOwiTHaM/900G1taxwxbXFioVt3JmJH38Dv0wabCOzKWuiOP26BKpMwd 5sBLWiPV1v1ToBkwIxvhisSBBuM1126MkA3pdfagkUvk6u/j/y/xfRn9WtoSrzH5J+Q== X-Received: by 2002:a17:90b:4acb:b0:349:7f0a:381b with SMTP id 98e67ed59e1d1-34f68b4c603mr228430a91.8.1767728589196; Tue, 06 Jan 2026 11:43:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IGR7diURQX5/IXX/QMdmcVn16iPBI2ko8itYSY30OsuI6Gy/ChZZ4MFegFlC2SaEMUsbJ5HFg== X-Received: by 2002:a17:90b:4acb:b0:349:7f0a:381b with SMTP id 98e67ed59e1d1-34f68b4c603mr228406a91.8.1767728588676; Tue, 06 Jan 2026 11:43:08 -0800 (PST) Received: from [10.62.37.112] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34f601351bcsm1113023a91.5.2026.01.06.11.43.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Jan 2026 11:43:08 -0800 (PST) Message-ID: Date: Tue, 6 Jan 2026 11:43:06 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 7/7] arm64: dts: qcom: sm8750: Add support for camss To: Krzysztof Kozlowski , Hangxiang Ma Cc: Loic Poulain , Robert Foss , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Todor Tomov , Vladimir Zapolskiy , Mauro Carvalho Chehab , Bryan O'Donoghue , linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, jeyaprakash.soundrapandian@oss.qualcomm.com References: <20251126-add-support-for-camss-on-sm8750-v1-0-646fee2eb720@oss.qualcomm.com> <20251126-add-support-for-camss-on-sm8750-v1-7-646fee2eb720@oss.qualcomm.com> <20251127-steadfast-red-koel-8c9bc8@kuoka> <6aa8ffc4-2fe5-44ad-8ac8-581e0697360f@oss.qualcomm.com> <355c3ae0-9603-4750-b83d-64447b6581ce@kernel.org> Content-Language: en-US From: Vijay Kumar Tumati In-Reply-To: <355c3ae0-9603-4750-b83d-64447b6581ce@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Ba7VE7t2 c=1 sm=1 tr=0 ts=695d65ce cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=vtVd1KKryTdkyhPdPdsA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-GUID: 3HGPxSrGXw0gy13veionZ-0od4qZWvDi X-Proofpoint-ORIG-GUID: 3HGPxSrGXw0gy13veionZ-0od4qZWvDi X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA2MDE3MCBTYWx0ZWRfX/orauUyig7JR H7MZB5KGDcwxEZT2u+/au4/niLfWrAmFkTfleUb3ZZVQM9g986+cfBfLOZGMiFSVRQ+t8O8RPNt s21/HXHuuVU4WwSUn0dntTRsyaO08Qu0PbbyD5K5+GPDqDx5f///F2Raa77XomJOkxtZRRxnVpP HTYd1ZDjIRtBhobD+R3bhEZFkbYvX10mSF2ZdDEF1ene75+NoHayDZX2Q+MbYK7yMjAoRVCRW7v 1c/jmQPHCwRXU1KTrQWtldI7w/3TwNGMPfPIbuTNm22I0+C/b18iAsoSYmZ0cAcimaC6EWc61ar l6u8vHv8WHh/XvrIZWHbWKAEdW8OHYetTwELlBgHeIqSdZyu2lgyJdB7Yx+LAzkWCS8yxNk3r/V dlpb7gZe01PH4nDR1suGbTNfcN9vXSqL0tic21mXfikjkN3Cbuw7R1nS6Xln1+ilqMpcOjN2+To inIRdp5yVuMNV/B/Gzg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-06_01,2026-01-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 malwarescore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 phishscore=0 impostorscore=0 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601060170 On 1/6/2026 11:20 AM, Krzysztof Kozlowski wrote: > On 06/01/2026 20:18, Krzysztof Kozlowski wrote: >> On 06/01/2026 19:40, Vijay Kumar Tumati wrote: >>> On 11/27/2025 12:12 AM, Krzysztof Kozlowski wrote: >>>> On Wed, Nov 26, 2025 at 01:38:40AM -0800, Hangxiang Ma wrote: > Look here^ > >>>>> + }; >>>>> + >>>>> + cci0: cci@ac7b000 { >>>> Looks completely mis-ordered/sorted. What are the nodes above and below? >>> Hi Krzysztof, sorry, not sure how you mean exactly. The ones above are >>> the pinctrl nodes. Each CCI has two masters using two GPIOs each, one >> Why would pinctrl nodes matter anyhow? Please read how DTS syntax works. >> >>> for clk and one for data. The ones below are the actual CCI HW nodes >>> that make use of the pinctrls. I believe this is inline with previous >>> generations. Have I missed something? Thanks. >> I wrote what is wrong. Is this maintaining proper sorting? Did you read >> DTS coding style? >> > > Heh, you received my review 1 day after your posting. > > You replied to my review 5-6 weeks after, yet you still expect me to > understand the context and provide clarifications. > > There is simpler way: NAK. > > You will not get your patches merged with such latency and such replies > not even trying to address the problem or learn about it. Agreed. Apologies for the delay. It was partly caused by the dependency that these patches have on Kaanapali patches and partly by vacations during Christmas. We will explore and address your concerns reg CCI nodes and push the next revision ASAP. Thanks for your understanding, Krzysztof. > > Best regards, > Krzysztof