mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chao Yu <chao@kernel.org>
To: Gao Xiang <hsiangkao@linux.alibaba.com>, linux-erofs@lists.ozlabs.org
Cc: chao@kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] erofs: sunset unneeded NOFAILs
Date: Thu, 12 Sep 2024 19:59:30 +0800	[thread overview]
Message-ID: <a7733831-2d1f-4197-9ca9-2ced86aca136@kernel.org> (raw)
In-Reply-To: <20240905084732.2684515-1-hsiangkao@linux.alibaba.com>

On 2024/9/5 16:47, Gao Xiang wrote:
> With iterative development, our codebase can now deal with compressed
> buffer misses properly if both in-place I/O and compressed buffer
> allocation fail.
> 
> Note that if readahead fails (with non-uptodate folios), the original
> request will then fall back to synchronous read, and `.read_folio()`
> should return appropriate errnos; otherwise -EIO will be passed to
> user space, which is unexpected.
> 
> To simplify rarely encountered failure paths, a mimic decompression
> will be just used.  Before that, failure reasons are recorded in
> compressed_bvecs[] and they also act as placeholders to avoid in-place
> pages.  They will be parsed just before decompression and then pass
> back to `.read_folio()`.
> 
> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,

      reply	other threads:[~2024-09-12 11:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-05  8:47 Gao Xiang
2024-09-12 11:59 ` Chao Yu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a7733831-2d1f-4197-9ca9-2ced86aca136@kernel.org \
    --to=chao@kernel.org \
    --cc=hsiangkao@linux.alibaba.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®