From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38FCB33F38A for ; Mon, 15 Jun 2026 11:17:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781522225; cv=none; b=q/8n+q7ND5aiR2LpOz7LCBQGn4Ko53F2jzwjbHcHesH6OtQtTtMnKn2wwnQBTgDFZRGC6SSqNrZ7aAhfFB5EQNsTHEcB2t1IPcMHd+V0E5K3YZj8G80oW38b3TKcr9nAOst3ipm+wUAlULlo3kTQVnvd0UnbXFi/CIcAKVKPf7E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781522225; c=relaxed/simple; bh=d4RFhTaPxFFCmH6AlRCJafNoHTeDvIseqfsOBH9V82I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=L+oE+hYkUtmryphhQWXGy75EgkW9/54v6cj9TONTxElvEuHfR9rex8irZ0SCdQNCPxQG8sKSoujB593cNVQTpQYotWthn8f2MPp08ddnFCFONALx2qzrZXaUpTKObIUujQgypB5cTEZ+1/or1hTf2kPEKOSb61jbe0xtKas9hLg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LKDTr7fE; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LKDTr7fE" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-68d232ed3f9so4862051a12.0 for ; Mon, 15 Jun 2026 04:17:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781522223; x=1782127023; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sga08RS68cA7NsGgPks/diWwawk9O5eve5G9GV8WMYQ=; b=LKDTr7fEWxwmvA5GG6mIW3g8D/lRx7LfQF0YMWaRO3gpE/eSSI3oxDUOpRZwTyBPYA s4h6W/P5PeEN+/69Z1OHqsQNrnoeuJCD8aDSzSgUfreJbQi9t1LN3gYP2/ps3xEFP6Va Auc8CPdrAuZYG7SE4gwjCUKPSdCg2nSH3rBIHlvHkJWPvDx/EePNjOBr4Ym9Lzgy4lpi LVT1iyXxLv4P+lXRBxZjW8VLfGJSWx3YgYMvPHIoz7XdRhmLFzYgP2zZxKiXEBHzvc/X OcLmHQwFX7435NRiJIhXj1q1noDzr2zwkOE1GkTqMYiE/VhCeI/BEBqSgr37G2IjT56K jQ6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781522223; x=1782127023; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sga08RS68cA7NsGgPks/diWwawk9O5eve5G9GV8WMYQ=; b=LWGO4jMHVfTToPp0TImd4e3UQb+4H5O+/L/GLopk81CJxK8+P7qDs+HVZk6T4Zf9MC g3U1cYQUefIpSBDrS0j1l4+qtbnymndL8Jwy0mxTXvjbTHO8UXXgRSfTyIlkWQIkU2Li NFZ9QnCLi9U7QsHoH39B+bhLqTWFm6FVaOLYu8kIL/HqJ0PUnrqv6PukcCu5Y/WiFS21 wfd4n3pAmRKuafps6edrVPj6x6umoLXCLiHK5cB7Ickm3P0XfNZKostWPRV8ckV1XNJ/ +4rmgOUFv+919GpYHJ4rrEGh7osXHGxFFGtmjv/xEpwqP1ln7N2ZN72qSOa4a7lBuSZU mPUA== X-Forwarded-Encrypted: i=1; AFNElJ/N3ZkM+7aSXaSB31JvD+vtHQrxh/kWB2se1q41wd5Lsg0jVMjtU4SSNm+JCIXbttUn/gwLsKs2G2aQ+Vc=@vger.kernel.org X-Gm-Message-State: AOJu0YyHe7SbBtK3g8MQ/bk5FZxQrpE0clRFc5rX9iidvSambGteIO9K NRo3bwyKS7oZ3+Ssc4RYLmVdXRvF5HpfTuab1BNEakReGOIPfU+uhsRPlNNzTw== X-Gm-Gg: Acq92OHnnZArjdcs2RfE84z8Gl8r/lngBSKO6nLbSYPs8G1kGnFvl+ZoxBjk8i/hwiO sdYVTVkFkfMhxXbMhq1zi5nYIdpuIgfIPiCU2+drormwPci44hamMmF1S+rkstGM2wmwXl1SUj/ cEeCCLWxAz+3pra5420OUFjaNn6P0rtgmnLKdaDzxENadhA55sCwaqDNpMSZ+MnXZhIeMSgFXTE 4X2JlYG0Dy8Y3y0ZTPmWtpAGjMOKElRLmcRY3OfRqBRV09Kd7HnfiC9zIgaxUJLqUmOHeKAPAC4 dZ8xD4Wpkk+t3gLRs+kAh57GsR8qdEA8TwSlxLvJxccrUTqv8xT8iKfWzJl8EMqenURTiNjUDcV jWCI0WfHq8RcRJ9Qcs6sMBbfF4AJttxKX+1BvXWevrIIG23VGcPvcakGF2nl8zuFPtt846Qez1N VFjSu+vcpxIzg/aAW4Cr1L2CVS1shvUvJ5VEFywTbk0w3eQpUjN4GJrkrG2OIYjw37hkVdMNWLP rj64YIKagrTtT6yRqWoUU1yy6NgOFiclbtzURCoz0/3sMbk12ERFdhzL30= X-Received: by 2002:a17:907:c305:b0:bec:7661:6397 with SMTP id a640c23a62f3a-bfe2a222b62mr581935066b.29.1781522222408; Mon, 15 Jun 2026 04:17:02 -0700 (PDT) Received: from ?IPV6:2620:10d:c096:325:77fd:1068:74c8:af87? ([2620:10d:c092:600::1:2bf9]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bfdb4b2276fsm452438866b.17.2026.06.15.04.17.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jun 2026 04:17:01 -0700 (PDT) Message-ID: Date: Mon, 15 Jun 2026 12:16:47 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2 1/2] netdev: expose io_uring rx_page_order order via netlink To: Jakub Kicinski , Dragos Tatulea Cc: Donald Hunter , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Andrew Lunn , Jens Axboe , Yael Chemla , Tariq Toukan , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, io-uring@vger.kernel.org References: <20260612211709.1456966-2-dtatulea@nvidia.com> <20260612211709.1456966-3-dtatulea@nvidia.com> <20260613170232.6f9e72ba@kernel.org> Content-Language: en-US From: Pavel Begunkov In-Reply-To: <20260613170232.6f9e72ba@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/14/26 01:02, Jakub Kicinski wrote: > On Sat, 13 Jun 2026 16:09:03 +0200 Dragos Tatulea wrote: >> On 13.06.26 11:53, Pavel Begunkov wrote: >>> On 6/12/26 22:17, Dragos Tatulea wrote: >>>> This adds observability for the io_uring zcrx rx-buf-len configuration. >>> >>> It might be nicer to look it up in the queue, e.g. rxq->mp_params, >>> and make it a queue attribute instead of zcrx specific one. In either >>> case, no objections. >> >> In io_pp_nl_fill() or in page_pool_nl_fill() as it was done in v1 for order? > > It's fine. We decided to make the "page size" a memory provider > property, now we're going back to making it a queue level param? > Like my RFC had that everyone hated so much? Sigh. TBH, I never cared much how nl would show it, so not opposing either version. My idea is that even without plumbing in per-queue non-mp size configuration, it'd be nice to have a common way to check it b/w providers. From the semantics and observability perspective, zcrx is probably not that interesting as the parameter is basically just a hint with no affect on uapi, and I'd assume people would rather see the page pool size or even the NIC's page size. But I guess it depends on what Dragos is really after with this patch. -- Pavel Begunkov