Re: [PATCH] KEYS: include header for EINVAL definition

[Clay Chang <clayc@hpe.com>]

Hi Jarkko,

The issue was found when crypto/public_key.h was included, but CONFIG_ASYMMETRIC_PUBLIC_KEY_SUBTYPE was not enabled. If CONFIG_ASYMMETRIC_PUBLIC_KEY_SUBTYPE was not enabled, the public_key_verify_signature simply returned -EINVAL, which was not declared without linux/errno.h being included.

Thanks,
Clay

On 2024/1/8 10:24 PM, Jarkko Sakkinen wrote:
> On Sun Jan 7, 2024 at 3:28 PM EET,  wrote:
>> From: Clay Chang <clayc@hpe.com>
>>
>> This patch includes linux/errno.h to address the issue of 'EINVAL' being
>> undeclared.
>>
>> Signed-off-by: Clay Chang <clayc@hpe.com>
>> ---
>>  include/crypto/public_key.h | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/include/crypto/public_key.h b/include/crypto/public_key.h
>> index 462f8a34cdf8..b7f308977c84 100644
>> --- a/include/crypto/public_key.h
>> +++ b/include/crypto/public_key.h
>> @@ -10,6 +10,7 @@
>>  #ifndef _LINUX_PUBLIC_KEY_H
>>  #define _LINUX_PUBLIC_KEY_H
>>  
>> +#include <linux/errno.h>
>>  #include <linux/keyctl.h>
>>  #include <linux/oid_registry.h>
>>  
> 
> Please provide evidence that issue exist (applies for any possible kernel issue).
> 
> BR, Jarkko